[v6,0/9] FriendlyELEC NanoPC-T6 improvements

Message

Marcin Juszkiewicz Aug. 29, 2024, 12:26 p.m. UTC

This series updates FriendlyELEC NanoPC-T6 situation. There is non-LTS
(2301) version of a board and LTS (2310) version.

This series creates common DTSI for both boards and then separate
NanoPC-T6 and NanoPC-T6 LTS DTS files. This way T6 gets MiniPCIe section
and T6-LTS gets USB20 section.

Then set of changes for both versions are done:

- enable USB-C port (one orientation only)
- enable Mali GPU
- enable IR receiver (tested using ir-keytable)
- enable SPI flash (present on LTS, optional on non-LTS)
- enable Mask Rom button as input device

Signed-off-by: Marcin Juszkiewicz <[e-mail]>

---
Changes in v6:
- split 2nd patch into parts:
  - create common DTSI
  - move non-LTS (2301) parts to rk3588-nanopc-t6.dts
  - add LTS (2310) in rk3588-nanopc-t6-lts.dts
- Link to v5: https://lore.kernel.org/r/[e-mail]

Changes in v5:
- added Reviewed-by to 'add spi flash' patch
- dropped adding SPI M1 pinctl
- changed ir-receiver to have pinctrl like Jonas Karlman suggested
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4:
- added Acked-by to dt-bindings patch
- create common dtsi for both board versions
- nanopc-t6.dts has minipcie items
- nanopc-t6-lts.dts has usb 2.0 host enablement
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- create separate NanoPC-T6 LTS devicetree as suggested
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- merged changes into NanoPC-T6 dts file
- add SPI flash pinctl for SPI M1
- enable SPI on NanoPC-T6 LTS
- enable USB-C port (one orientation only)
- enable Mali GPI
- enable IR receiver (not tested)
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Marcin Juszkiewicz (9):
      dt-bindings: arm: rockchip: Add NanoPC-T6 LTS
      arm64: dts: rockchip: prepare NanoPC-T6 for LTS board
      arm64: dts: rockchip: move NanoPC-T6 parts to DTS
      arm64: dts: rockchip: add NanoPC-T6 LTS
      arm64: dts: rockchip: add SPI flash on NanoPC-T6
      arm64: dts: rockchip: add IR-receiver to NanoPC-T6
      arm64: dts: rockchip: enable GPU on NanoPC-T6
      arm64: dts: rockchip: enable USB-C on NanoPC-T6
      arm64: dts: rockchip: add Mask Rom key on NanoPC-T6

 .../devicetree/bindings/arm/rockchip.yaml          |   6 +-
 arch/arm64/boot/dts/rockchip/Makefile              |   1 +
 .../boot/dts/rockchip/rk3588-nanopc-t6-lts.dts     |  61 ++
 arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts  | 908 +--------------------
 ...{rk3588-nanopc-t6.dts => rk3588-nanopc-t6.dtsi} | 143 +++-
 5 files changed, 189 insertions(+), 930 deletions(-)
---
base-commit: d5d547aa7b51467b15d9caa86b116f8c2507c72a
change-id: 20240820-friendlyelec-nanopc-t6-lts-00c7678c3bd7

Best regards,

Comments

Heiko Stübner Aug. 29, 2024, 1:22 p.m. UTC | #1

On Thu, 29 Aug 2024 14:26:51 +0200, Marcin Juszkiewicz wrote:
> This series updates FriendlyELEC NanoPC-T6 situation. There is non-LTS
> (2301) version of a board and LTS (2310) version.
> 
> This series creates common DTSI for both boards and then separate
> NanoPC-T6 and NanoPC-T6 LTS DTS files. This way T6 gets MiniPCIe section
> and T6-LTS gets USB20 section.
> 
> [...]

Applied, thanks!

[1/9] dt-bindings: arm: rockchip: Add NanoPC-T6 LTS
      commit: 809b3cb3285da6f98b0a516bf070a1d7bf4f7b2d
[2/9] arm64: dts: rockchip: prepare NanoPC-T6 for LTS board
      commit: d14f3a4f1feabb6bb5935bf3b275a1e6bf2208eb
[3/9] arm64: dts: rockchip: move NanoPC-T6 parts to DTS
      commit: aea8d84070fe0846961deb23228d9dd3f8caefb3
[4/9] arm64: dts: rockchip: add NanoPC-T6 LTS
      commit: db1dcbe5f752d423421f77d54d246398b196f670
[5/9] arm64: dts: rockchip: add SPI flash on NanoPC-T6
      commit: a22a629c63b1addcf2d81eaf30383c1deca5b7a9
[6/9] arm64: dts: rockchip: add IR-receiver to NanoPC-T6
      commit: b70caff0f9592719b6c977e291c33192e959c9d4
[7/9] arm64: dts: rockchip: enable GPU on NanoPC-T6
      commit: e86cbf999cda2d44f32ec622537024e3b923080d
[8/9] arm64: dts: rockchip: enable USB-C on NanoPC-T6
      commit: c9ba75320e5a12dc9d574603acf29b38a920b40c
[9/9] arm64: dts: rockchip: add Mask Rom key on NanoPC-T6
      commit: da439eed06ff6806f22341ab0468226afc555305

Best regards,

Rob Herring (Arm) Aug. 29, 2024, 6:41 p.m. UTC | #2

On Thu, 29 Aug 2024 14:26:51 +0200, Marcin Juszkiewicz wrote:
> This series updates FriendlyELEC NanoPC-T6 situation. There is non-LTS
> (2301) version of a board and LTS (2310) version.
> 
> This series creates common DTSI for both boards and then separate
> NanoPC-T6 and NanoPC-T6 LTS DTS files. This way T6 gets MiniPCIe section
> and T6-LTS gets USB20 section.
> 
> Then set of changes for both versions are done:
> 
> - enable USB-C port (one orientation only)
> - enable Mali GPU
> - enable IR receiver (tested using ir-keytable)
> - enable SPI flash (present on LTS, optional on non-LTS)
> - enable Mask Rom button as input device
> 
> Signed-off-by: Marcin Juszkiewicz <[e-mail]>
> 
> ---
> Changes in v6:
> - split 2nd patch into parts:
>   - create common DTSI
>   - move non-LTS (2301) parts to rk3588-nanopc-t6.dts
>   - add LTS (2310) in rk3588-nanopc-t6-lts.dts
> - Link to v5: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v5:
> - added Reviewed-by to 'add spi flash' patch
> - dropped adding SPI M1 pinctl
> - changed ir-receiver to have pinctrl like Jonas Karlman suggested
> - Link to v4: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v4:
> - added Acked-by to dt-bindings patch
> - create common dtsi for both board versions
> - nanopc-t6.dts has minipcie items
> - nanopc-t6-lts.dts has usb 2.0 host enablement
> - Link to v3: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v3:
> - create separate NanoPC-T6 LTS devicetree as suggested
> - Link to v2: https://lore.kernel.org/r/[e-mail]
> 
> Changes in v2:
> - merged changes into NanoPC-T6 dts file
> - add SPI flash pinctl for SPI M1
> - enable SPI on NanoPC-T6 LTS
> - enable USB-C port (one orientation only)
> - enable Mali GPI
> - enable IR receiver (not tested)
> - Link to v1: https://lore.kernel.org/r/[e-mail]
> 
> ---
> Marcin Juszkiewicz (9):
>       dt-bindings: arm: rockchip: Add NanoPC-T6 LTS
>       arm64: dts: rockchip: prepare NanoPC-T6 for LTS board
>       arm64: dts: rockchip: move NanoPC-T6 parts to DTS
>       arm64: dts: rockchip: add NanoPC-T6 LTS
>       arm64: dts: rockchip: add SPI flash on NanoPC-T6
>       arm64: dts: rockchip: add IR-receiver to NanoPC-T6
>       arm64: dts: rockchip: enable GPU on NanoPC-T6
>       arm64: dts: rockchip: enable USB-C on NanoPC-T6
>       arm64: dts: rockchip: add Mask Rom key on NanoPC-T6
> 
>  .../devicetree/bindings/arm/rockchip.yaml          |   6 +-
>  arch/arm64/boot/dts/rockchip/Makefile              |   1 +
>  .../boot/dts/rockchip/rk3588-nanopc-t6-lts.dts     |  61 ++
>  arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts  | 908 +--------------------
>  ...{rk3588-nanopc-t6.dts => rk3588-nanopc-t6.dtsi} | 143 +++-
>  5 files changed, 189 insertions(+), 930 deletions(-)
> ---
> base-commit: d5d547aa7b51467b15d9caa86b116f8c2507c72a
> change-id: 20240820-friendlyelec-nanopc-t6-lts-00c7678c3bd7
> 
> Best regards,
> --
> Marcin Juszkiewicz <[e-mail]>
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y rockchip/rk3588-nanopc-t6-lts.dtb rockchip/rk3588-nanopc-t6.dtb' for [e-mail]:

arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: video-codec@fdb50000: compatible: 'oneOf' conditional failed, one must be fixed:
	['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu'] is too long
	'rockchip,rk3588-vpu121' is not one of ['rockchip,rk3036-vpu', 'rockchip,rk3066-vpu', 'rockchip,rk3288-vpu', 'rockchip,rk3328-vpu', 'rockchip,rk3399-vpu', 'rockchip,px30-vpu', 'rockchip,rk3568-vpu', 'rockchip,rk3588-av1-vpu']
	'rockchip,rk3188-vpu' was expected
	'rockchip,rk3228-vpu' was expected
	'rockchip,rk3066-vpu' was expected
	'rockchip,rk3399-vpu' was expected
	from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml#
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: /video-codec@fdb50000: failed to match any schema with compatible: ['rockchip,rk3588-vpu121', 'rockchip,rk3568-vpu']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: /video-codec@fdba0000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: /video-codec@fdba4000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: /video-codec@fdba8000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: /video-codec@fdbac000: failed to match any schema with compatible: ['rockchip,rk3588-vepu121']
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: regulator@42: Unevaluated properties are not allowed ('rockchip,suspend-voltage-selector' was unexpected)
	from schema $id: http://devicetree.org/schemas/regulator/fcs,fan53555.yaml#
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: pmic@0: regulators:dcdc-reg4: Unevaluated properties are not allowed ('regulator-init-microvolt' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk806.yaml#
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: pmic@0: Unevaluated properties are not allowed ('regulators' was unexpected)
	from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk806.yaml#
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: codec@1b: Unevaluated properties are not allowed ('assigned-clock-rates', 'assigned-clocks', 'clock-names', 'clocks', 'port' were unexpected)
	from schema $id: http://devicetree.org/schemas/sound/realtek,rt5616.yaml#
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: sound: 'simple-audio-card,hp-pin-name' does not match any of the regexes: '^simple-audio-card,codec(@[0-9a-f]+)?$', '^simple-audio-card,cpu(@[0-9a-f]+)?$', '^simple-audio-card,dai-link(@[0-9a-f]+)?$', '^simple-audio-card,plat(@[0-9a-f]+)?$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/sound/simple-card.yaml#
arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6-lts.dtb: vcc3v3-sd-s0-regulator: Unevaluated properties are not allowed ('enable-active-low' was unexpected)
	from schema $id: http://devicetree.org/schemas/regulator/fixed-regulator.yaml#