From patchwork Sun Nov 23 16:19:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Perier X-Patchwork-Id: 5361871 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 1BF53C11AC for ; Sun, 23 Nov 2014 16:20:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 52FE420253 for ; Sun, 23 Nov 2014 16:20:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98D5520251 for ; Sun, 23 Nov 2014 16:20:06 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XsZtN-0007T7-Os; Sun, 23 Nov 2014 16:20:05 +0000 Received: from mail-wg0-x22e.google.com ([2a00:1450:400c:c00::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XsZtK-0006kC-G8; Sun, 23 Nov 2014 16:20:03 +0000 Received: by mail-wg0-f46.google.com with SMTP id x12so10621441wgg.5 for ; Sun, 23 Nov 2014 08:19:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=rI1TYJaxF6L4ol7I1ivnoVQZcZsrwMzbw0cl/SdL1eE=; b=WsP6kAgCR3XG3PO1seofg3ei8yXDr4nOz9U7mYwz1U5bR+oD+NrCh9qhJAi5lMC4Qs cPpKYhHmGQKIjXTfKDGbks6Z3F9Tvl/ETfBJrc2wrFwyqy9la1WTb6PjKGEDRTRA5Pep RGnkvKfjp7BNsMimi8iMjW1suJbfH7WA7cp7FdsqygKEUv03N7H1k7Jxzr0MYWX0WJpx rg4Q2gBhWqxaLeZJoI7CzjnrjufJ6yKfbsyaSyINNnDL9PAz604q4Ter5+iyzMWgxv22 g44B1nPo9i8wybiHeFt3W69pOn8FXPuRanCOUk/Qaao17ngAjjDvedixEu61EImZu/Ce 0Olg== X-Received: by 10.194.78.82 with SMTP id z18mr25385768wjw.120.1416759579339; Sun, 23 Nov 2014 08:19:39 -0800 (PST) Received: from localhost.localdomain (AToulouse-554-1-141-31.w90-60.abo.wanadoo.fr. [90.60.236.31]) by mx.google.com with ESMTPSA id ji10sm8017030wid.7.2014.11.23.08.19.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 23 Nov 2014 08:19:38 -0800 (PST) From: Romain Perier To: heiko@sntech.de Subject: [PATCH v1] ARM: dts: rockchip: Update LEDs to work with the last leds-gpio driver on radxarock Date: Sun, 23 Nov 2014 16:19:35 +0000 Message-Id: <1416759575-774-1-git-send-email-romain.perier@gmail.com> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141123_082002_690318_DF41135F X-CRM114-Status: UNSURE ( 8.55 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The leds-gpio driver recently switched to the device property API. The device_node name is no longer retrieved if the "label" devicetree property is not found. In this case the driver tries to create entries with (null) name in /sys/class/leds, which is wrong and generates backtrace as several gpio_leds have the same name. Also renamed subnode "yellow" to "blue" to match the last schematics updates. Signed-off-by: Romain Perier --- arch/arm/boot/dts/rk3188-radxarock.dts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/rk3188-radxarock.dts b/arch/arm/boot/dts/rk3188-radxarock.dts index 6eb62c0..9a09579 100644 --- a/arch/arm/boot/dts/rk3188-radxarock.dts +++ b/arch/arm/boot/dts/rk3188-radxarock.dts @@ -43,16 +43,19 @@ compatible = "gpio-leds"; green { + label = "rock:green:user1"; gpios = <&gpio0 12 GPIO_ACTIVE_LOW>; default-state = "off"; }; - yellow { + blue { + label = "rock:blue:user2"; gpios = <&gpio0 14 GPIO_ACTIVE_LOW>; default-state = "off"; }; sleep { + label = "rock:red:power"; gpios = <&gpio0 15 0>; default-state = "off"; };