From patchwork Mon Jan 19 18:08:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Romain Perier X-Patchwork-Id: 5660121 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D03B39F357 for ; Mon, 19 Jan 2015 18:08:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0C4D920451 for ; Mon, 19 Jan 2015 18:08:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C28D20117 for ; Mon, 19 Jan 2015 18:08:54 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YDGkv-0007wE-Hp; Mon, 19 Jan 2015 18:08:53 +0000 Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YDGkg-0007lD-1S; Mon, 19 Jan 2015 18:08:39 +0000 Received: by mail-wi0-f169.google.com with SMTP id bs8so18450058wib.0; Mon, 19 Jan 2015 10:08:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Ar2m3qYlCPg7jLI+c9ZSiZzwVRFxp5xHuZRtH8eckl8=; b=kYG/UwSX3CKGz/zGrlP/AriVXZt51kMfwSVIK4vy8wBHW0qwXYdCZPpq3jSDpSEFCz aDRjbm3hOVDg05ZLC62IhLuojkq9krfFO4gaQPCy32SiDmPVtiUgdv4c6iq7J/S9iVpg 9BPVXlwRqS2uVAC+MqmPnPO+NRI+X07VS5G/NYXXkrkJrLx7UlFbfVgPIxJMD13o4sJo XpN0z6TwWrf/BGYh4xH/IY0LlgRi6ytY1Ffo0iojXLrfD2Yj9jl6A5o4y2t5BoVZZOOE cFxaD21MVT87+DUU5BknCTevzsfeUVIbRilkh3aZFXXiAh9cm//YTteHuDPaY5VDZhTN uv0w== X-Received: by 10.180.98.162 with SMTP id ej2mr37670433wib.39.1421690893858; Mon, 19 Jan 2015 10:08:13 -0800 (PST) Received: from localhost.localdomain (AToulouse-554-1-139-234.w90-60.abo.wanadoo.fr. [90.60.234.234]) by mx.google.com with ESMTPSA id gf9sm18198011wjc.0.2015.01.19.10.08.12 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Jan 2015 10:08:13 -0800 (PST) From: Romain Perier To: peppe.cavallaro@st.com Subject: [PATCH v1 1/4] net: stmmac: dwmac-rk: Don't set the regulator voltage for phy from the driver Date: Mon, 19 Jan 2015 18:08:06 +0000 Message-Id: <1421690889-11901-2-git-send-email-romain.perier@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1421690889-11901-1-git-send-email-romain.perier@gmail.com> References: <1421690889-11901-1-git-send-email-romain.perier@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150119_100838_289616_E5DC7FBB X-CRM114-Status: UNSURE ( 9.59 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.8 (/) Cc: devicetree@vger.kernel.org, heiko@sntech.de, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, roger.chen@rock-chips.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As these settings can be directly expressed from devicetree for both fixed regulators and pmic-integrated regulators, it is more standard to set them from dts and let the regulator framework use the right voltage informations when it is used in the driver. Signed-off-by: Romain Perier --- drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c index 35f9b86..06e1637 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c @@ -303,7 +303,6 @@ static int phy_power_on(struct rk_priv_data *bsp_priv, bool enable) } else { if (enable) { if (!regulator_is_enabled(ldo)) { - regulator_set_voltage(ldo, 3300000, 3300000); ret = regulator_enable(ldo); if (ret != 0) dev_err(dev, "%s: fail to enable %s\n",