From patchwork Sat Nov 7 01:23:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 7574381 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id AB7759FCBF for ; Sat, 7 Nov 2015 01:26:58 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BC2AD20721 for ; Sat, 7 Nov 2015 01:26:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF95C206FF for ; Sat, 7 Nov 2015 01:26:56 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZusHQ-0002rR-Hf; Sat, 07 Nov 2015 01:26:56 +0000 Received: from mail-pa0-x231.google.com ([2607:f8b0:400e:c03::231]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZusHN-0002o2-O0 for linux-rockchip@lists.infradead.org; Sat, 07 Nov 2015 01:26:54 +0000 Received: by pacdm15 with SMTP id dm15so114480554pac.3 for ; Fri, 06 Nov 2015 17:26:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H7RJLnca35YWsezP3AoYPpbs3rLUeAabB/IA6IOFI3M=; b=SXm/bg2oCHTaBsYzR+Nv4DVaNti8kpmRRSn1Qtvn3GPMQptjlx4IvaWb64aVtVggWA rf/Z15SEDKoa8sbj0JBUNZK7mMOaUrw3vtWwLgZhhJLOaP8SA12W4ezAt4jzvjBFLJk7 OrwTVmjHaIC8oxI4gLFVwpaF3qN4ROlPO208Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H7RJLnca35YWsezP3AoYPpbs3rLUeAabB/IA6IOFI3M=; b=A9iogI5AqM+pzIEo+T5aWtlUqOGnEC/0zIBnL9puEYChbiZZIF/Rrmdqdq+B9IsY2G ZdJOTZaUZa0fr7VOAhdGFOut34W+lCOp6i+vrNVMpIjMLK3jK+7UjmcZmDJEPh19Co2E wbj6fhZWlJkMoDBHRKK6Zm+zqSCs8TH1ssGnLIgfbUBCcKJ7n/ljZhHnazgUCAFD+Beg ALbA5rAg0fIz7Sl8ExXrnVHyuli7rDstbZQJ0KvQDrzEqMvi0JW0d/XNOsw4VeCRL/xt fVwAVOWwBeqn8FYlcEQALmiRsV1eWbkHn6BbDS/Bmyvzd1073RJF0RrabAVajNNF8Dqz dApg== X-Gm-Message-State: ALoCoQkA/Se3NKkjw2fsbqEfiL/ps7MUphq7RQcMatSdVkCNDHXv0dUrSdD9PJFAQ412RlD0WvOM X-Received: by 10.67.22.66 with SMTP id hq2mr21456649pad.81.1446859592888; Fri, 06 Nov 2015 17:26:32 -0800 (PST) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id y3sm2337474pbt.23.2015.11.06.17.26.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 06 Nov 2015 17:26:32 -0800 (PST) From: Douglas Anderson To: John Youn , balbi@ti.com Subject: [PATCH v2 1/4] usb: dwc2: rockchip: Make the max_transfer_size automatic Date: Fri, 6 Nov 2015 17:23:59 -0800 Message-Id: <1446859442-5413-2-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.6.0.rc2.230.g3dd15c0 In-Reply-To: <1446859442-5413-1-git-send-email-dianders@chromium.org> References: <1446859442-5413-1-git-send-email-dianders@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151106_172653_890787_4B1CD116 X-CRM114-Status: GOOD ( 11.61 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregory.herrero@intel.com, =?UTF-8?q?Heiko=20St=C3=BCbner?= , johnyoun@synopsys.com, gregkh@linuxfoundation.org, ming.lei@canonical.com, linux-usb@vger.kernel.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, yousaf.kaukab@intel.com, stern@rowland.harvard.edu, Yunzhi Li , Julius Werner , dinguyen@opensource.altera.com MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously we needed to set the max_transfer_size to explicitly be 65535 because the old driver would detect that our hardware could support much bigger transfers and then would try to do them. This wouldn't work since the DMA alignment code couldn't support it. Later in commit e8f8c14d9da7 ("usb: dwc2: clip max_transfer_size to 65535") upstream added support for clipping this automatically. Since that commit it has been OK to just use "-1" (default), but nobody bothered to change it. Let's change it to default now for two reasons: - It's nice to use autodetected params. - If we can remove the 65535 limit, we can transfer more! Signed-off-by: Douglas Anderson Tested-by: Heiko Stuebner --- Changes in v2: None drivers/usb/dwc2/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 5859b0fa19ee..f26e0c31c07e 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -95,7 +95,7 @@ static const struct dwc2_core_params params_rk3066 = { .host_rx_fifo_size = 520, /* 520 DWORDs */ .host_nperio_tx_fifo_size = 128, /* 128 DWORDs */ .host_perio_tx_fifo_size = 256, /* 256 DWORDs */ - .max_transfer_size = 65535, + .max_transfer_size = -1, .max_packet_count = -1, .host_channels = -1, .phy_type = -1,