diff mbox

[v2,3/3] dt-bindings: add document for rk3229-vop

Message ID 1451966436-12733-1-git-send-email-ykk@rock-chips.com (mailing list archive)
State New, archived
Headers show

Commit Message

Yakir Yang Jan. 5, 2016, 4 a.m. UTC 
Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v2:
- acked by Rob

 Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring (Arm) Jan. 5, 2016, 4:06 p.m. UTC | #1 
On Mon, Jan 4, 2016 at 10:00 PM, Yakir Yang <ykk@rock-chips.com> wrote:
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Changes in v2:
> - acked by Rob

It doesn't hurt, but there is no point to send a new version just to
add acks. The maintainer should add any for the current version. If
you do send a new version with changes, then it is your responsibility
to add acks. Maintainers are not going to look at older versions.

Rob
Yakir Yang Jan. 6, 2016, 12:46 a.m. UTC | #2 
On 01/06/2016 12:06 AM, Rob Herring wrote:
> On Mon, Jan 4, 2016 at 10:00 PM, Yakir Yang <ykk@rock-chips.com> wrote:
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>> Changes in v2:
>> - acked by Rob
> It doesn't hurt, but there is no point to send a new version just to
> add acks. The maintainer should add any for the current version. If
> you do send a new version with changes, then it is your responsibility
> to add acks. Maintainers are not going to look at older versions.

Got it  :)

- Yakir

> Rob
>
>
>
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
index 5489b59..75ebc20 100644
--- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
+++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
@@ -7,6 +7,7 @@  buffer to an external LCD interface.
 Required properties:
 - compatible: value should be one of the following
 		"rockchip,rk3288-vop";
+		"rockchip,rk3229-vop";
 		"rockchip,rk3036-vop";
 
 - interrupts: should contain a list of all VOP IP block interrupts in the