From patchwork Thu Jan 21 05:04:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 8077461 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 54508BEEE5 for ; Thu, 21 Jan 2016 05:05:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 75D9E205DB for ; Thu, 21 Jan 2016 05:05:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97BAC205DA for ; Thu, 21 Jan 2016 05:05:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aM7R0-0000bC-Os; Thu, 21 Jan 2016 05:05:26 +0000 Received: from mail-pf0-x22c.google.com ([2607:f8b0:400e:c00::22c]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aM7Qy-0000Yo-0g for linux-rockchip@lists.infradead.org; Thu, 21 Jan 2016 05:05:24 +0000 Received: by mail-pf0-x22c.google.com with SMTP id 65so16894476pff.2 for ; Wed, 20 Jan 2016 21:05:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=x5hvYfi+/9btUcy9Y1LMauUcWkmeC4umhHPQSTfO8KM=; b=B1+VfYWyU9ENUtq6dunJPU7QVv5YRbjxWgN7SdXw0vQBmaYqJTfPlQqgJdWINzrUyU /pXA7h5LKWUzKMI9hKctZDUZlZEhFS5Td1cn9ps5B+gZKtMM8RG40Itte74UEYWXzAcz 9eYD6yfB0f86vR2NISARXNImEeVpid3hc52Gw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=x5hvYfi+/9btUcy9Y1LMauUcWkmeC4umhHPQSTfO8KM=; b=JBTUDbrHeuuwbZ/walSXbFg2oik2XGD350/08h4p6x8XyP0k6Rt/1c0XtRAviHlqoK SxqhpftZQiDX0dJTqCMieRol/Hyj8jfbSHZJ5ZfUdAJ4/JN5FT2Z6i5hQv0PBpufNJ1y 7Us/xErMOxLfygO7glC+fOcNoo6EWylOlCmXvvh8ZBgXWujYVG/MQKR0cKhI+EcIQ6A/ NHzIgMRM+brbPYBwA+yrFFwyy1vFV+J3qWUzdmHRPOGg5ZX+KMlnDImeafCEtxDzx62e j7NgUApg5NOmqCnaWzBIP+jHEbp5P0Ab5ThEBRRpGW70S/zgCe7ssUV9kNICAXuw1U33 pezw== X-Gm-Message-State: ALoCoQnI7EyrjyyWlqDrK5E7LjKDm7CbHnqkXUDj0ByRvy1F52woD4wxgjqT2HEzXm6n65Kq0m2mM5TzkSZGHdxK3/e6UqUGkA== X-Received: by 10.98.18.76 with SMTP id a73mr57797065pfj.65.1453352706272; Wed, 20 Jan 2016 21:05:06 -0800 (PST) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id z28sm52255589pfi.19.2016.01.20.21.05.05 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Jan 2016 21:05:05 -0800 (PST) From: Douglas Anderson To: John Youn , balbi@ti.com, kever.yang@rock-chips.com Subject: [PATCH v4 04/21] usb: dwc2: host: Set host_perio_tx_fifo_size to 304 for rk3066 Date: Wed, 20 Jan 2016 21:04:15 -0800 Message-Id: <1453352672-27890-5-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1453352672-27890-1-git-send-email-dianders@chromium.org> References: <1453352672-27890-1-git-send-email-dianders@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160120_210524_159317_6E1115F0 X-CRM114-Status: GOOD ( 10.43 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregory.herrero@intel.com, =?UTF-8?q?Heiko=20St=C3=BCbner?= , johnyoun@synopsys.com, gregkh@linuxfoundation.org, ming.lei@canonical.com, linux-usb@vger.kernel.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, yousaf.kaukab@intel.com, stern@rowland.harvard.edu, Julius Werner , dinguyen@opensource.altera.com MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Looking at rk3288, there are two dwc2 ports. One has 960 total_fifo_size and the other 972. We're currently assigning 528 + 128 + 256 = 912. That means we're wasting 48 words on one port and 60 words on the other. Since we have one settings block for both ports, let's just eat the 48 words that we know we have and assign them to what's probably the most latency-senstive part of the system: periodic transfers. Presumably other rk3288 parts using the rk3066 settings also have these extra 48 words as well. Note: ideally we'd adjust dwc2_calculate_dynamic_fifo() to handle this more dynamically, but until that's done hardcoding things here seems OK. NOTE: no known use cases are improved by this patch, but in my stressful USB tests I certainly see my periodic FIFO filling up both before and after this change. Presumably there are some USB configurations where the periodic FIFO would have been filled before where it no longer is. Signed-off-by: Douglas Anderson --- Changes in v4: - Set host_perio_tx_fifo_size to 304 for rk3066 new for v4. Changes in v3: None Changes in v2: None drivers/usb/dwc2/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index b6d7666e715c..afdcdeee266d 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -128,7 +128,7 @@ static const struct dwc2_core_params params_rk3066 = { .en_multiple_tx_fifo = -1, .host_rx_fifo_size = 528, /* 528 DWORDs */ .host_nperio_tx_fifo_size = 128, /* 128 DWORDs */ - .host_perio_tx_fifo_size = 256, /* 256 DWORDs */ + .host_perio_tx_fifo_size = 304, /* 304 DWORDs */ .max_transfer_size = -1, .max_packet_count = -1, .host_channels = -1,