From patchwork Mon Mar 7 22:00:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 8523401 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 558BFC0553 for ; Mon, 7 Mar 2016 22:02:24 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 76B8D2022D for ; Mon, 7 Mar 2016 22:02:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CAC620256 for ; Mon, 7 Mar 2016 22:02:22 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ad3EL-0008So-Tk; Mon, 07 Mar 2016 22:02:21 +0000 Received: from mail-pf0-x232.google.com ([2607:f8b0:400e:c00::232]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ad3Dj-0007hk-UH for linux-rockchip@lists.infradead.org; Mon, 07 Mar 2016 22:01:46 +0000 Received: by mail-pf0-x232.google.com with SMTP id 63so86810295pfe.3 for ; Mon, 07 Mar 2016 14:01:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=I7o4TRyi32+Ucqzp2YFOb6Q9cmCDOxmbqxjbx0YKau4=; b=IVsoopoAaNDe+JQm+dXp6C3k7huv76GbivYt4EP9IVLZqI2aH2faVaRy3pERFeirXw oI3pZaQngfaDY42wbx2pK8D8RE0QlsHHjekwpIkfNCNNdSPr3sszDSnzI26vuPNDWJam 0ooa4paUWu+wm3B9zVZkOFuhi30dO8zZVsQes= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=I7o4TRyi32+Ucqzp2YFOb6Q9cmCDOxmbqxjbx0YKau4=; b=a/RKqRrww1vmzBdBtELB4yQ1STU529FYwJ+gTWCfOoH2qKe56F1oN1IBtW7u0BuEh4 dZOsowygOhG9h8Hqd282A18D0qF9c9Do8X9m4mbY4aQJttz40Epz5mfr+vldDEqXP8BX 3MJWFyy8+YSobUdBfSdwJs1QEmMhRJnKgDDP8QTeuhodid25j0b7VMy5ydNJVnMeyQ9K SQ39wztMfGXU5qEkKgoh/FolSQN0RT1raW0vp4foE2EbR0Dae7ZgFSZ11owsasK2ZSqL 4Rj8GbiBFga/SSc5632s3S+faO17ADecKYn+1M20RRhrkL7KruU+2lNhvmSw/zPytUIg IWbg== X-Gm-Message-State: AD7BkJLLt+bhEfAOH3JjaflFWWfJzpeNzTND9VjiDnZjclCxwnFr1mkR62nUclUfk6TP2Q== X-Received: by 10.98.14.67 with SMTP id w64mr36928737pfi.154.1457388083235; Mon, 07 Mar 2016 14:01:23 -0800 (PST) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id p26sm19964195pfi.84.2016.03.07.14.01.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Mar 2016 14:01:22 -0800 (PST) From: Douglas Anderson To: Mark Yao , David Airlie , linux@arm.linux.org.uk, Heiko Stuebner Subject: [PATCH v2 4/5] drm/rockchip: dw_hdmi: Don't call platform_set_drvdata() Date: Mon, 7 Mar 2016 14:00:53 -0800 Message-Id: <1457388054-23077-4-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1457388054-23077-1-git-send-email-dianders@chromium.org> References: <1457388054-23077-1-git-send-email-dianders@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160307_140144_298757_10B10230 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: john@keeping.me.uk, Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Daniel Kurtz , linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The Rockchip dw_hdmi driver just called platform_set_drvdata() to get your hopes up that maybe, somehow, you'd be able to retrieve the 'struct rockchip_hdmi' from a pointer to the 'struct device'. You can't. When we call dw_hdmi_bind() the main driver calls dev_set_drvdata(), which clobbers our setting. Let's just remove the platform_set_drvdata() to avoid dashing people's hopes. Signed-off-by: Douglas Anderson --- Changes in v2: - Don't call platform_set_drvdata() new for v2. drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c index 88776aba984e..d5cfef75fc80 100644 --- a/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c +++ b/drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c @@ -271,8 +271,6 @@ static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, if (!iores) return -ENXIO; - platform_set_drvdata(pdev, hdmi); - encoder->possible_crtcs = drm_of_find_possible_crtcs(drm, dev->of_node); /* * If we failed to find the CRTC(s) which this encoder is