From patchwork Mon Jun 6 11:44:48 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 9157915 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A2051607FD for ; Mon, 6 Jun 2016 11:45:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 93E3B27D45 for ; Mon, 6 Jun 2016 11:45:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 885362780C; Mon, 6 Jun 2016 11:45:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A04B42780C for ; Mon, 6 Jun 2016 11:45:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1b9syV-0001lQ-AD; Mon, 06 Jun 2016 11:45:43 +0000 Received: from mail-pa0-f66.google.com ([209.85.220.66]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1b9syT-0001cW-JD for linux-rockchip@lists.infradead.org; Mon, 06 Jun 2016 11:45:42 +0000 Received: by mail-pa0-f66.google.com with SMTP id di3so11696399pab.0 for ; Mon, 06 Jun 2016 04:45:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=NHWu8PO9sxJ/B+qpESovpaTYCzleF7SLdX+LiSV2xxE=; b=WHwtJ237H7nnnfhmd86gyOG5NdoDniHb5zcB9wO4ddIrM6t5xVOH+efeFpzbAYoBqV GEVoQiHZnkbkN9PTPkibJSngIGMbyi/0HH21H2GCN9x3QcqTdrW+uuOqVOIeX4mMcPEz 6QWMJGHUITqFR1dFcEoQI0nr1BU18LZF5jD3mNjI20a2m0CASptET5bcu8fM8kTAKPRP 1Ac+m9k+FubJsP756qtxW13dZLFTdBJdJpYsKYzeNXT+u3yIH7KhnOm81SInnPwh1KNi /xTNfQD0pZD4GZge7aGyJNa4c3m0Jv4i4c5ZioO2pJMgyTmJBZbqb5p53y7euujpwKe7 gXXA== X-Gm-Message-State: ALyK8tKdbxfsODvrazylbTDnKzHve+MStdx3OihlL8RiPP9HhuX4gs+K4xxnMCkk0i7+Iw== X-Received: by 10.66.157.193 with SMTP id wo1mr24437747pab.116.1465213525193; Mon, 06 Jun 2016 04:45:25 -0700 (PDT) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id g82sm27196446pfj.22.2016.06.06.04.45.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 06 Jun 2016 04:45:24 -0700 (PDT) From: Caesar Wang To: edubezval@gmail.com, linux-pm@vger.kernel.org Subject: [PATCH v5 4/5] thermal: bang-bang governor: act on lower trip boundary Date: Mon, 6 Jun 2016 19:44:48 +0800 Message-Id: <1465213489-14898-5-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465213489-14898-1-git-send-email-wxt@rock-chips.com> References: <1465213489-14898-1-git-send-email-wxt@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160606_044541_666541_C1B3B607 X-CRM114-Status: GOOD ( 11.17 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: huangtao@rock-chips.com, javi.merino@arm.com, Heiko Stuebner , Sascha Hauer , dmitry.torokhov@gmail.com, peter@piie.net, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, smbarber@google.com, cf@rock-chips.com, briannorris@google.com, Zhang Rui , Caesar Wang MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Sascha Hauer With interrupt driven thermal zones we pass the lower and upper temperature on which shall be acted, so in the governor we have to act on the exact lower temperature to be consistent. Otherwise an interrupt maybe generated on the exact lower temperature, but the bang bang governor does not react since The polling driven zones have to be one step cooler before the governor reacts. Signed-off-by: Sascha Hauer Signed-off-by: Caesar Wang Cc: Zhang Rui Cc: Eduardo Valentin Cc: linux-pm@vger.kernel.org Acked-by: Peter Feuerer --- Changes in v5: None Changes in v4: None Changes in v3: - Add the peter's ACK. Changes in v2: - Update the commit for patch[v2 4/5]. drivers/thermal/gov_bang_bang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/gov_bang_bang.c b/drivers/thermal/gov_bang_bang.c index fc52016..5073871 100644 --- a/drivers/thermal/gov_bang_bang.c +++ b/drivers/thermal/gov_bang_bang.c @@ -65,7 +65,7 @@ static void thermal_zone_trip_update(struct thermal_zone_device *tz, int trip) if (instance->target == 0 && tz->temperature >= trip_temp) instance->target = 1; else if (instance->target == 1 && - tz->temperature < trip_temp - trip_hyst) + tz->temperature <= trip_temp - trip_hyst) instance->target = 0; dev_dbg(&instance->cdev->device, "target=%d\n",