| Message ID | 1465783810-18756-2-git-send-email-frank.wang@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Montag, 13. Juni 2016, 10:10:09 schrieb Frank Wang: > Signed-off-by: Frank Wang <frank.wang@rock-chips.com> looks really cool now, thanks for addressing all the review comments Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > > Changes in v5: > - Added 'reg' property to identify the different phy-blocks. > > Changes in v4: > - Used 'phy-supply' instead of 'vbus_*-supply'. > > Changes in v3: > - Added 'clocks' and 'clock-names' optional properties. > - Specified 'otg-port' and 'host-port' as the sub-node name. > > Changes in v2: > - Changed vbus_host optional property from gpio to regulator. > - Specified vbus_otg-supply optional property. > - Specified otg_id and otg_bvalid property. > > .../bindings/phy/phy-rockchip-inno-usb2.txt | 64 > ++++++++++++++++++++ 1 file changed, 64 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > > diff --git > a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt new file > mode 100644 > index 0000000..48bb5de > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > @@ -0,0 +1,64 @@ > +ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK > + > +Required properties (phy (parent) node): > + - compatible : should be one of the listed compatibles: > + * "rockchip,rk3366-usb2phy" > + * "rockchip,rk3399-usb2phy" > + - reg : the address offset of grf for usb-phy configuration. > + - #clock-cells : should be 0. > + - clock-output-names : specify the 480m output clock name. > + > +Optional properties: > + - clocks : phandle + phy specifier pair, for the input clock of phy. > + - clock-names : input clock name of phy, must be "phyclk". > + > +Required nodes : a sub-node is required for each port the phy provides. > + The sub-node name is used to identify host or otg port, > + and shall be the following entries: > + * "otg-port" : the name of otg port. > + * "host-port" : the name of host port. > + > +Required properties (port (child) node): > + - #phy-cells : must be 0. See ./phy-bindings.txt for details. > + - interrupts : specify an interrupt for each entry in interrupt-names. > + - interrupt-names : a list which shall be the following entries: > + * "otg_id" : for the otg id interrupt. > + * "otg_bvalid" : for the otg vbus interrupt. > + * "linestate" : for the host/otg linestate interrupt. > + > +Optional properties: > + - phy-supply : phandle to a regulator that provides power to VBUS. > + See ./phy-bindings.txt for details. > + > +Example: > + > +grf: syscon@ff770000 { > + compatible = "rockchip,rk3366-grf", "syscon", "simple-mfd"; > + #address-cells = <1>; > + #size-cells = <1>; > + > +... > + > + u2phy: usb2-phy@700 { > + compatible = "rockchip,rk3366-usb2phy"; > + reg = <0x700 0x2c>; > + #clock-cells = <0>; > + clock-output-names = "sclk_otgphy0_480m"; > + > + u2phy_otg: otg-port { > + #phy-cells = <0>; > + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "otg_id", "otg_bvalid", "linestate"; > + status = "okay"; > + }; > + > + u2phy_host: host-port { > + #phy-cells = <0>; > + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "linestate"; > + status = "okay"; > + }; > + }; > +};
Am Montag, 13. Juni 2016, 10:38:39 schrieb Heiko Stübner: > Am Montag, 13. Juni 2016, 10:10:09 schrieb Frank Wang: > > Signed-off-by: Frank Wang <frank.wang@rock-chips.com> > > looks really cool now, thanks for addressing all the review comments > > Reviewed-by: Heiko Stuebner <heiko@sntech.de> You've only added the very common "reg" property, so I guess it should be just fine to keep Rob's Ack on the binding in that case. I noticed one thing below though. As you'll probably need to do another version (see comments to patch2), you could change that as well in both here and in the second patch - see below: > > --- > > > > Changes in v5: > > - Added 'reg' property to identify the different phy-blocks. > > > > Changes in v4: > > - Used 'phy-supply' instead of 'vbus_*-supply'. > > > > Changes in v3: > > - Added 'clocks' and 'clock-names' optional properties. > > - Specified 'otg-port' and 'host-port' as the sub-node name. > > > > Changes in v2: > > - Changed vbus_host optional property from gpio to regulator. > > - Specified vbus_otg-supply optional property. > > - Specified otg_id and otg_bvalid property. > > > > .../bindings/phy/phy-rockchip-inno-usb2.txt | 64 > > > > ++++++++++++++++++++ 1 file changed, 64 insertions(+) > > > > create mode 100644 > > > > Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > > > > diff --git > > a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > > b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt new > > file > > mode 100644 > > index 0000000..48bb5de > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > > @@ -0,0 +1,64 @@ > > +ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK > > + > > +Required properties (phy (parent) node): > > + - compatible : should be one of the listed compatibles: > > + * "rockchip,rk3366-usb2phy" > > + * "rockchip,rk3399-usb2phy" > > + - reg : the address offset of grf for usb-phy configuration. > > + - #clock-cells : should be 0. > > + - clock-output-names : specify the 480m output clock name. > > + > > +Optional properties: > > + - clocks : phandle + phy specifier pair, for the input clock of phy. > > + - clock-names : input clock name of phy, must be "phyclk". > > + > > +Required nodes : a sub-node is required for each port the phy provides. > > + The sub-node name is used to identify host or otg port, > > + and shall be the following entries: > > + * "otg-port" : the name of otg port. > > + * "host-port" : the name of host port. > > + > > +Required properties (port (child) node): > > + - #phy-cells : must be 0. See ./phy-bindings.txt for details. > > + - interrupts : specify an interrupt for each entry in interrupt-names. > > + - interrupt-names : a list which shall be the following entries: > > + * "otg_id" : for the otg id interrupt. > > + * "otg_bvalid" : for the otg vbus interrupt. please use "-" not underscores in dt-bindings, so "otg-id", "otg-bvalid". > > + * "linestate" : for the host/otg linestate interrupt. > > + > > +Optional properties: > > + - phy-supply : phandle to a regulator that provides power to VBUS. > > + See ./phy-bindings.txt for details. > > + > > +Example: > > + > > +grf: syscon@ff770000 { > > + compatible = "rockchip,rk3366-grf", "syscon", "simple-mfd"; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > +... > > + > > + u2phy: usb2-phy@700 { > > + compatible = "rockchip,rk3366-usb2phy"; > > + reg = <0x700 0x2c>; > > + #clock-cells = <0>; > > + clock-output-names = "sclk_otgphy0_480m"; > > + > > + u2phy_otg: otg-port { > > + #phy-cells = <0>; > > + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>, > > + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "otg_id", "otg_bvalid", "linestate"; again "-" not "_". > > + status = "okay"; > > + }; > > + > > + u2phy_host: host-port { > > + #phy-cells = <0>; > > + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; > > + interrupt-names = "linestate"; > > + status = "okay"; > > + }; > > + }; > > +};
On Mon, Jun 13, 2016 at 10:10:09AM +0800, Frank Wang wrote: > Signed-off-by: Frank Wang <frank.wang@rock-chips.com> > --- > > Changes in v5: > - Added 'reg' property to identify the different phy-blocks. > > Changes in v4: > - Used 'phy-supply' instead of 'vbus_*-supply'. > > Changes in v3: > - Added 'clocks' and 'clock-names' optional properties. > - Specified 'otg-port' and 'host-port' as the sub-node name. > > Changes in v2: > - Changed vbus_host optional property from gpio to regulator. > - Specified vbus_otg-supply optional property. > - Specified otg_id and otg_bvalid property. > > .../bindings/phy/phy-rockchip-inno-usb2.txt | 64 ++++++++++++++++++++ > 1 file changed, 64 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt Acked-by: Rob Herring <robh@kernel.org>
Hi Heiko, On 2016/6/14 21:28, Heiko Stübner wrote: > Am Montag, 13. Juni 2016, 10:38:39 schrieb Heiko Stübner: >> Am Montag, 13. Juni 2016, 10:10:09 schrieb Frank Wang: >>> Signed-off-by: Frank Wang <frank.wang@rock-chips.com> >> looks really cool now, thanks for addressing all the review comments >> >> Reviewed-by: Heiko Stuebner <heiko@sntech.de> > You've only added the very common "reg" property, so I guess it should be just > fine to keep Rob's Ack on the binding in that case. OK, I will keep Rob's Ack in the next patch. > I noticed one thing below though. > As you'll probably need to do another version (see comments to patch2), you > could change that as well in both here and in the second patch - see below: Well, I will correct them and send out with a new version later. >>> --- >>> >>> Changes in v5: >>> - Added 'reg' property to identify the different phy-blocks. >>> >>> Changes in v4: >>> - Used 'phy-supply' instead of 'vbus_*-supply'. >>> >>> Changes in v3: >>> - Added 'clocks' and 'clock-names' optional properties. >>> - Specified 'otg-port' and 'host-port' as the sub-node name. >>> >>> Changes in v2: >>> - Changed vbus_host optional property from gpio to regulator. >>> - Specified vbus_otg-supply optional property. >>> - Specified otg_id and otg_bvalid property. >>> >>> .../bindings/phy/phy-rockchip-inno-usb2.txt | 64 >>> >>> ++++++++++++++++++++ 1 file changed, 64 insertions(+) >>> >>> create mode 100644 >>> >>> Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >>> >>> diff --git >>> a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >>> b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt new >>> file >>> mode 100644 >>> index 0000000..48bb5de >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt >>> @@ -0,0 +1,64 @@ >>> +ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK >>> + >>> +Required properties (phy (parent) node): >>> + - compatible : should be one of the listed compatibles: >>> + * "rockchip,rk3366-usb2phy" >>> + * "rockchip,rk3399-usb2phy" >>> + - reg : the address offset of grf for usb-phy configuration. >>> + - #clock-cells : should be 0. >>> + - clock-output-names : specify the 480m output clock name. >>> + >>> +Optional properties: >>> + - clocks : phandle + phy specifier pair, for the input clock of phy. >>> + - clock-names : input clock name of phy, must be "phyclk". >>> + >>> +Required nodes : a sub-node is required for each port the phy provides. >>> + The sub-node name is used to identify host or otg port, >>> + and shall be the following entries: >>> + * "otg-port" : the name of otg port. >>> + * "host-port" : the name of host port. >>> + >>> +Required properties (port (child) node): >>> + - #phy-cells : must be 0. See ./phy-bindings.txt for details. >>> + - interrupts : specify an interrupt for each entry in interrupt-names. >>> + - interrupt-names : a list which shall be the following entries: >>> + * "otg_id" : for the otg id interrupt. >>> + * "otg_bvalid" : for the otg vbus interrupt. > please use "-" not underscores in dt-bindings, so "otg-id", "otg-bvalid". > > >>> + * "linestate" : for the host/otg linestate interrupt. >>> + >>> +Optional properties: >>> + - phy-supply : phandle to a regulator that provides power to VBUS. >>> + See ./phy-bindings.txt for details. >>> + >>> +Example: >>> + >>> +grf: syscon@ff770000 { >>> + compatible = "rockchip,rk3366-grf", "syscon", "simple-mfd"; >>> + #address-cells = <1>; >>> + #size-cells = <1>; >>> + >>> +... >>> + >>> + u2phy: usb2-phy@700 { >>> + compatible = "rockchip,rk3366-usb2phy"; >>> + reg = <0x700 0x2c>; >>> + #clock-cells = <0>; >>> + clock-output-names = "sclk_otgphy0_480m"; >>> + >>> + u2phy_otg: otg-port { >>> + #phy-cells = <0>; >>> + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>, >>> + <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>, >>> + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; >>> + interrupt-names = "otg_id", "otg_bvalid", "linestate"; > again "-" not "_". > > >>> + status = "okay"; >>> + }; >>> + >>> + u2phy_host: host-port { >>> + #phy-cells = <0>; >>> + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; >>> + interrupt-names = "linestate"; >>> + status = "okay"; >>> + }; >>> + }; >>> +}; > BR. Frank
diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt new file mode 100644 index 0000000..48bb5de --- /dev/null +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt @@ -0,0 +1,64 @@ +ROCKCHIP USB2.0 PHY WITH INNO IP BLOCK + +Required properties (phy (parent) node): + - compatible : should be one of the listed compatibles: + * "rockchip,rk3366-usb2phy" + * "rockchip,rk3399-usb2phy" + - reg : the address offset of grf for usb-phy configuration. + - #clock-cells : should be 0. + - clock-output-names : specify the 480m output clock name. + +Optional properties: + - clocks : phandle + phy specifier pair, for the input clock of phy. + - clock-names : input clock name of phy, must be "phyclk". + +Required nodes : a sub-node is required for each port the phy provides. + The sub-node name is used to identify host or otg port, + and shall be the following entries: + * "otg-port" : the name of otg port. + * "host-port" : the name of host port. + +Required properties (port (child) node): + - #phy-cells : must be 0. See ./phy-bindings.txt for details. + - interrupts : specify an interrupt for each entry in interrupt-names. + - interrupt-names : a list which shall be the following entries: + * "otg_id" : for the otg id interrupt. + * "otg_bvalid" : for the otg vbus interrupt. + * "linestate" : for the host/otg linestate interrupt. + +Optional properties: + - phy-supply : phandle to a regulator that provides power to VBUS. + See ./phy-bindings.txt for details. + +Example: + +grf: syscon@ff770000 { + compatible = "rockchip,rk3366-grf", "syscon", "simple-mfd"; + #address-cells = <1>; + #size-cells = <1>; + +... + + u2phy: usb2-phy@700 { + compatible = "rockchip,rk3366-usb2phy"; + reg = <0x700 0x2c>; + #clock-cells = <0>; + clock-output-names = "sclk_otgphy0_480m"; + + u2phy_otg: otg-port { + #phy-cells = <0>; + interrupts = <GIC_SPI 93 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 94 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "otg_id", "otg_bvalid", "linestate"; + status = "okay"; + }; + + u2phy_host: host-port { + #phy-cells = <0>; + interrupts = <GIC_SPI 96 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "linestate"; + status = "okay"; + }; + }; +};
Signed-off-by: Frank Wang <frank.wang@rock-chips.com> --- Changes in v5: - Added 'reg' property to identify the different phy-blocks. Changes in v4: - Used 'phy-supply' instead of 'vbus_*-supply'. Changes in v3: - Added 'clocks' and 'clock-names' optional properties. - Specified 'otg-port' and 'host-port' as the sub-node name. Changes in v2: - Changed vbus_host optional property from gpio to regulator. - Specified vbus_otg-supply optional property. - Specified otg_id and otg_bvalid property. .../bindings/phy/phy-rockchip-inno-usb2.txt | 64 ++++++++++++++++++++ 1 file changed, 64 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt