| Message ID | 1474589350-10877-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Heiko, Friendly ping.. 在 2016/9/23 8:09, Shawn Lin 写道: > Please don't add these for vcc_sd, and mmc-core/driver will control > it. Otherwise, it will waste energy even without sdmmc in slot. > > Moreover, it will causes a bug: > If we insert/remove sd card, we could see > [9.337271] mmc0: new ultra high speed SDR25 SDHC card at address 0007 > [9.345144] mmcblk0: mmc0:0007 SD32G 29.3 GiB > > This is okay for normal sd insert/remove test, but when I debug some > issues for sdmmc, I did unbind/bind test. And there is a interesting > phenomenon when we bind the driver again: > [58.314069] mmc0: new high speed SDHC card at address 0007 > [58.320282] mmcblk0: mmc0:0007 SD32G 29.3 GiB > > So the sd card could just support high speed without power cycle > since the vcc_sd is always on, which makes the sd card fail to > reinit its internal ocr mask. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > arch/arm/boot/dts/rk3188-px3-evb.dts | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3188-px3-evb.dts b/arch/arm/boot/dts/rk3188-px3-evb.dts > index c1e41b8..62cbdd5 100644 > --- a/arch/arm/boot/dts/rk3188-px3-evb.dts > +++ b/arch/arm/boot/dts/rk3188-px3-evb.dts > @@ -219,8 +219,6 @@ > }; > > vcc_sd: LDO_REG7 { > - regulator-always-on; > - regulator-boot-on; > regulator-min-microvolt = <1800000>; > regulator-max-microvolt = <3300000>; > regulator-name = "vcc_sd"; >
Am Freitag, 23. September 2016, 08:09:10 CEST schrieb Shawn Lin: > Please don't add these for vcc_sd, and mmc-core/driver will control > it. Otherwise, it will waste energy even without sdmmc in slot. > > Moreover, it will causes a bug: > If we insert/remove sd card, we could see > [9.337271] mmc0: new ultra high speed SDR25 SDHC card at address 0007 > [9.345144] mmcblk0: mmc0:0007 SD32G 29.3 GiB > > This is okay for normal sd insert/remove test, but when I debug some > issues for sdmmc, I did unbind/bind test. And there is a interesting > phenomenon when we bind the driver again: > [58.314069] mmc0: new high speed SDHC card at address 0007 > [58.320282] mmcblk0: mmc0:0007 SD32G 29.3 GiB > > So the sd card could just support high speed without power cycle > since the vcc_sd is always on, which makes the sd card fail to > reinit its internal ocr mask. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> applied for 4.10 Thanks Heiko
diff --git a/arch/arm/boot/dts/rk3188-px3-evb.dts b/arch/arm/boot/dts/rk3188-px3-evb.dts index c1e41b8..62cbdd5 100644 --- a/arch/arm/boot/dts/rk3188-px3-evb.dts +++ b/arch/arm/boot/dts/rk3188-px3-evb.dts @@ -219,8 +219,6 @@ }; vcc_sd: LDO_REG7 { - regulator-always-on; - regulator-boot-on; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <3300000>; regulator-name = "vcc_sd";
Please don't add these for vcc_sd, and mmc-core/driver will control it. Otherwise, it will waste energy even without sdmmc in slot. Moreover, it will causes a bug: If we insert/remove sd card, we could see [9.337271] mmc0: new ultra high speed SDR25 SDHC card at address 0007 [9.345144] mmcblk0: mmc0:0007 SD32G 29.3 GiB This is okay for normal sd insert/remove test, but when I debug some issues for sdmmc, I did unbind/bind test. And there is a interesting phenomenon when we bind the driver again: [58.314069] mmc0: new high speed SDHC card at address 0007 [58.320282] mmcblk0: mmc0:0007 SD32G 29.3 GiB So the sd card could just support high speed without power cycle since the vcc_sd is always on, which makes the sd card fail to reinit its internal ocr mask. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- arch/arm/boot/dts/rk3188-px3-evb.dts | 2 -- 1 file changed, 2 deletions(-)