| Message ID | 1476151655-18415-2-git-send-email-shawn.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Dienstag, 11. Oktober 2016, 10:07:35 CEST schrieb Shawn Lin: > "rockchip,hw-tshut-temp", "rockchip,hw-tshut-mode" and > "rockchip,hw-tshut-polarity" are not a required properties > actually as the code could also work by loading the default > settings there. So it is apprently misleading, although we > prefer to get these from DT. And it seems we miss the 'rockchip,grf' > here which should also be an optional property. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de>
On Tue, Oct 11, 2016 at 10:07:35AM +0800, Shawn Lin wrote: > "rockchip,hw-tshut-temp", "rockchip,hw-tshut-mode" and > "rockchip,hw-tshut-polarity" are not a required properties > actually as the code could also work by loading the default > settings there. So it is apprently misleading, although we > prefer to get these from DT. And it seems we miss the 'rockchip,grf' > here which should also be an optional property. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > Changes in v2: None > > Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 3 +++ > 1 file changed, 3 insertions(+) Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt index 08efe6b..43003ae 100644 --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.txt @@ -22,10 +22,13 @@ Required properties: TSADC controller. - pinctrl-2 : The "sleep" pinctrl state, it will be in for suspend. - #thermal-sensor-cells : Should be 1. See ./thermal.txt for a description. + +Optional properties: - rockchip,hw-tshut-temp : The hardware-controlled shutdown temperature value. - rockchip,hw-tshut-mode : The hardware-controlled shutdown mode 0:CRU 1:GPIO. - rockchip,hw-tshut-polarity : The hardware-controlled active polarity 0:LOW 1:HIGH. +- rockchip,grf : The phandle of the syscon node for the general register file. Exiample: tsadc: tsadc@ff280000 {
"rockchip,hw-tshut-temp", "rockchip,hw-tshut-mode" and "rockchip,hw-tshut-polarity" are not a required properties actually as the code could also work by loading the default settings there. So it is apprently misleading, although we prefer to get these from DT. And it seems we miss the 'rockchip,grf' here which should also be an optional property. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- Changes in v2: None Documentation/devicetree/bindings/thermal/rockchip-thermal.txt | 3 +++ 1 file changed, 3 insertions(+)