| Message ID | 1586360280-10956-8-git-send-email-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for PCIe controller to work in endpoint mode on R-Car/RZ/G2x SoCs | expand |
On Wed, Apr 08, 2020 at 04:37:59PM +0100, Lad Prabhakar wrote: > Add R8A774C0 device ID so that this can be used by > pci_endpoint_test driver. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > include/linux/pci_ids.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 1dfc4e1dcb94..9e957c18abeb 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2460,6 +2460,7 @@ > #define PCI_DEVICE_ID_RENESAS_SH7763 0x0004 > #define PCI_DEVICE_ID_RENESAS_SH7785 0x0007 > #define PCI_DEVICE_ID_RENESAS_SH7786 0x0010 > +#define PCI_DEVICE_ID_RENESAS_R8A774C0 0x002d We don't add device IDs here anymore unless they're used in more than one place (see the comment at the top of the file). This series doesn't use it at all, so please move this patch to the series that adds multiple uses of this ID. > #define PCI_VENDOR_ID_SOLARFLARE 0x1924 > #define PCI_DEVICE_ID_SOLARFLARE_SFC4000A_0 0x0703 > -- > 2.20.1 >
Hello! On 08.04.2020 18:37, Lad Prabhakar wrote: > Add R8A774C0 device ID so that this can be used by > pci_endpoint_test driver. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > --- > include/linux/pci_ids.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index 1dfc4e1dcb94..9e957c18abeb 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -2460,6 +2460,7 @@ > #define PCI_DEVICE_ID_RENESAS_SH7763 0x0004 > #define PCI_DEVICE_ID_RENESAS_SH7785 0x0007 > #define PCI_DEVICE_ID_RENESAS_SH7786 0x0010 > +#define PCI_DEVICE_ID_RENESAS_R8A774C0 0x002d We don't add the device IDs in this file, unless used in several places. Is it? [...] MBR, Sergei
Hi Sergei and Bjorn, On Thu, Apr 9, 2020 at 10:36 AM Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > > Hello! > > On 08.04.2020 18:37, Lad Prabhakar wrote: > > > Add R8A774C0 device ID so that this can be used by > > pci_endpoint_test driver. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > --- > > include/linux/pci_ids.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > index 1dfc4e1dcb94..9e957c18abeb 100644 > > --- a/include/linux/pci_ids.h > > +++ b/include/linux/pci_ids.h > > @@ -2460,6 +2460,7 @@ > > #define PCI_DEVICE_ID_RENESAS_SH7763 0x0004 > > #define PCI_DEVICE_ID_RENESAS_SH7785 0x0007 > > #define PCI_DEVICE_ID_RENESAS_SH7786 0x0010 > > +#define PCI_DEVICE_ID_RENESAS_R8A774C0 0x002d > > We don't add the device IDs in this file, unless used in several places. > Is it? > My bad I should have checked it before making this change actually it was suggested in my previous version of the series but anyway atm this was planned to be used only in pci_endpoint_test driver, so in that case Ill drop this patch. Cheers, --Prabhakar > [...] > > MBR, Sergei
Hi Prabhakar, Sergei, Bjorn, > From: Lad, Prabhakar, Sent: Thursday, April 9, 2020 7:05 PM <snip> > > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > > > index 1dfc4e1dcb94..9e957c18abeb 100644 > > > --- a/include/linux/pci_ids.h > > > +++ b/include/linux/pci_ids.h > > > @@ -2460,6 +2460,7 @@ > > > #define PCI_DEVICE_ID_RENESAS_SH7763 0x0004 > > > #define PCI_DEVICE_ID_RENESAS_SH7785 0x0007 > > > #define PCI_DEVICE_ID_RENESAS_SH7786 0x0010 > > > +#define PCI_DEVICE_ID_RENESAS_R8A774C0 0x002d > > > > We don't add the device IDs in this file, unless used in several places. > > Is it? > > > My bad I should have checked it before making this change actually it > was suggested in my previous version of the series but anyway atm this > was planned to be used only in pci_endpoint_test driver, so in that > case Ill drop this patch. I'm very sorry, this is my fault. I suggested this but I didn't check this pci_ids.h's rule... Best regards, Yoshihiro Shimoda
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h index 1dfc4e1dcb94..9e957c18abeb 100644 --- a/include/linux/pci_ids.h +++ b/include/linux/pci_ids.h @@ -2460,6 +2460,7 @@ #define PCI_DEVICE_ID_RENESAS_SH7763 0x0004 #define PCI_DEVICE_ID_RENESAS_SH7785 0x0007 #define PCI_DEVICE_ID_RENESAS_SH7786 0x0010 +#define PCI_DEVICE_ID_RENESAS_R8A774C0 0x002d #define PCI_VENDOR_ID_SOLARFLARE 0x1924 #define PCI_DEVICE_ID_SOLARFLARE_SFC4000A_0 0x0703