| Message ID | 20160908064905.18080-2-xzy.xu@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 08, 2016 at 02:49:04PM +0800, Ziyuan Xu wrote: > Add power domain as a optional property for sdhci-of-arasan, which can > be truned off in the so-called unused condition, such as suspend and s/truned/turned/ > remove. Aim to lower power requirements. > > Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> > > --- > > Changes in v2: > - fix a typo > - add an example code for power-domain > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) With that, Acked-by: Rob Herring <robh@kernel.org>
Hi Rob, On 2016年09月16日 23:25, Rob Herring wrote: > On Thu, Sep 08, 2016 at 02:49:04PM +0800, Ziyuan Xu wrote: >> Add power domain as a optional property for sdhci-of-arasan, which can >> be truned off in the so-called unused condition, such as suspend and > s/truned/turned/ > >> remove. Aim to lower power requirements. >> >> Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> >> >> --- >> >> Changes in v2: >> - fix a typo >> - add an example code for power-domain >> >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) > With that, > > Acked-by: Rob Herring <robh@kernel.org> Thanks, Rob. I fill fix it and send a follow up patch with your tag. > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip > > >
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index 3404afa..eb84d29 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -1,12 +1,14 @@ Device Tree Bindings for the Arasan SDHCI Controller - The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings. + The bindings follow the mmc[1], clock[2], interrupt[3], phy[4] and power + domain[5] bindings. Only deviations are documented here. [1] Documentation/devicetree/bindings/mmc/mmc.txt [2] Documentation/devicetree/bindings/clock/clock-bindings.txt [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt [4] Documentation/devicetree/bindings/phy/phy-bindings.txt + [5] Documentation/devicetree/bindings/power/power_domain.txt Required Properties: - compatible: Compatibility string. One of: @@ -36,6 +38,8 @@ Optional Properties: - #clock-cells: If specified this should be the value <0>. With this property in place we will export a clock representing the Card Clock. This clock is expected to be consumed by our PHY. You must also specify + - power-domains: A phandle and PM domain as specifier defined by bindings + of the power controller specified by phandle. Example: sdhci@e0100000 { @@ -71,5 +75,6 @@ Example: phys = <&emmc_phy>; phy-names = "phy_arasan"; #clock-cells = <0>; + power-domains = <&power RK3399_PD_EMMC>; status = "disabled"; };
Add power domain as a optional property for sdhci-of-arasan, which can be truned off in the so-called unused condition, such as suspend and remove. Aim to lower power requirements. Signed-off-by: Ziyuan Xu <xzy.xu@rock-chips.com> --- Changes in v2: - fix a typo - add an example code for power-domain Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)