From patchwork Thu Jun 29 21:33:35 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 9818033 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DDC2A6020A for ; Thu, 29 Jun 2017 21:45:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF42A1FF12 for ; Thu, 29 Jun 2017 21:45:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C3577283BD; Thu, 29 Jun 2017 21:45:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4EF701FF12 for ; Thu, 29 Jun 2017 21:45:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:Subject:To:From :Date:Message-Id:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: List-Owner; bh=NX2CFH96SH/2JIT/QJnCPhBS0ZlVn+lrKVNkPsF1UZA=; b=Jn9VfJNjzKDiJk TvbLddYegMI7SKJ6OVUz4WCMiCB7WA8UCad9NW5wE+MBmSBy2dI6iqNbIJQc215IGEdF0oTIBoa/U 9GLJ+FvcrdGijdoA/ys0vANEvxh4Gqng4qDpS4Ft8uqZ1aKpwyD6WLCalTE2TatoCLiqRThSx011t 1HzkzeQRKEepM3RctbZDjxu+TsqfjBFT3jf/O1URDyBo0037wt4k0kjtIm+wq0TUsmRHm+rd0pERC kKho9jbbpA8v94u0CyWJa36K+36LdpnWH2wMrAKGZMU0HiIGuGb86oWOt2P19dToxgC6cErwUohmG s9OzJ3JWbqVZT7qj6IoA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dQhFx-0006Qd-VH; Thu, 29 Jun 2017 21:45:45 +0000 Received: from galois.linutronix.de ([2a01:7a0:2:106d:700::1]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dQhFt-0006FZ-JX; Thu, 29 Jun 2017 21:45:43 +0000 Received: from localhost ([127.0.0.1] helo=[127.0.1.1]) by Galois.linutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1dQhEH-0001Ka-K8; Thu, 29 Jun 2017 23:44:01 +0200 Message-Id: <20170629214343.882576048@linutronix.de> User-Agent: quilt/0.63-1 Date: Thu, 29 Jun 2017 23:33:35 +0200 From: Thomas Gleixner To: LKML Subject: [patch 1/5] pinctrl: samsung: Remove bogus irq_[un]mask from resource management References: <20170629213334.375848050@linutronix.de> MIME-Version: 1.0 Content-Disposition: inline; filename=pinctrl--samsung--Remove-bogus-irqmask-unmask.patch X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170629_144541_948974_12A7DEDC X-CRM114-Status: GOOD ( 10.11 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Heiko Stuebner , Julia Cartwright , Marc Zyngier , Linus Walleij , Brian Norris , Doug Anderson , Krzysztof Kozlowski , Tomasz Figa , linux-rockchip@lists.infradead.org, Kukjin Kim , John Keeping , linux-gpio@vger.kernel.org, Sylwester Nawrocki , linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The irq chip callbacks irq_request/release_resources() have absolutely no business with masking and unmasking the irq. The core code unmasks the interrupt after complete setup and masks it before invoking irq_release_resources(). The unmask is actually harmful as it happens before the interrupt is completely initialized in __setup_irq(). Remove it. Fixes: f6a8249f9e55 ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs") Signed-off-by: Thomas Gleixner Cc: Tomasz Figa Cc: Krzysztof Kozlowski Cc: Sylwester Nawrocki Cc: Linus Walleij Cc: Kukjin Kim Cc: linux-arm-kernel@lists.infradead.org Cc: linux-samsung-soc@vger.kernel.org Cc: linux-gpio@vger.kernel.org Acked-by: Tomasz Figa Reviewed-by: Linus Walleij --- drivers/pinctrl/samsung/pinctrl-exynos.c | 4 ---- 1 file changed, 4 deletions(-) --- a/drivers/pinctrl/samsung/pinctrl-exynos.c +++ b/drivers/pinctrl/samsung/pinctrl-exynos.c @@ -205,8 +205,6 @@ static int exynos_irq_request_resources( spin_unlock_irqrestore(&bank->slock, flags); - exynos_irq_unmask(irqd); - return 0; } @@ -226,8 +224,6 @@ static void exynos_irq_release_resources shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC]; mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1; - exynos_irq_mask(irqd); - spin_lock_irqsave(&bank->slock, flags); con = readl(bank->eint_base + reg_con);