From patchwork Mon Jul 17 21:28:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Enric Balletbo i Serra X-Patchwork-Id: 9846353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C5AD160386 for ; Mon, 17 Jul 2017 21:37:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 03BAB26E96 for ; Mon, 17 Jul 2017 21:37:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EC5F927F81; Mon, 17 Jul 2017 21:37:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9DCB023B24 for ; Mon, 17 Jul 2017 21:37:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=hzzNDPlgSjmePT0BkZftspziemINXieuIREG/Cy2HSU=; b=pyo6jz+IQbP1g7QlR3NmpytCkS qQnDArm+iXAOd0Ro2Gbp1noH8/GYeui+CcEjqend9imoXJh+Y3i7+DGmzUXZlA2taV8llQFQATVZW KK7gTg2uJTGVxaAoF8mMZ4hwdN9wNbUOP+R9qLZyeN1B0p3+2ZzoTrQ/xH9ZExu7D4QlnYQMSrHcH M09LuPOuneiBgaMcPB11P2Mwk0kzLxds4oRgeICdg4pBQZ/cgvqECiUNJlwBbORsaIjyjtz4eR771 nrkTmrYjVbU14jJWPnNSk200AeydWGqfBv0/Pt/0FW/vThIP528c9YHOan6eSacgS2Dhl6CNQp8wO EVLAUiSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dXDht-0006SN-Ks; Mon, 17 Jul 2017 21:37:33 +0000 Received: from casper.infradead.org ([85.118.1.10]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dXDhr-0006NG-R0 for linux-rockchip@bombadil.infradead.org; Mon, 17 Jul 2017 21:37:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sPyQHsHnziMr85mrcy1ueJlsXc0i6kD6/1C0Z2K21Zc=; b=edXI0SKSSulgOPj2dCsYRMEtm RbqvsXLgJ5EeMPMlu3xPFMuK+GZ3u2Pdr4L+VPpcD/Vzlerpyd6UHJPlD5LKExXwurdVykecn50y8 6huzdqt3b1cHoh+nUgeDQ07MF6/s54f1QJ8rTZwNYiLyfvSCLvfzzThJ8Ozkjj+H4opP315H2F3TR 2KXtm5eKYuHARbqufBhGkVxuZYADQdBgxkgTiCLfbZ7QHWwJYyjpewgsELI74dHqHJ9w+seDvk6sE UfUXK0FQ4dWb42Mws0QTtx7xH+r3ZSnyvMGtB9bl6bdmhnJRHa+cviWOJN0RQ1+Y5uJFBYfUgGlRe ookxg5pSQ==; Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by casper.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dXDZd-0002II-5w for linux-rockchip@lists.infradead.org; Mon, 17 Jul 2017 21:29:05 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: eballetbo) with ESMTPSA id 1232B26BBCA From: Enric Balletbo i Serra To: Thierry Reding , Lee Jones , Daniel Thompson , Jingoo Han , Bartlomiej Zolnierkiewicz , Rob Herring , Pavel Machek , Richard Purdie , Jacek Anaszewski , Heiko Stuebner Subject: [PATCH v3 3/5] pwm-backlight: add support for PWM delays proprieties. Date: Mon, 17 Jul 2017 23:28:09 +0200 Message-Id: <20170717212811.25374-3-enric.balletbo@collabora.com> X-Mailer: git-send-email 2.9.3 In-Reply-To: <20170717212811.25374-1-enric.balletbo@collabora.com> References: <20170717212811.25374-1-enric.balletbo@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170717_222901_286222_761436AB X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: groeck@chromium.org, linux-pwm@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Some panels (i.e. N116BGE-L41), in their power sequence specifications, request a delay between set the PWM signal and enable the backlight and between clear the PWM signal and disable the backlight. Add support for the new post-pwm-on-delay-us and pwm-off-delay-us proprieties to meet the timings. Signed-off-by: Enric Balletbo i Serra --- Changes since v2: - Move the pwm/enable sequence to another patch (Thierry Reding) Changes since v1: - As suggested by Daniel Thompson - Do not assume power-on delay and power-off delay will be the same - Move the check of dt property to the parse dt function. drivers/video/backlight/pwm_bl.c | 17 +++++++++++++++++ include/linux/pwm_backlight.h | 1 + 2 files changed, 18 insertions(+) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 909a686..528155d 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -10,6 +10,7 @@ * published by the Free Software Foundation. */ +#include #include #include #include @@ -35,6 +36,7 @@ struct pwm_bl_data { struct gpio_desc *enable_gpio; unsigned int scale; bool legacy; + unsigned int pwm_delay[2]; int (*notify)(struct device *, int brightness); void (*notify_after)(struct device *, @@ -56,6 +58,9 @@ static void pwm_backlight_power_on(struct pwm_bl_data *pb, int brightness) pwm_enable(pb->pwm); + if (pb->pwm_delay[0]) + usleep_range(pb->pwm_delay[0], pb->pwm_delay[0] * 2); + if (pb->enable_gpio) gpiod_set_value_cansleep(pb->enable_gpio, 1); @@ -70,6 +75,9 @@ static void pwm_backlight_power_off(struct pwm_bl_data *pb) if (pb->enable_gpio) gpiod_set_value_cansleep(pb->enable_gpio, 0); + if (pb->pwm_delay[1]) + usleep_range(pb->pwm_delay[1], pb->pwm_delay[1] * 2); + pwm_config(pb->pwm, 0, pb->period); pwm_disable(pb->pwm); @@ -175,6 +183,14 @@ static int pwm_backlight_parse_dt(struct device *dev, data->max_brightness--; } + /* + * These values are optional and set as 0 by default, the out values + * are modified only if a valid u32 value can be decoded. + */ + of_property_read_u32(node, "post-pwm-on-delay-us", + &data->pwm_delay[0]); + of_property_read_u32(node, "pwm-off-delay-us", &data->pwm_delay[1]); + data->enable_gpio = -EINVAL; return 0; } @@ -273,6 +289,7 @@ static int pwm_backlight_probe(struct platform_device *pdev) pb->exit = data->exit; pb->dev = &pdev->dev; pb->enabled = false; + memcpy(pb->pwm_delay, data->pwm_delay, sizeof(pb->pwm_delay)); pb->enable_gpio = devm_gpiod_get_optional(&pdev->dev, "enable", GPIOD_ASIS); diff --git a/include/linux/pwm_backlight.h b/include/linux/pwm_backlight.h index efdd922..bf37131 100644 --- a/include/linux/pwm_backlight.h +++ b/include/linux/pwm_backlight.h @@ -13,6 +13,7 @@ struct platform_pwm_backlight_data { unsigned int lth_brightness; unsigned int pwm_period_ns; unsigned int *levels; + unsigned int pwm_delay[2]; /* TODO remove once all users are switched to gpiod_* API */ int enable_gpio; int (*init)(struct device *dev);