From patchwork Wed Mar 13 19:02:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Geis X-Patchwork-Id: 10851677 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 885D26C2 for ; Wed, 13 Mar 2019 19:03:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 706A02A19B for ; Wed, 13 Mar 2019 19:03:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E5F22A21E; Wed, 13 Mar 2019 19:03:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1BF022A219 for ; Wed, 13 Mar 2019 19:03:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VHMNkm81N2zL0CQTGgaZHoqaxNsUwePXrFErpu4VdOs=; b=SJGbCg0Fp6fiCC lOpV9SM+aBNyUpfFj6qXhDSJEu1dG/gLzXUyTiZgvzFSGigDNW6J9htvDkRS3mogQUi/L3FF9vqc9 JxAPZ4VMDhyI2nmG3Bhy9DDMrB0VsIS9G5IFRubh1AM7EpTRgOoscBS2ks8fhONTZEkYZsvRtgFxS sp52YUfNtHSaTZzncQPSbg3yrgQLnikgQRZexKVFkXVrOj3ilRIaB+d+tEw0Uf9jKYRXMjGxqAM3d +PL+EvtOm0NYsNxwPV2ebfgp3FaqPIXtAMfLRVan4wsP8K8lbFwU5ouAX55xHaLDkpZ62jb0ez2Wk EiA+48uS3aeo5KV1Bcog==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h499n-0001gP-8f; Wed, 13 Mar 2019 19:03:15 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h499k-0001g0-JU; Wed, 13 Mar 2019 19:03:14 +0000 Received: by mail-qt1-x841.google.com with SMTP id s1so3228472qte.5; Wed, 13 Mar 2019 12:03:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YDSKgbFkQXUAMX6bLt0ATwgHkS0+3k179lDDOws86SE=; b=E5K6vmvb/UIlU02SgS1XxEsIrtPcJxBLNJQKd2229MLLeaDF17x2ytBDaKzmNjp0cn +msdXyTFwFV4uqACtPW7/ztyaAQ7yWORmweNNjPSnCFX8pQJK1TO5rkGLS/MLjYfWEgw Cf0SwIDYK7LXBiYzH5OD5syW7QI7A25R4W8te+aqCAj3NUv/1qq+R5x9V5o/INYDofm3 H4e3Jolg0sRVcjiPN4z6u3t4ZMpXkhsAXm7vckoxmBs/7LOdNvi/PQtUERzacHi2rxfn 0qeLJLXQTQC6CWcMkRR+ElIAgcMaxRsuee68sU+IlJfEF+7z1lkNU8YNh86FBgzlEF1/ dDXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YDSKgbFkQXUAMX6bLt0ATwgHkS0+3k179lDDOws86SE=; b=WPpU7Wzk4ILgJH1b24wkiyEgCnj0nD7AAUaqoVcoSwYZaSWyg9FB5DcL0r+mZGUbQQ iqwNCo4ZlDdnbLAuj9ekh8n61I6Xq3uBi8bCmUfiFitO0+uaRFDA8U1A/YEMTP3cv6Iz GigvyuM/y4GsfIuJRjc2pt1ej2J36/9sC2i3Aebko1yFeatnymKsObtEVWgdl2Y0u3cf rn8UTYuEQgBYtJuEHEbrm0XZzjuVRrShZjsc+3X5XL3xpnAykdAt0JUnz4ke7TtMclte PLXR2+T3LIGKQjAXgtwwkVsTLvvjXyM9LzRpT0f2tMcxC2TfKM6AugJVk9gcgW+MMGSa /FpQ== X-Gm-Message-State: APjAAAUdZTZ2xKKrKVCmXvFSZAWcvUE4oESFVdrAs9DBkbnLmAdFljbZ wbkpgAAYJY8mhjrSy686J0hqsiHGypQ= X-Google-Smtp-Source: APXvYqygLeWRPerWE2tUv9RX7KfgRLP0EjCI26aol+Qt7pgtFfWZM8ys2iBessm2a5BsYYvEtwLqzA== X-Received: by 2002:a0c:9802:: with SMTP id c2mr35587436qvd.13.1552503791180; Wed, 13 Mar 2019 12:03:11 -0700 (PDT) Received: from localhost.localdomain ([2601:153:900:ebb:54ef:2a33:568d:c6a1]) by smtp.gmail.com with ESMTPSA id p130sm2263078qka.96.2019.03.13.12.03.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Mar 2019 12:03:10 -0700 (PDT) From: Peter Geis To: Heiko Stuebner Subject: [PATCH] arm64: dts: rockchip: fix rk3328 sdmmc0 write errors Date: Wed, 13 Mar 2019 19:02:30 +0000 Message-Id: <20190313190229.16962-1-pgwipeout@gmail.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190313_120312_644290_4C095A60 X-CRM114-Status: GOOD ( 11.16 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, Peter Geis , Robin Murphy , linux-arm-kernel@lists.infradead.org, "Leonidas P . Papadakos" Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Various rk3328 based boards experience occasional sdmmc0 write errors. This is due to the rk3328.dtsi tx drive levels being set to 4ma, vs 8ma per the rk3328 datasheet default settings. Fix this by setting the tx signal pins to 8ma. Inspiration from tonymac32's patch, https://github.com/ayufan-rock64/linux-kernel/commit/dc1212b347e0da17c5460bcc0a56b07d02bac3f8 Fixes issues on the rk3328-roc-cc and the rk3328-rock64 (as per the above commit message). Tested on the rk3328-roc-cc board. Signed-off-by: Peter Geis --- arch/arm64/boot/dts/rockchip/rk3328.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi b/arch/arm64/boot/dts/rockchip/rk3328.dtsi index c55a3f1a87ff..dabef1a21649 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3328.dtsi @@ -1445,11 +1445,11 @@ sdmmc0 { sdmmc0_clk: sdmmc0-clk { - rockchip,pins = <1 RK_PA6 1 &pcfg_pull_none_4ma>; + rockchip,pins = <1 RK_PA6 1 &pcfg_pull_none_8ma>; }; sdmmc0_cmd: sdmmc0-cmd { - rockchip,pins = <1 RK_PA4 1 &pcfg_pull_up_4ma>; + rockchip,pins = <1 RK_PA4 1 &pcfg_pull_up_8ma>; }; sdmmc0_dectn: sdmmc0-dectn { @@ -1461,14 +1461,14 @@ }; sdmmc0_bus1: sdmmc0-bus1 { - rockchip,pins = <1 RK_PA0 1 &pcfg_pull_up_4ma>; + rockchip,pins = <1 RK_PA0 1 &pcfg_pull_up_8ma>; }; sdmmc0_bus4: sdmmc0-bus4 { - rockchip,pins = <1 RK_PA0 1 &pcfg_pull_up_4ma>, - <1 RK_PA1 1 &pcfg_pull_up_4ma>, - <1 RK_PA2 1 &pcfg_pull_up_4ma>, - <1 RK_PA3 1 &pcfg_pull_up_4ma>; + rockchip,pins = <1 RK_PA0 1 &pcfg_pull_up_8ma>, + <1 RK_PA1 1 &pcfg_pull_up_8ma>, + <1 RK_PA2 1 &pcfg_pull_up_8ma>, + <1 RK_PA3 1 &pcfg_pull_up_8ma>; }; sdmmc0_gpio: sdmmc0-gpio {