From patchwork Thu Apr 11 23:21:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10897075 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 76B6A922 for ; Thu, 11 Apr 2019 23:23:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5C0B628B02 for ; Thu, 11 Apr 2019 23:23:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5052F28E1E; Thu, 11 Apr 2019 23:23:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id DFF3628B02 for ; Thu, 11 Apr 2019 23:23:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cBAjOOp/tbZ3Amadmxy3lPW4dZVv3cO7rw7cOiGi4Vg=; b=OtlqvxMr6sXs8l JHbFM48nltOBjsFQ4Laxm7N2wAIqc4JwgWKfm8YOM9VRlJ/3k9eizVZTexDjM7jra4p+EJKXPzCQa bdFglvzRX0EquUEHpXsn/IUwxmZjXrmXkTDHkobKnx0rUgSuL6VUGAQvlPovNSNoexCGu6nNksN1m GSXByPurYFc19s+SLO+IX+XedajivfkZkIPbTueTVDKS9BbvmrE14th+DV00uiqzdc3ZXFReRibWx zZhKdSwuRkjl20isFFwA5WufDfmQyON4zDKUZU22lDwphptkwz+WiSXsu4F7oXFvfB7WDers8wvtE dOx4SOcdiI5XnCBhvKqg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj2g-0007IF-7y; Thu, 11 Apr 2019 23:23:38 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj1x-0006FZ-K6 for linux-rockchip@lists.infradead.org; Thu, 11 Apr 2019 23:22:55 +0000 Received: by mail-pl1-x644.google.com with SMTP id t16so4148168plo.0 for ; Thu, 11 Apr 2019 16:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dL9JtcZ92ryYmPw47PdDoJyrwRFQyhVA65jTVCpTryA=; b=Sr77n9xkvP4TmRJRlFx+/1VN6Dgqc6UfpixQ1GSApsVFnAs2CAIlHTRNhdSholz9gh E0W/+rxbcVE4Sk0kKEJSjJpEwqo5SmT4ONkdLlVl5L8LcEwOiD3OcJKhzY3/nbzjJaM3 2T1pIxq/6DDdtBkR22oAPqRH86BRG7IpZdKSs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dL9JtcZ92ryYmPw47PdDoJyrwRFQyhVA65jTVCpTryA=; b=dKffXqTBMLa90rRt76twAApoIUymASH57R6rAlfPNnMuRxQuV9nNCwc6JgnGO/jc+S vXZ/qMQms3verq2egCFCfp8gmnh1gTrOp+6KsDCVPzdn0qlC602N+GG1rhDZioAUu0cO ixUuHjh/OxJ2xRZdihTVH/UbCa9CVQ0pBuPutaOFbUBfCGSk4i2dJhAIRZkKV+8/cth9 H2V33E4VaDihgYpXe1xGrRRqyEQehdaJqj9s73k0Ku/Wi9wE5gfW6dffgOwbCFDsdNyF ZI+PZe8kna4SiRkGY82eIrn5SI5Hr38gmxzfgHRoKYlhz1iPlF1aUUMDxWMVmpZyfm6/ AXeQ== X-Gm-Message-State: APjAAAVE5Kt6OfglfDoGKuG+R2zp64HJmsVfsWjSDRUtMCLsoOQdmZlY uWZkNZIg/Hwgy7AfCzFNLMjp3g== X-Google-Smtp-Source: APXvYqxR3xzpG4aO7AHfUFf+3SjHVnPXZxk4DrkkC1n22Mku+W8I6WVCHkI9MtZMNBQwKnm8EptMEA== X-Received: by 2002:a17:902:e684:: with SMTP id cn4mr51769749plb.71.1555024973170; Thu, 11 Apr 2019 16:22:53 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y20sm37288903pfe.188.2019.04.11.16.22.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 16:22:52 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner , Elaine Zhang Subject: [PATCH 5/5] ARM: dts: rockchip: vdd_gpu off in suspend for rk3288-veyron Date: Thu, 11 Apr 2019 16:21:57 -0700 Message-Id: <20190411232157.55125-5-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190411232157.55125-1-dianders@chromium.org> References: <20190411232157.55125-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_162253_785543_34248149 X-CRM114-Status: GOOD ( 12.90 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, briannorris@chromium.org, amstan@chromium.org, dbasehore@chromium.org, Douglas Anderson , Rob Herring , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP At some point long long ago the downstream GPU driver would crash if we turned the GPU off during suspend. For some context you can see: https://chromium-review.googlesource.com/#/c/215780/5..6/arch/arm/boot/dts/rk3288-pinky-rev2.dts At some point in time not too long after that got fixed. It's unclear why the GPU is left enabled during suspend on the mainline kernel. Everything seems fine if I turn this off, so let's do it. Signed-off-by: Douglas Anderson Reviewed-by: Elaine Zhang --- arch/arm/boot/dts/rk3288-veyron.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi index 279d7f4ecce0..1252522392c7 100644 --- a/arch/arm/boot/dts/rk3288-veyron.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi @@ -217,8 +217,7 @@ regulator-max-microvolt = <1250000>; regulator-ramp-delay = <6001>; regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <1000000>; + regulator-off-in-suspend; }; };