From patchwork Tue Apr 16 10:56:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 10902715 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 97A9614DB for ; Tue, 16 Apr 2019 10:57:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7A5691FF62 for ; Tue, 16 Apr 2019 10:57:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6ED5D27165; Tue, 16 Apr 2019 10:57:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 220251FF62 for ; Tue, 16 Apr 2019 10:57:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X/LNpV6EI56pGAVCH07MAwvJDVKltIASQHZNspgjCtk=; b=D/QEiuSbu+fIk8 oQhOXJVygayoUTt6MS7MjeN2SGM9/7kbdl2KTKythu8yLGlCw+8vOT2CWUUlTF+FZ1PMnq7/sgx0I /kDTMg+3ROcpRvzBlnK7YYEk4O3QEKmUwiyNQrM7CCdskYjywnpHtdiVQKeD66AMLqzz/Tz45Hess 4poBM9QeEK8AyuxO6e5EU6V2MT4PZAsLQ7klUcFpIxDwF4JCMBITKg4Ndi/x7x302lzqJDqZ/jIZg 6eGp4ydi8u3+17v+vr+8xIvfcvw4NqICYHi+UMD/TY/lAsmgj17gtNoAQCqwDC7Tb5F4U/jjwSR7t BISALY9qANVHVqnN2xMw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLmK-0004j0-FC; Tue, 16 Apr 2019 10:57:28 +0000 Received: from mail-pf1-x441.google.com ([2607:f8b0:4864:20::441]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hGLmG-0004gX-NY for linux-rockchip@lists.infradead.org; Tue, 16 Apr 2019 10:57:25 +0000 Received: by mail-pf1-x441.google.com with SMTP id 8so10229073pfr.4 for ; Tue, 16 Apr 2019 03:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PiYZMOX80wZSHPhENBnJGRyCTrVO/g/JLSVYDiJ8I64=; b=MRv5DyuA0izyN0OlN7YyNXKd4su/hYykr/PmCqH+LGWHEC/bISDQs7rEzbGU/mXS4d Lwq7BDlYrKbl1fLG4cJMnLE2pru5462UldNudfz9zuXUxebPIyt3d1WuwMP6Bn+Fz/PT MYjO4IeTpOlfoHjGjyOlbfAi6wTRNHs4yv8R4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PiYZMOX80wZSHPhENBnJGRyCTrVO/g/JLSVYDiJ8I64=; b=BxlE+x748tyRJ31xlULP0PJGIfSPq8pZTqSlZCW+A/gQUarwaJNV0DrVNfZVylb3rO LH40jSnAtSBDlRs2V9JSkN3rGmqecr8ml7OnmS8+DVknuB18EHGRyRewDGRBhc0oL1Bw 4+KTCPtaT3KhluxsmLuCHoiJIHteLRqWojB+hjxUl4XHo1FLTQ0vu6QrEzfUpSUCnAQV 0UQUfFUcwoFjWzug4co4jaZMH37YNF1S7FV8A+6J72ia3t/Mo09lVxNF2N45HB9vWre6 bVJRCob3FB/tSeXrx5kz40hajKWk/rp7aFjJGSygnrWmInKT1SvevwwHNvFda80ucK7N 8GbA== X-Gm-Message-State: APjAAAWbDFOyZvXNCoJcGg2JNEmzR2usYwGYnPNzgKOg6j8R4R7/IlpD XhYq9k0wiEd5lyqTI3ZWzRwcvA== X-Google-Smtp-Source: APXvYqx2FtbxArb6EG2lwkJXsEI/NQD2bhBdxWY9gkFFhklPHByLHsJNnK5YKF5b7yBr+eB/UkbLQQ== X-Received: by 2002:a63:ff0f:: with SMTP id k15mr74964077pgi.407.1555412244312; Tue, 16 Apr 2019 03:57:24 -0700 (PDT) Received: from localhost.localdomain ([115.97.185.144]) by smtp.gmail.com with ESMTPSA id x24sm70368953pfn.128.2019.04.16.03.57.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Apr 2019 03:57:23 -0700 (PDT) From: Jagan Teki To: Simon Glass , Philipp Tomsich , Kever Yang , Akash Gajjar Subject: [PATCH v2 08/14] rockchip: dts: rk3399: nanopi4: Use CD pin as RK_FUNC_1 Date: Tue, 16 Apr 2019 16:26:41 +0530 Message-Id: <20190416105647.18437-9-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.18.0.321.gffc6fa0e3 In-Reply-To: <20190416105647.18437-1-jagan@amarulasolutions.com> References: <20190416105647.18437-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190416_035724_763051_9056E917 X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rockchip@lists.infradead.org, linux-amarula@amarulasolutions.com, Jagan Teki , u-boot@lists.denx.de Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP sdmmc cd pin is configured as RK_FUNC_GPIO which is wrong and indeed failed to detect the sdcard on the board with below error Card did not respond to voltage select! So, fix it by replacing RK_FUNC_GPIO with RK_FUNC_1 which is already defined in rk3399.dts so make use of same like other boards. Signed-off-by: Jagan Teki --- arch/arm/dts/rk3399-nanopi4.dtsi | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/arch/arm/dts/rk3399-nanopi4.dtsi b/arch/arm/dts/rk3399-nanopi4.dtsi index d325e11728..5dc8a8de16 100644 --- a/arch/arm/dts/rk3399-nanopi4.dtsi +++ b/arch/arm/dts/rk3399-nanopi4.dtsi @@ -521,10 +521,6 @@ }; sdmmc { - sdmmc0_det_l: sdmmc0-det-l { - rockchip,pins = <0 RK_PA7 RK_FUNC_GPIO &pcfg_pull_up>; - }; - sdmmc0_pwr_h: sdmmc0-pwr-h { rockchip,pins = <0 RK_PA1 RK_FUNC_GPIO &pcfg_pull_none>; }; @@ -582,7 +578,7 @@ cd-gpios = <&gpio0 RK_PA7 GPIO_ACTIVE_LOW>; disable-wp; pinctrl-names = "default"; - pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc0_det_l>; + pinctrl-0 = <&sdmmc_bus4 &sdmmc_clk &sdmmc_cmd &sdmmc_cd>; sd-uhs-sdr104; vmmc-supply = <&vcc3v0_sd>; vqmmc-supply = <&vcc_sdio>;