| Message ID | 20190516172510.181473-3-mka@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] dt-bindings: gpu: add #cooling-cells property to the ARM Mali Midgard GPU binding | expand |
Hi, On Thu, May 16, 2019 at 10:25 AM Matthias Kaehlcke <mka@chromium.org> wrote: > Currently the CPUs are used as cooling devices of the rk3288 GPU > thermal zone. The CPUs are also configured as cooling devices in the > CPU thermal zone, which indirectly helps with cooling the GPU thermal > zone, since the CPU and GPU temperatures are correlated on the rk3288. > > Configure the ARM Mali Midgard GPU as cooling device for the GPU > thermal zone instead of the CPUs. > > Signed-off-by: Matthias Kaehlcke <mka@chromium.org> > --- > Changes in v2: > - patch added to the series > --- > arch/arm/boot/dts/rk3288.dtsi | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) This makes sense to me unless there is some better way to model the intertwined nature of the CPU and GPU temperature. It's my understanding that the original device tree snippet was there because it was added before the gpu node existed in the device tree so the best we could do is to suggest that the cpu could cool things down. Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 14d9609f0b15..988555c5118d 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -547,10 +547,7 @@ map0 { trip = <&gpu_alert0>; cooling-device = - <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, - <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, - <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, - <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; }; }; };
Currently the CPUs are used as cooling devices of the rk3288 GPU thermal zone. The CPUs are also configured as cooling devices in the CPU thermal zone, which indirectly helps with cooling the GPU thermal zone, since the CPU and GPU temperatures are correlated on the rk3288. Configure the ARM Mali Midgard GPU as cooling device for the GPU thermal zone instead of the CPUs. Signed-off-by: Matthias Kaehlcke <mka@chromium.org> --- Changes in v2: - patch added to the series --- arch/arm/boot/dts/rk3288.dtsi | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)