| Message ID | 20191219113432.1229852-2-john@metanate.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] usb: dwc2: Fix IN FIFO allocation | expand |
On 12/19/2019 3:34 PM, John Keeping wrote: > The number of FIFOs may be lower than the number of endpoints. Use the > correct total when printing FIFO details in debugfs. > > Signed-off-by: John Keeping <john@metanate.com> > --- Acked-by: Minas Harutyunyan <hminas@synopsys.com> > drivers/usb/dwc2/debugfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c > index b8f2790abf91..3a0dcbfbc827 100644 > --- a/drivers/usb/dwc2/debugfs.c > +++ b/drivers/usb/dwc2/debugfs.c > @@ -183,6 +183,7 @@ DEFINE_SHOW_ATTRIBUTE(state); > static int fifo_show(struct seq_file *seq, void *v) > { > struct dwc2_hsotg *hsotg = seq->private; > + int fifo_count = dwc2_hsotg_tx_fifo_count(hsotg); > u32 val; > int idx; > > @@ -196,7 +197,7 @@ static int fifo_show(struct seq_file *seq, void *v) > > seq_puts(seq, "\nPeriodic TXFIFOs:\n"); > > - for (idx = 1; idx < hsotg->num_of_eps; idx++) { > + for (idx = 1; idx <= fifo_count; idx++) { > val = dwc2_readl(hsotg, DPTXFSIZN(idx)); > > seq_printf(seq, "\tDPTXFIFO%2d: Size %d, Start 0x%08x\n", idx, >
diff --git a/drivers/usb/dwc2/debugfs.c b/drivers/usb/dwc2/debugfs.c index b8f2790abf91..3a0dcbfbc827 100644 --- a/drivers/usb/dwc2/debugfs.c +++ b/drivers/usb/dwc2/debugfs.c @@ -183,6 +183,7 @@ DEFINE_SHOW_ATTRIBUTE(state); static int fifo_show(struct seq_file *seq, void *v) { struct dwc2_hsotg *hsotg = seq->private; + int fifo_count = dwc2_hsotg_tx_fifo_count(hsotg); u32 val; int idx; @@ -196,7 +197,7 @@ static int fifo_show(struct seq_file *seq, void *v) seq_puts(seq, "\nPeriodic TXFIFOs:\n"); - for (idx = 1; idx < hsotg->num_of_eps; idx++) { + for (idx = 1; idx <= fifo_count; idx++) { val = dwc2_readl(hsotg, DPTXFSIZN(idx)); seq_printf(seq, "\tDPTXFIFO%2d: Size %d, Start 0x%08x\n", idx,
The number of FIFOs may be lower than the number of endpoints. Use the correct total when printing FIFO details in debugfs. Signed-off-by: John Keeping <john@metanate.com> --- drivers/usb/dwc2/debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)