| Message ID | 20200302092759.3291-1-jbx6244@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/3] dt-bindings: arm: fix Rockchip Kylin board bindings | expand |
On Mon, 2 Mar 2020 10:27:57 +0100, Johan Jonker wrote: > A test with the command below gives this error: > > arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible: > ['rockchip,rk3036-kylin', 'rockchip,rk3036'] > is not valid under any of the given schemas > > Normally the dt-binding is the authoritative part, so boards should follow > the binding, but in the kylin-case the compatible from the .dts is used for > years in the field now, so fix the binding, as otherwise > we would break old users. > > Fix this error by changing 'rockchip,kylin-rk3036' to > 'rockchip,rk3036-kylin' in rockchip.yaml. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: Rob Herring <robh@kernel.org>
Am Montag, 2. März 2020, 10:27:57 CET schrieb Johan Jonker: > A test with the command below gives this error: > > arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible: > ['rockchip,rk3036-kylin', 'rockchip,rk3036'] > is not valid under any of the given schemas > > Normally the dt-binding is the authoritative part, so boards should follow > the binding, but in the kylin-case the compatible from the .dts is used for > years in the field now, so fix the binding, as otherwise > we would break old users. > > Fix this error by changing 'rockchip,kylin-rk3036' to > 'rockchip,rk3036-kylin' in rockchip.yaml. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> applied all 3 for 5.7 Thanks Heiko
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 874b0eaa2..203158038 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -443,7 +443,7 @@ properties: - description: Rockchip Kylin items: - - const: rockchip,kylin-rk3036 + - const: rockchip,rk3036-kylin - const: rockchip,rk3036 - description: Rockchip PX3 Evaluation board
A test with the command below gives this error: arch/arm/boot/dts/rk3036-kylin.dt.yaml: /: compatible: ['rockchip,rk3036-kylin', 'rockchip,rk3036'] is not valid under any of the given schemas Normally the dt-binding is the authoritative part, so boards should follow the binding, but in the kylin-case the compatible from the .dts is used for years in the field now, so fix the binding, as otherwise we would break old users. Fix this error by changing 'rockchip,kylin-rk3036' to 'rockchip,rk3036-kylin' in rockchip.yaml. make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/arm/rockchip.yaml Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)