From patchwork Mon Jun 8 18:31:41 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 11593819 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 137E790 for ; Mon, 8 Jun 2020 18:32:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4325206D5 for ; Mon, 8 Jun 2020 18:32:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jMb4Rpym"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="o4vOcHSl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4325206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=57rz4QwljcCON8wNHHKITgWfe9kFFUf7q8v8MqiaZw8=; b=jMb4Rpym7lT5Yu VWw4fYGTvf+1dO6/CmkVIRCtHYOHTZDkqdkdgDuqQBFyclYNA1UN8aoNZ+US+ok2XbAUMdXA7LbWF HGosTJRzjXvcF2m3JwyExSl1ebyppUmtSI6RYzVbbyYv728PzsZ19wiR70pud2TkTQLBXJ7CvQ7a/ wRNdN1pq+ybPzkZKCDl8xe2v7D6UUMa7KMNDRCe+/92gVybc47oGYPWx464f8RR4mPxZ81WqjBbuH QNEf9xtGjSZ5ux6vYvP7kZ0+UfoImKB1nw0kj/U3560X5gw+DWHWir5f0B08l5/8S9ebM+TBm7ddp 4CmjA5Svlg2rHGyKO79g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiMZ5-0003CU-Pw; Mon, 08 Jun 2020 18:32:07 +0000 Received: from mail-pj1-x1044.google.com ([2607:f8b0:4864:20::1044]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jiMZ3-0003Aw-8c for linux-rockchip@lists.infradead.org; Mon, 08 Jun 2020 18:32:06 +0000 Received: by mail-pj1-x1044.google.com with SMTP id ne5so189109pjb.5 for ; Mon, 08 Jun 2020 11:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=whusgV3SuU4OYdnISZ0eE6+udK0GNJd8qRyaT+j/kBs=; b=o4vOcHSlGohJvcJZsnzHRbPKP7nyciDvvH7VydgtrjIIASHxjDjpDCWmH2j7VWkyzM cLp9+WZJSK2eXzZC/ciB0FJYmvZJu8nmr7uwP/JbgmnVXEiisOENPge7hiJX9HFawMdw wXfzXOF+3FzlQZOGbjbeZeTc1YqoEnXXZguyk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=whusgV3SuU4OYdnISZ0eE6+udK0GNJd8qRyaT+j/kBs=; b=NhTDgkgVqy8J0DXMSuOVIjDwZdhIiIifqK83rGIWDJnJeKYZtQBCEhyd+q1v+2cAIF Mzpsi8yHDeVlU4jO2sTdV4w3vjp3nAAjg/9V4ocyMu552uqxsCzwcvh7QORPim8W1oSJ et5rs1lOTudAEWA9Ear+FTnIVgBBicZToWTn0IBEehksR6pfSX6d3o3WO+TpbvnsqG3N XAi6yt+SkkkW8C2LE5a/R8wsoiAlPGDwb0eqzkmnhiHSLIe87oNxWWnAkm6akmwO3DAT lUK9qGxESWLxYEjcUQ6j50Ss81JJ+NGKNJBMzDD9AtEqCovqSH4Z89ltP78IqFYgN2xK u6Hw== X-Gm-Message-State: AOAM532tmS9ViE5bF3y1wV2R8pUlmTtc5hicEp5cgH+kf36OClHqzHY3 t3SYe0SQXNmE8cqFO31nTCCXSQ== X-Google-Smtp-Source: ABdhPJz3Uf3oNHvSfG8gGMGJlnb3J6nbhjLmIQw3YuaF9MqH/XeL08lK3vefRaK8yOlV+gJUP0lgtg== X-Received: by 2002:a17:90b:110f:: with SMTP id gi15mr622869pjb.87.1591641124486; Mon, 08 Jun 2020 11:32:04 -0700 (PDT) Received: from localhost.localdomain ([2405:201:c809:c7d5:9043:af95:b7b4:3ade]) by smtp.gmail.com with ESMTPSA id k29sm6680961pgf.77.2020.06.08.11.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 11:32:03 -0700 (PDT) From: Jagan Teki To: Kever Yang , Philipp Tomsich , Simon Glass Subject: [PATCH v3 2/5] rk3399: spl: Print SPL banner after relocation Date: Mon, 8 Jun 2020 14:31:41 -0400 Message-Id: <20200608183144.26809-3-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200608183144.26809-1-jagan@amarulasolutions.com> References: <20200608183144.26809-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200608_113205_318354_6BB4FD4B X-CRM114-Status: GOOD ( 12.11 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:1044 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: U-Boot-Denx , linux-rockchip@lists.infradead.org, linux-amarula , Jagan Teki , Suniel Mahesh Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org Usually printing the SPL banner varies between architecture or board codes. - Some would print before relocation at the end board_init_f   for making sure all initialization prior to this would happen   properly. if at all there is a requirement for serial init,   that happens properly since it prints all after that. - Some would print after relocation at the spl_board_init for   making sure all initialization prior to relocation would happen properly. Also debug uart on these cases would be available before relocation. So debug support is available in before and after relocation. Rockchip SPL is following formar step to print the banner at the end of board_init_f. To support various custom use cases in SPL like leds, environment, board detections later options like printing the banner after relocation would be a better option. Printing banner would also help to support debugging availability between relocation codes, like debug uart available before relocation and banner availability after relation. By demonstrating all the above use cases, this patch is trying to print the SPL banner after relocation. Signed-off-by: Jagan Teki Tested-by: Suniel Mahesh --- Changes for v3: - new patch arch/arm/mach-rockchip/rk3399/rk3399.c | 2 ++ arch/arm/mach-rockchip/spl.c | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-rockchip/rk3399/rk3399.c b/arch/arm/mach-rockchip/rk3399/rk3399.c index 681f80f339..af4b0e271b 100644 --- a/arch/arm/mach-rockchip/rk3399/rk3399.c +++ b/arch/arm/mach-rockchip/rk3399/rk3399.c @@ -279,6 +279,8 @@ void spl_board_init(void) { /* board specific spl init */ rk_spl_board_init(); + + preloader_console_init(); } #endif diff --git a/arch/arm/mach-rockchip/spl.c b/arch/arm/mach-rockchip/spl.c index cddf4fd3d5..1c2dca8a72 100644 --- a/arch/arm/mach-rockchip/spl.c +++ b/arch/arm/mach-rockchip/spl.c @@ -147,7 +147,6 @@ void board_init_f(ulong dummy) gd->ram_top = gd->ram_base + get_effective_memsize(); gd->ram_top = board_get_usable_ram_top(gd->ram_size); #endif - preloader_console_init(); } #ifdef CONFIG_SPL_LOAD_FIT