| Message ID | 20201110200430.1713467-1-paul.kocialkowski@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/rockchip: Avoid uninitialized use of endpoint id in LVDS | expand |
On Tue, 10 Nov 2020 21:04:30 +0100, Paul Kocialkowski wrote: > In the Rockchip DRM LVDS component driver, the endpoint id provided to > drm_of_find_panel_or_bridge is grabbed from the endpoint's reg property. > > However, the property may be missing in the case of a single endpoint. > Initialize the endpoint_id variable to 0 to avoid using an > uninitialized variable in that case. Applied, thanks! [1/1] drm/rockchip: Avoid uninitialized use of endpoint id in LVDS commit: aec9fe892812ed10d0bffcf309d2a8fc380d8ce6 Best regards,
diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c index f292c6a6e20f..41edd0a421b2 100644 --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c @@ -544,7 +544,7 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, struct device_node *port, *endpoint; int ret = 0, child_count = 0; const char *name; - u32 endpoint_id; + u32 endpoint_id = 0; lvds->drm_dev = drm_dev; port = of_graph_get_port_by_id(dev->of_node, 1);
In the Rockchip DRM LVDS component driver, the endpoint id provided to drm_of_find_panel_or_bridge is grabbed from the endpoint's reg property. However, the property may be missing in the case of a single endpoint. Initialize the endpoint_id variable to 0 to avoid using an uninitialized variable in that case. Fixes: 34cc0aa25456 ("drm/rockchip: Add support for Rockchip Soc LVDS") Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com> --- drivers/gpu/drm/rockchip/rockchip_lvds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)