From patchwork Sun Jan 24 21:03:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 12042643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3853EC433DB for ; Sun, 24 Jan 2021 21:03:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E44F22CA2 for ; Sun, 24 Jan 2021 21:03:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E44F22CA2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kleine-koenig.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9U1sgaRH93TESIG64p3KZi9D8UwnHZIURWvf/mVNDO4=; b=w16wDCv/eGNCVvs/9T3EAShP6 tscyDpffodU27iKZR6rWGy8UfGssqk8kxgv3JmUf47t05BmCj1hwdafYY0TerO3B66HjEz7/aJVtG iUvkMHl4mKH2Uf+mJA5xLBniRaRUY4y8v/Wzk1EWNKx0K186EbfXHRL9B73oS8rvtmD8trFgeyNxb DH1SwQ+gjAXw4DCdTuR903hJ0zIpXVD67o+RrDK6OtG+wCeUanXZ5JdQIPmMhoFOmoqFBp/1prpTt pZwRd4LMp3RYPStSC/eGsh1OIb5MFDLnjE6vUZqh7V2VAEfNSNqOvv27Qy6/WrsYPrwb1vix6V9i9 gV+014tsg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3mXr-00078G-0q; Sun, 24 Jan 2021 21:03:39 +0000 Received: from antares.kleine-koenig.org ([2a01:4f8:c0c:3a97::2]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l3mXn-00077X-G0 for linux-rockchip@lists.infradead.org; Sun, 24 Jan 2021 21:03:36 +0000 Received: by antares.kleine-koenig.org (Postfix, from userid 1000) id CDBA7ADC8EE; Sun, 24 Jan 2021 22:03:30 +0100 (CET) From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Rob Herring , Heiko Stuebner Subject: [PATCH 2/2] arm64: dts: rockchip: Rely on SoC external pull up on pmic-int-l Date: Sun, 24 Jan 2021 22:03:28 +0100 Message-Id: <20210124210328.611707-2-uwe@kleine-koenig.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210124210328.611707-1-uwe@kleine-koenig.org> References: <20210124210328.611707-1-uwe@kleine-koenig.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210124_160335_651825_A613B6A9 X-CRM114-Status: GOOD ( 11.93 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Aditya Prayoga , linux-rockchip@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org According to the schematic there is an external pull up, so there is no need to enable the internal one additionally. Using no pull up matches the vendor device tree. Signed-off-by: Uwe Kleine-König --- arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts index d6446c32b91e..1e880a0a3f69 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-kobol-helios64.dts @@ -331,7 +331,7 @@ sys_red_led_on: sys-red-led-on { pmic { pmic_int_l: pmic-int-l { - rockchip,pins = <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_up>; + rockchip,pins = <0 RK_PB2 RK_FUNC_GPIO &pcfg_pull_none>; }; };