| Message ID | 20210208143855.418374-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally | expand |
On Mon, 8 Feb 2021 15:38:55 +0100, Geert Uytterhoeven wrote: > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > To fix this, restrict the automatic enabling of ROCKCHIP_GRF to > ARCH_ROCKCHIP, and ask the user in case of compile-testing. Applied, thanks! [1/1] soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally commit: 2a1c55d4762dd34a8b0f2e36fb01b7b16b60735b I actually found the old one deep down in my inbox some days ago, so had applied that one already. Hope nothing changed with your RESEND. Best regards,
Hi Heiko, On Fri, Jul 16, 2021 at 12:42 AM Heiko Stuebner <heiko@sntech.de> wrote: > On Mon, 8 Feb 2021 15:38:55 +0100, Geert Uytterhoeven wrote: > > Merely enabling CONFIG_COMPILE_TEST should not enable additional code. > > To fix this, restrict the automatic enabling of ROCKCHIP_GRF to > > ARCH_ROCKCHIP, and ask the user in case of compile-testing. > > Applied, thanks! > > [1/1] soc: rockchip: ROCKCHIP_GRF should not default to y, unconditionally > commit: 2a1c55d4762dd34a8b0f2e36fb01b7b16b60735b > > I actually found the old one deep down in my inbox some days ago, > so had applied that one already. Hope nothing changed with your > RESEND. They're identical, thanks! Gr{oetje,eeting}s, Geert
diff --git a/drivers/soc/rockchip/Kconfig b/drivers/soc/rockchip/Kconfig index 2c13bf4dd5dbee76..25eb2c1e31bb2a08 100644 --- a/drivers/soc/rockchip/Kconfig +++ b/drivers/soc/rockchip/Kconfig @@ -6,8 +6,8 @@ if ARCH_ROCKCHIP || COMPILE_TEST # config ROCKCHIP_GRF - bool - default y + bool "Rockchip General Register Files support" if COMPILE_TEST + default y if ARCH_ROCKCHIP help The General Register Files are a central component providing special additional settings registers for a lot of soc-components.
Merely enabling CONFIG_COMPILE_TEST should not enable additional code. To fix this, restrict the automatic enabling of ROCKCHIP_GRF to ARCH_ROCKCHIP, and ask the user in case of compile-testing. Fixes: 4c58063d4258f6be ("soc: rockchip: add driver handling grf setup") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/soc/rockchip/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)