| Message ID | 20211124125506.2971069-2-daniel.lezcano@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | None | expand |
On 2021-11-24 12:55, Daniel Lezcano wrote: > Add the powerzones description. This first step introduces the big, > the little and the gpu as a powerzone place. These look more like SoC-level properties than board-level ones - should they be in rk3399.dtsi? Robin. > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > .../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++ > 1 file changed, 45 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > index 1a23e8f3cdf6..83540bdb64cd 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > @@ -61,6 +61,51 @@ bt_active_led: led-6 { > }; > }; > > + powerzones { > + > + PKG_PZ: pkg { > + #powerzone-cells = <0>; > + powerzone = <&SOC_PZ>; > + }; > + > + SOC_PZ: soc { > + }; > + }; > +}; > + > +&cpu_b0 { > + #powerzone-cells = <0>; > + powerzone = <&PKG_PZ>; > +}; > + > +&cpu_b1 { > + #powerzone-cells = <0>; > + powerzone = <&PKG_PZ>; > +}; > + > +&cpu_l0 { > + #powerzone-cells = <0>; > + powerzone = <&PKG_PZ>; > +}; > + > +&cpu_l1 { > + #powerzone-cells = <0>; > + powerzone = <&PKG_PZ>; > +}; > + > +&cpu_l2 { > + #powerzone-cells = <0>; > + powerzone = <&PKG_PZ>; > +}; > + > +&cpu_l3 { > + #powerzone-cells = <0>; > + powerzone = <&PKG_PZ>; > +}; > + > +&gpu { > + #powerzone-cells = <0>; > + powerzone = <&PKG_PZ>; > }; > > &cpu_alert0 { >
On 24/11/2021 14:49, Robin Murphy wrote: > On 2021-11-24 12:55, Daniel Lezcano wrote: >> Add the powerzones description. This first step introduces the big, >> the little and the gpu as a powerzone place. > > These look more like SoC-level properties than board-level ones - should > they be in rk3399.dtsi? Yes, it makes sense If Heiko is fine with that I can add this description in the rk3399.dtsi file >> --- >> .../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++ >> 1 file changed, 45 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts >> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts >> index 1a23e8f3cdf6..83540bdb64cd 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts >> @@ -61,6 +61,51 @@ bt_active_led: led-6 { >> }; >> }; >> + powerzones { >> + >> + PKG_PZ: pkg { >> + #powerzone-cells = <0>; >> + powerzone = <&SOC_PZ>; >> + }; >> + >> + SOC_PZ: soc { >> + }; >> + }; >> +}; >> + >> +&cpu_b0 { >> + #powerzone-cells = <0>; >> + powerzone = <&PKG_PZ>; >> +}; >> + >> +&cpu_b1 { >> + #powerzone-cells = <0>; >> + powerzone = <&PKG_PZ>; >> +}; >> + >> +&cpu_l0 { >> + #powerzone-cells = <0>; >> + powerzone = <&PKG_PZ>; >> +}; >> + >> +&cpu_l1 { >> + #powerzone-cells = <0>; >> + powerzone = <&PKG_PZ>; >> +}; >> + >> +&cpu_l2 { >> + #powerzone-cells = <0>; >> + powerzone = <&PKG_PZ>; >> +}; >> + >> +&cpu_l3 { >> + #powerzone-cells = <0>; >> + powerzone = <&PKG_PZ>; >> +}; >> + >> +&gpu { >> + #powerzone-cells = <0>; >> + powerzone = <&PKG_PZ>; >> }; >> &cpu_alert0 { >>
Am Mittwoch, 24. November 2021, 17:41:34 CET schrieb Daniel Lezcano: > On 24/11/2021 14:49, Robin Murphy wrote: > > On 2021-11-24 12:55, Daniel Lezcano wrote: > >> Add the powerzones description. This first step introduces the big, > >> the little and the gpu as a powerzone place. > > > > These look more like SoC-level properties than board-level ones - should > > they be in rk3399.dtsi? > > Yes, it makes sense > > If Heiko is fine with that I can add this description in the rk3399.dtsi > file Sure. Robin's suggestion sounds very sensible as these properties are quite specific to the soc itself. Heiko > > >> --- > >> .../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++ > >> 1 file changed, 45 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > >> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > >> index 1a23e8f3cdf6..83540bdb64cd 100644 > >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts > >> @@ -61,6 +61,51 @@ bt_active_led: led-6 { > >> }; > >> }; > >> + powerzones { > >> + > >> + PKG_PZ: pkg { > >> + #powerzone-cells = <0>; > >> + powerzone = <&SOC_PZ>; > >> + }; > >> + > >> + SOC_PZ: soc { > >> + }; > >> + }; > >> +}; > >> + > >> +&cpu_b0 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_b1 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_l0 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_l1 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_l2 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&cpu_l3 { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> +}; > >> + > >> +&gpu { > >> + #powerzone-cells = <0>; > >> + powerzone = <&PKG_PZ>; > >> }; > >> &cpu_alert0 { > >> > > >
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts index 1a23e8f3cdf6..83540bdb64cd 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts @@ -61,6 +61,51 @@ bt_active_led: led-6 { }; }; + powerzones { + + PKG_PZ: pkg { + #powerzone-cells = <0>; + powerzone = <&SOC_PZ>; + }; + + SOC_PZ: soc { + }; + }; +}; + +&cpu_b0 { + #powerzone-cells = <0>; + powerzone = <&PKG_PZ>; +}; + +&cpu_b1 { + #powerzone-cells = <0>; + powerzone = <&PKG_PZ>; +}; + +&cpu_l0 { + #powerzone-cells = <0>; + powerzone = <&PKG_PZ>; +}; + +&cpu_l1 { + #powerzone-cells = <0>; + powerzone = <&PKG_PZ>; +}; + +&cpu_l2 { + #powerzone-cells = <0>; + powerzone = <&PKG_PZ>; +}; + +&cpu_l3 { + #powerzone-cells = <0>; + powerzone = <&PKG_PZ>; +}; + +&gpu { + #powerzone-cells = <0>; + powerzone = <&PKG_PZ>; }; &cpu_alert0 {
Add the powerzones description. This first step introduces the big, the little and the gpu as a powerzone place. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- .../boot/dts/rockchip/rk3399-rock960.dts | 45 +++++++++++++++++++ 1 file changed, 45 insertions(+)