| Message ID | 20230224232339.124969-2-macroalpha82@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Bluetooth: Add support for RTL8821CS | expand |
On Sat, 25 Feb 2023, at 9:23 AM, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add compatible string for RTL8821CS for existing Realtek Bluetooth > driver. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> Reviewed-by: Alistair Francis <alistair@alistair23.me> Alistair > --- > .../bindings/net/realtek-bluetooth.yaml | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > index 143b5667abad..f91d06d629b9 100644 > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > @@ -4,24 +4,29 @@ > $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth > +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth > > maintainers: > - Vasily Khoruzhick <anarsoul@gmail.com> > - Alistair Francis <alistair@alistair23.me> > > description: > - RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over > - SDIO, while BT is connected over serial. It speaks H5 protocol with few > - extra commands to upload firmware and change module speed. > + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part > + is connected over SDIO, while BT is connected over serial. It speaks > + H5 protocol with few extra commands to upload firmware and change > + module speed. > > properties: > compatible: > - enum: > - - realtek,rtl8723bs-bt > - - realtek,rtl8723cs-bt > - - realtek,rtl8723ds-bt > - - realtek,rtl8822cs-bt > + oneOf: > + - const: realtek,rtl8723bs-bt > + - const: realtek,rtl8723cs-bt > + - const: realtek,rtl8723ds-bt > + - const: realtek,rtl8822cs-bt > + - items: > + - enum: > + - realtek,rtl8821cs-bt > + - const: realtek,rtl8822cs-bt > > device-wake-gpios: > maxItems: 1 > -- > 2.34.1 > >
On 25/02/2023 00:23, Chris Morgan wrote: > From: Chris Morgan <macromorgan@hotmail.com> > > Add compatible string for RTL8821CS for existing Realtek Bluetooth > driver. > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com> > --- > .../bindings/net/realtek-bluetooth.yaml | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > index 143b5667abad..f91d06d629b9 100644 > --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml > @@ -4,24 +4,29 @@ > $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth > +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth > > maintainers: > - Vasily Khoruzhick <anarsoul@gmail.com> > - Alistair Francis <alistair@alistair23.me> > > description: > - RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over > - SDIO, while BT is connected over serial. It speaks H5 protocol with few > - extra commands to upload firmware and change module speed. > + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part > + is connected over SDIO, while BT is connected over serial. It speaks > + H5 protocol with few extra commands to upload firmware and change > + module speed. > > properties: > compatible: > - enum: > - - realtek,rtl8723bs-bt > - - realtek,rtl8723cs-bt > - - realtek,rtl8723ds-bt > - - realtek,rtl8822cs-bt > + oneOf: > + - const: realtek,rtl8723bs-bt > + - const: realtek,rtl8723cs-bt > + - const: realtek,rtl8723ds-bt > + - const: realtek,rtl8822cs-bt These still should be an enum. Why changing them? > + - items: > + - enum: > + - realtek,rtl8821cs-bt > + - const: realtek,rtl8822cs-bt Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml index 143b5667abad..f91d06d629b9 100644 --- a/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml +++ b/Documentation/devicetree/bindings/net/realtek-bluetooth.yaml @@ -4,24 +4,29 @@ $id: http://devicetree.org/schemas/net/realtek-bluetooth.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: RTL8723BS/RTL8723CS/RTL8822CS Bluetooth +title: RTL8723BS/RTL8723CS/RTL8821CS/RTL8822CS Bluetooth maintainers: - Vasily Khoruzhick <anarsoul@gmail.com> - Alistair Francis <alistair@alistair23.me> description: - RTL8723CS/RTL8723CS/RTL8822CS is WiFi + BT chip. WiFi part is connected over - SDIO, while BT is connected over serial. It speaks H5 protocol with few - extra commands to upload firmware and change module speed. + RTL8723CS/RTL8723CS/RTL8821CS/RTL8822CS is a WiFi + BT chip. WiFi part + is connected over SDIO, while BT is connected over serial. It speaks + H5 protocol with few extra commands to upload firmware and change + module speed. properties: compatible: - enum: - - realtek,rtl8723bs-bt - - realtek,rtl8723cs-bt - - realtek,rtl8723ds-bt - - realtek,rtl8822cs-bt + oneOf: + - const: realtek,rtl8723bs-bt + - const: realtek,rtl8723cs-bt + - const: realtek,rtl8723ds-bt + - const: realtek,rtl8822cs-bt + - items: + - enum: + - realtek,rtl8821cs-bt + - const: realtek,rtl8822cs-bt device-wake-gpios: maxItems: 1