| Message ID | 20230304172838.38059-1-strit@manjaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: rockchip: Lower SD card speed on Pinebook Pro | expand |
On 04/03/2023 18:28, Dan Johansen wrote: > MicroSD card slot in the Pinebook Pro is located on a separate > daughterboard that's connected to the mainboard using a rather > long flat cable. The resulting signal degradation causes many > perfectly fine microSD cards not to work in the Pinebook Pro, > which is a common source of frustration among the owners. > > Changing the mode and lowering the speed reportedly fixes this > issue and makes many microSD cards work as expected. > > Co-authored-by: Dragan Simic <dragan.simic@gmail.com> That's not a valid tag. Run checkpatch. Missing SoB, which would be pointed out by checkpatch with correct tag. Best regards, Krzysztof
Den 05.03.2023 kl. 10.52 skrev Krzysztof Kozlowski: > On 04/03/2023 18:28, Dan Johansen wrote: >> MicroSD card slot in the Pinebook Pro is located on a separate >> daughterboard that's connected to the mainboard using a rather >> long flat cable. The resulting signal degradation causes many >> perfectly fine microSD cards not to work in the Pinebook Pro, >> which is a common source of frustration among the owners. >> >> Changing the mode and lowering the speed reportedly fixes this >> issue and makes many microSD cards work as expected. >> >> Co-authored-by: Dragan Simic <dragan.simic@gmail.com> > That's not a valid tag. Run checkpatch. > > Missing SoB, which would be pointed out by checkpatch with correct tag. Thank you. I ran checkpatch and it just said it was not valid, didn't give alternatives. Would Co-developed-by acceptable instead? And then ofcourse with the added SoB for the co-developer. > > > > Best regards, > Krzysztof > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
On 05/03/2023 11:04, Dan Johansen wrote: > > Den 05.03.2023 kl. 10.52 skrev Krzysztof Kozlowski: >> On 04/03/2023 18:28, Dan Johansen wrote: >>> MicroSD card slot in the Pinebook Pro is located on a separate >>> daughterboard that's connected to the mainboard using a rather >>> long flat cable. The resulting signal degradation causes many >>> perfectly fine microSD cards not to work in the Pinebook Pro, >>> which is a common source of frustration among the owners. >>> >>> Changing the mode and lowering the speed reportedly fixes this >>> issue and makes many microSD cards work as expected. >>> >>> Co-authored-by: Dragan Simic <dragan.simic@gmail.com> >> That's not a valid tag. Run checkpatch. >> >> Missing SoB, which would be pointed out by checkpatch with correct tag. > > Thank you. I ran checkpatch and it just said it was not valid, didn't > give alternatives. > > Would Co-developed-by acceptable instead? Yes, looks good. If checkpatch does not complain, use it. Best regards, Krzysztof
Den 05.03.2023 kl. 11.43 skrev Krzysztof Kozlowski: > On 05/03/2023 11:04, Dan Johansen wrote: >> Den 05.03.2023 kl. 10.52 skrev Krzysztof Kozlowski: >>> On 04/03/2023 18:28, Dan Johansen wrote: >>>> MicroSD card slot in the Pinebook Pro is located on a separate >>>> daughterboard that's connected to the mainboard using a rather >>>> long flat cable. The resulting signal degradation causes many >>>> perfectly fine microSD cards not to work in the Pinebook Pro, >>>> which is a common source of frustration among the owners. >>>> >>>> Changing the mode and lowering the speed reportedly fixes this >>>> issue and makes many microSD cards work as expected. >>>> >>>> Co-authored-by: Dragan Simic <dragan.simic@gmail.com> >>> That's not a valid tag. Run checkpatch. >>> >>> Missing SoB, which would be pointed out by checkpatch with correct tag. >> Thank you. I ran checkpatch and it just said it was not valid, didn't >> give alternatives. >> >> Would Co-developed-by acceptable instead? > Yes, looks good. If checkpatch does not complain, use it. Thank you. It says there are no obvious issues, so will re-submit with that changed. > > Best regards, > Krzysztof > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts index 194e48c755f6..54bb0398128f 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts @@ -943,7 +943,7 @@ &sdmmc { disable-wp; pinctrl-names = "default"; pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>; - sd-uhs-sdr104; + sd-uhs-sdr50; vmmc-supply = <&vcc3v0_sd>; vqmmc-supply = <&vcc_sdio>; status = "okay";