diff mbox series

[v2] arm64: dts: rockchip: Lower SD card speed on

Message ID 20230305104730.15849-1-strit@manjaro.org (mailing list archive)
State New, archived
Headers show
Series [v2] arm64: dts: rockchip: Lower SD card speed on | expand

Commit Message

Dan Johansen March 5, 2023, 10:47 a.m. UTC
MicroSD card slot in the Pinebook Pro is located on a separate
daughterboard that's connected to the mainboard using a rather
long flat cable.  The resulting signal degradation causes many
perfectly fine microSD cards not to work in the Pinebook Pro,
which is a common source of frustration among the owners.

Changing the mode and lowering the speed reportedly fixes this
issue and makes many microSD cards work as expected.

Co-developed-by: Dragan Simic <dragan.simic@gmail.com>
Signed-off-by: Dragan Simic <dragan.simic@gmail.com>
Tested-by: JR Gonzalez <jrg@scientiam.org>
Signed-off-by: Dan Johansen <strit@manjaro.org>
---
Changes since v1:
  Use correct Co-developed-by and add missing Signed-off-by.

 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Stübner March 7, 2023, 11:35 p.m. UTC | #1
On Sun, 5 Mar 2023 11:47:31 +0100, Dan Johansen wrote:
> MicroSD card slot in the Pinebook Pro is located on a separate
> daughterboard that's connected to the mainboard using a rather
> long flat cable.  The resulting signal degradation causes many
> perfectly fine microSD cards not to work in the Pinebook Pro,
> which is a common source of frustration among the owners.
> 
> Changing the mode and lowering the speed reportedly fixes this
> issue and makes many microSD cards work as expected.
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: Lower SD card speed on
      commit: 78aedee18a86abb0bb8e31d994467c46656e9b5d

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
index 194e48c755f6..54bb0398128f 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts
@@ -943,7 +943,7 @@  &sdmmc {
 	disable-wp;
 	pinctrl-names = "default";
 	pinctrl-0 = <&sdmmc_clk &sdmmc_cmd &sdmmc_bus4>;
-	sd-uhs-sdr104;
+	sd-uhs-sdr50;
 	vmmc-supply = <&vcc3v0_sd>;
 	vqmmc-supply = <&vcc_sdio>;
 	status = "okay";