From patchwork Wed Mar 15 15:06:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13176018 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C4BFCC7618D for ; Wed, 15 Mar 2023 15:11:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nhxKHH7Y1a6cPgjlq8ynldOIXnldIBa+guvQMqkS0Es=; b=sHz0DktzmXnnzx KPqbmovx9Ihwj7HK7Kagc/tSy06qd4zQZPEudK9veyENoxSzfUxLGAyWz//7g3u0/5Twl8BakdOII 23iJP9J20GvEEFxaryKDkodO0ZEVmFHVhXse+eINqkgDW3EtElrooAjjNK4Wz75OFk7J1kLNY6T8c ZWHk2DtMUzDMIHnTAy1kDcYc8Xo57sYBW+96+4mcbKPENCZLPByqLwWzzuGUaqon8G+md6zWafdj7 9idlLHUyr0KEGiIjR0Wkc6bC3wHdkM+s3MYQxLmL4AOHat39MDLSbStd+a4A5+kON/jIZwN9fCne5 /pICvMf28LAUc5UWqlNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcSmF-00Dlff-27; Wed, 15 Mar 2023 15:10:55 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcSk8-00Dk1c-2O for linux-rockchip@bombadil.infradead.org; Wed, 15 Mar 2023 15:08:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=rshwgyjTioCO71faCxfTB8qD+5xiCDh3lm5oIJNYJSI=; b=NN44dzc5PetyihowdtRR4rmIs6 3KLQ4V0+qQ+ZMb/vsNGn0hvPCl7HiSkiHkXJWNdOPTj6KdQGUKrJUTpEDIwBCLdNuqBHqhV7PhcGb yN+hSog6OgtpNxr8ALlKbh/JwlgoCZ7de6aG1xcmfysgkoD6JUwmM2UqORWyVyEo5XKGb18YIU3cv MQiG5TZTN8S08wX73CcLAwJvdZ8hZHe7MoeUMiZQhipEIYSkToyqYWswUAYqJYzMyt6B+SgBEsgTu t3Cr1zLm2fvRdBieLichnltaca1freGh5O5tm5EAhnnlNyYa1RgayRPjRJNJoQYWkiNTSL6Q3peYu Gs7bkWSA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcSk3-0028ep-36 for linux-rockchip@lists.infradead.org; Wed, 15 Mar 2023 15:08:43 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pcSjs-00008j-Gl; Wed, 15 Mar 2023 16:08:28 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pcSjo-004KdB-K2; Wed, 15 Mar 2023 16:08:24 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pcSjo-0057jl-1Z; Wed, 15 Mar 2023 16:08:24 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner Cc: alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 123/173] ASoC: rockchip: rockchip_spdif: Convert to platform remove callback returning void Date: Wed, 15 Mar 2023 16:06:55 +0100 Message-Id: <20230315150745.67084-124-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> References: <20230315150745.67084-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1707; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=rlWaemh5g1rU89YQHf9WoIxkHz6iNm5nKoRUg8ayQWU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkEd6iN/f1A+POuc00eAzNx+MicdH5YwPwIHzDF fnYJxlQM+qJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZBHeogAKCRDB/BR4rcrs CWCaB/9ZFn64nRSnQ7vzabp6712lwI3s6X0NLJKZD5OP+GPLprl/YMMK/KksxgLBIh9XzWdr/+2 7dlGddyyvmsTKFVBmc006vaXoj/An8bywG82MJyN4sQ+FsSofM2KhUXakOF0aJRrwobi6dxLK65 VUfLhskBlZye7NpnTDMD/AtwfFAVZeb1mXBujvPJxhvKIXd4lKZx1Gccfhv5e+u7unG78LYoJ64 v8MzPA+ViWbkzym9jVSjti1dENGjnXDueup7SnyDmGpet4tfoFhTtbw2/J3EuyWmplu0Coh2k6B ybes8lR+RJNg9cGZ54EolMScG65aMldYl2kEsYkzdbMhhLVx X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_150841_847972_1A4CEA9A X-CRM114-Status: GOOD ( 16.99 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/soc/rockchip/rockchip_spdif.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/rockchip/rockchip_spdif.c b/sound/soc/rockchip/rockchip_spdif.c index 2d937fcf357d..0b73fe94e4bb 100644 --- a/sound/soc/rockchip/rockchip_spdif.c +++ b/sound/soc/rockchip/rockchip_spdif.c @@ -367,13 +367,11 @@ static int rk_spdif_probe(struct platform_device *pdev) return ret; } -static int rk_spdif_remove(struct platform_device *pdev) +static void rk_spdif_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); if (!pm_runtime_status_suspended(&pdev->dev)) rk_spdif_runtime_suspend(&pdev->dev); - - return 0; } static const struct dev_pm_ops rk_spdif_pm_ops = { @@ -383,7 +381,7 @@ static const struct dev_pm_ops rk_spdif_pm_ops = { static struct platform_driver rk_spdif_driver = { .probe = rk_spdif_probe, - .remove = rk_spdif_remove, + .remove_new = rk_spdif_remove, .driver = { .name = "rockchip-spdif", .of_match_table = of_match_ptr(rk_spdif_match),