From patchwork Sun Mar 26 14:31:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13188200 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 637D9C77B62 for ; Sun, 26 Mar 2023 14:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aJWByEk7fp7+StAmEKynyzHZ9RRu03OXMaIwz3QRJn4=; b=cNk8GrPXXvzynr VA2/J4LRpXwPWupe+XL7QIcPHMfXSEOqJSZomUJ0CVj7RpHboYtXC9nnb610XsN1Rg52RV2ciFbeo la7YrfjUMWhe5wPgfeu0EF9aWph2D1LI18oXKTf3gdwqVo9gLsKl35huQT4cj3tVyD2Dzdi5eBegO zDd2vrpToYfhWauOXsZ3Z9v/aEOSRrc1X4TT4mgjQpOLJ3HzbcDWM1yk8MhaZEVU/Mz4ONCTRkASX iwIXa/9sIlEhvYYPqsG3tigt4eArtgyq3xJa0KSoWU3zy7KSAHdjwys4Av206O2diiHlGLrAJB+Sr rIWxspFhdboN5HR1kcOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pgRRM-008ZUh-1k; Sun, 26 Mar 2023 14:33:48 +0000 Received: from casper.infradead.org ([90.155.50.34]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pgRQc-008Yp5-0x for linux-rockchip@bombadil.infradead.org; Sun, 26 Mar 2023 14:33:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description; bh=epLJ6s4rNtn9ShVGxNQk2Gys4sZ4N5vBVVoYJaVmc2c=; b=nKKt4PY6UXs9gSDxegxdy/QYHr gwOmE45vSWDGwpgap2i2f1RprlditqVmXPm0dCrEk1ZWnApL3NWwnhoU+8z13fy8qgyYZljdS/Qm8 RLD57Kd7GRHPDRxN0No4TzZ1pt6vPbb8u2Rruw0+voTdJ7JV2yeZNmHpUzWQx1OPejWJFdH0U44cX wXRC4gpND88OMpBuZbLhJfJEFjzabAfIP7+mpb3LGMun9W3pgKNsRaUGvXMqVu3JKUx7nm2M9cKRM 9/moPP/7uas3FVMEUYmkKpBqMFQtIVObpW1WdygnKArpYiNJKb8MtvBdEG+opiNg+D4+G6zZhJw0a xrSxM5OA==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by casper.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pgRQT-006aQr-5h for linux-rockchip@lists.infradead.org; Sun, 26 Mar 2023 14:33:01 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgRQI-0008RZ-RV; Sun, 26 Mar 2023 16:32:42 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pgRQF-006rdH-KI; Sun, 26 Mar 2023 16:32:39 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pgRQE-0088Xc-DI; Sun, 26 Mar 2023 16:32:38 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Dafna Hirschfeld , Mauro Carvalho Chehab , Heiko Stuebner Cc: linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 060/117] media: rkisp1-dev: Convert to platform remove callback returning void Date: Sun, 26 Mar 2023 16:31:27 +0200 Message-Id: <20230326143224.572654-63-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> References: <20230326143224.572654-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1786; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=Las+mkTmyDmRr0fHmoy+1HXOXOBTIkYgBinmFYNv/w4=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkIFbOhKe5iFEeZtaIE2yURCxYMuGQRmTh1Y9LN B+ToOKPFUSJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCBWzgAKCRCPgPtYfRL+ TsngCACG7ACjJvUnzOuiMw/JoBsfe+H9JvMXYxc513dmVUlhNII4PUM+agoqvv2x87UqHjY8yZA k9X5H/WjbP839F1NxO3pT7eE3oDsbrpkBcN0uzvnarW+NM15qArGWUIe7jmx+zwEEUIAbDDodbu SAUaJscUYoxdPnU4D2w7w1FU7o47/V1jAvvQcBmz41tI5xa4YqBDvCVJWm2DfwKPkpulaEWaIfI ov521B2oGEwUPJcw5ehFyLz3SthvMmaCfyoduz7+4oUrRB+bPoh2r8MTcdKipJUlT7AnB1VcdRk Y8vuYZWcbEMStbNbNUWT7MaZF6a3ohYbwtIV/f8CHKe21Hy5 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230326_153253_383195_B5D89482 X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c index f2475c6235ea..4762cb32353d 100644 --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c @@ -622,7 +622,7 @@ static int rkisp1_probe(struct platform_device *pdev) return ret; } -static int rkisp1_remove(struct platform_device *pdev) +static void rkisp1_remove(struct platform_device *pdev) { struct rkisp1_device *rkisp1 = platform_get_drvdata(pdev); @@ -638,8 +638,6 @@ static int rkisp1_remove(struct platform_device *pdev) v4l2_device_unregister(&rkisp1->v4l2_dev); pm_runtime_disable(&pdev->dev); - - return 0; } static struct platform_driver rkisp1_drv = { @@ -649,7 +647,7 @@ static struct platform_driver rkisp1_drv = { .pm = &rkisp1_pm_ops, }, .probe = rkisp1_probe, - .remove = rkisp1_remove, + .remove_new = rkisp1_remove, }; module_platform_driver(rkisp1_drv);