| Message ID | 20230505113856.463650-13-s.hauer@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add perf support to the rockchip-dfi driver | expand |
On Fri, 5 May 2023 13:38:47 +0200 Sascha Hauer <s.hauer@pengutronix.de> wrote: > In the DFI driver LPDDR4X can be handled in the same way as LPDDR4. Add > the missing case. > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> No equivalent for the DMC driver you moved to he defines earlier? I'm guessing not in which case this seems fine to me Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/devfreq/event/rockchip-dfi.c | 1 + > include/soc/rockchip/rockchip_grf.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c > index 92ee61c96a1a9..dc48d9c26f599 100644 > --- a/drivers/devfreq/event/rockchip-dfi.c > +++ b/drivers/devfreq/event/rockchip-dfi.c > @@ -89,6 +89,7 @@ static void rockchip_dfi_start_hardware_counter(struct devfreq_event_dev *edev) > dfi_regs + DDRMON_CTRL); > break; > case ROCKCHIP_DDRTYPE_LPDDR4: > + case ROCKCHIP_DDRTYPE_LPDDR4X: > writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR4, DDRMON_CTRL_DDR_TYPE_MASK), > dfi_regs + DDRMON_CTRL); > break; > diff --git a/include/soc/rockchip/rockchip_grf.h b/include/soc/rockchip/rockchip_grf.h > index dc77bb762a05a..7150a3362b142 100644 > --- a/include/soc/rockchip/rockchip_grf.h > +++ b/include/soc/rockchip/rockchip_grf.h > @@ -11,5 +11,6 @@ > #define ROCKCHIP_DDRTYPE_LPDDR2 5 > #define ROCKCHIP_DDRTYPE_LPDDR3 6 > #define ROCKCHIP_DDRTYPE_LPDDR4 7 > +#define ROCKCHIP_DDRTYPE_LPDDR4X 8 > > #endif /* __SOC_ROCKCHIP_GRF_H */
On Tue, May 16, 2023 at 05:09:19PM +0100, Jonathan Cameron wrote: > On Fri, 5 May 2023 13:38:47 +0200 > Sascha Hauer <s.hauer@pengutronix.de> wrote: > > > In the DFI driver LPDDR4X can be handled in the same way as LPDDR4. Add > > the missing case. > > > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > No equivalent for the DMC driver you moved to he defines earlier? The DMC driver needs its own set of changes. Like the DFI driver it's currently RK3399 only. I'll leave that for someone who has active interest in this driver. Sascha
diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c index 92ee61c96a1a9..dc48d9c26f599 100644 --- a/drivers/devfreq/event/rockchip-dfi.c +++ b/drivers/devfreq/event/rockchip-dfi.c @@ -89,6 +89,7 @@ static void rockchip_dfi_start_hardware_counter(struct devfreq_event_dev *edev) dfi_regs + DDRMON_CTRL); break; case ROCKCHIP_DDRTYPE_LPDDR4: + case ROCKCHIP_DDRTYPE_LPDDR4X: writel_relaxed(HIWORD_UPDATE(DDRMON_CTRL_LPDDR4, DDRMON_CTRL_DDR_TYPE_MASK), dfi_regs + DDRMON_CTRL); break; diff --git a/include/soc/rockchip/rockchip_grf.h b/include/soc/rockchip/rockchip_grf.h index dc77bb762a05a..7150a3362b142 100644 --- a/include/soc/rockchip/rockchip_grf.h +++ b/include/soc/rockchip/rockchip_grf.h @@ -11,5 +11,6 @@ #define ROCKCHIP_DDRTYPE_LPDDR2 5 #define ROCKCHIP_DDRTYPE_LPDDR3 6 #define ROCKCHIP_DDRTYPE_LPDDR4 7 +#define ROCKCHIP_DDRTYPE_LPDDR4X 8 #endif /* __SOC_ROCKCHIP_GRF_H */
In the DFI driver LPDDR4X can be handled in the same way as LPDDR4. Add the missing case. Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> --- drivers/devfreq/event/rockchip-dfi.c | 1 + include/soc/rockchip/rockchip_grf.h | 1 + 2 files changed, 2 insertions(+)