From patchwork Mon May 8 20:52:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13235084 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A7021C7EE25 for ; Mon, 8 May 2023 20:54:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KvEi6Iyw8e6FPbEiy/7H2kaBqXiCPjtHGkKt+Z1yXMU=; b=tCHRlD7RvSOsg0 o8i/LGG/Xcv1e+pL1SFeutnmXG2MKCelKL4P9ojDcowGI/bpOnN3gOt60YU6sCSeLrQLPjgp14aRf bRORvF4o5wR+4kPjZxHwy6pYz05VSvSFY3L5Wkq1Dsv61KBFrMPnRuDvWXBFVg0qMRZdCo/tC5qz2 yLz/AElfJwh8H1e9GVvt5EG6MzqsNbg9Wbe9pUQggtcJLMsWC5WKWewtPalTnAkP5R6irD1DCCTd3 CWZMD1XqUJu190yjKLpE0WlEjGjS1eghinQ3+JhjW+b/jksUok1gBvK397pV2585vIyC7MxjtTpsm 6ViCmVzgChsjz2xebaVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pw7rq-001OKI-1N; Mon, 08 May 2023 20:53:58 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pw7rQ-001Nuv-2s for linux-rockchip@lists.infradead.org; Mon, 08 May 2023 20:53:34 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pw7rM-0003u4-HF; Mon, 08 May 2023 22:53:28 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pw7rL-0024tn-QY; Mon, 08 May 2023 22:53:27 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pw7rL-002YYb-3R; Mon, 08 May 2023 22:53:27 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Heiko Stuebner , Wolfram Sang Cc: linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 60/89] i2c: rk3x: Convert to platform remove callback returning void Date: Mon, 8 May 2023 22:52:37 +0200 Message-Id: <20230508205306.1474415-61-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230508205306.1474415-1-u.kleine-koenig@pengutronix.de> References: <20230508205306.1474415-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1732; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=AaGQFomoFiReIuYC1pvhE1kk8xeCgfnRJ003pYzGhgM=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkWWD5Blzh3tdEZ68Ch76V/oeJAIwfm2QSaUoF3 P3jfmJKhR2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZFlg+QAKCRCPgPtYfRL+ TjSdB/4v3jPTc2dE7vKKlt4EWSbbgv80S8HhHvYgxRfjJThGDeoyEkYFNDzq2neYS2v6K9AUdHU 7lwc1jnSXwafNhdBALDwOdchW/Whv4zmFlbwdsUNcER0c1hW5dFNGfPrHN8jxYt43LxtSZ0OyH+ Ku9wP3hu6KGUA/ZX66B4g3VoTy7tWbXpTQnRS5Li0tr5oDuBvwb/BZX5ws9bIsX4J5jZwHfV015 r/5Pge2HgVS9ujCCd/jgGUbyxhFqGoEyP/axeYxEKhP8nq7cNaG/RjAMHnputqvJ8f2tGfsQ2js 9Ztin/AJdsZ7uZAzacYiZDDrLCgNY0PHHRKgE1wbdQdVNX7D X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230508_135332_940432_CDB660FD X-CRM114-Status: GOOD ( 16.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Acked-by: Heiko Stuebner --- drivers/i2c/busses/i2c-rk3x.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index b31cf4f18f85..a044ca0c35a1 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -1372,7 +1372,7 @@ static int rk3x_i2c_probe(struct platform_device *pdev) return ret; } -static int rk3x_i2c_remove(struct platform_device *pdev) +static void rk3x_i2c_remove(struct platform_device *pdev) { struct rk3x_i2c *i2c = platform_get_drvdata(pdev); @@ -1381,15 +1381,13 @@ static int rk3x_i2c_remove(struct platform_device *pdev) clk_notifier_unregister(i2c->clk, &i2c->clk_rate_nb); clk_unprepare(i2c->pclk); clk_unprepare(i2c->clk); - - return 0; } static SIMPLE_DEV_PM_OPS(rk3x_i2c_pm_ops, NULL, rk3x_i2c_resume); static struct platform_driver rk3x_i2c_driver = { .probe = rk3x_i2c_probe, - .remove = rk3x_i2c_remove, + .remove_new = rk3x_i2c_remove, .driver = { .name = "rk3x-i2c", .of_match_table = rk3x_i2c_match,