diff mbox series

[1/2] dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus

Message ID 20230513065228.25971-1-cnsztl@gmail.com (mailing list archive)
State New, archived
Headers show
Series [1/2] dt-bindings: Add doc for FriendlyARM NanoPi R2C Plus | expand

Commit Message

Tianling Shen May 13, 2023, 6:52 a.m. UTC 
Add devicetree binding documentation for the NanoPi R2C Plus.

Signed-off-by: Tianling Shen <cnsztl@gmail.com>
---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski May 13, 2023, 9:17 a.m. UTC | #1 
On 13/05/2023 08:52, Tianling Shen wrote:
> Add devicetree binding documentation for the NanoPi R2C Plus.
> 
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>

subject: missing prefixes (arm: rockchip:)

Drop "doc for"

Subject: drop second/last, redundant "doc". The "dt-bindings" prefix is
already stating that these are bindings and it is documentation.
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +


Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
Tianling Shen May 13, 2023, 10:21 a.m. UTC | #2 
Hi Krzysztof,

On Sat, May 13, 2023 at 5:17 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 13/05/2023 08:52, Tianling Shen wrote:
> > Add devicetree binding documentation for the NanoPi R2C Plus.
> >
> > Signed-off-by: Tianling Shen <cnsztl@gmail.com>
>
> subject: missing prefixes (arm: rockchip:)
>
> Drop "doc for"
>
> Subject: drop second/last, redundant "doc". The "dt-bindings" prefix is
> already stating that these are bindings and it is documentation.

Thanks for the suggestion! Will send v2 for it.

Regards,
Tianling.

> > ---
> >  Documentation/devicetree/bindings/arm/rockchip.yaml | 1 +
>
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index b1d271778179..6f4d966744a5 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -189,6 +189,7 @@  properties:
         items:
           - enum:
               - friendlyarm,nanopi-r2c
+              - friendlyarm,nanopi-r2c-plus
               - friendlyarm,nanopi-r2s
           - const: rockchip,rk3328