From patchwork Fri Oct 13 22:19:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13421776 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7188DCDB47E for ; Fri, 13 Oct 2023 22:20:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xiuLSq9i9CogmP27kTlbFOLBE7shi8mNFsYD+R1PcfI=; b=hfdDXeYV0+3+rf 07meZP/r5Dxh+IX0tZ7s/UR76A5Q4l4diQqseXh+TErv9grbSjrUo+6YpttKupUPBbJxXzPoOy+lK qTX/u2v2IxrB25q9z+kKu6JojkdWy+qdskrMsvPNev1vTUsZXUy+Oco1rhMIgsTw70/V8m271Ut8o W28dN1TrJPZcd30RiZCxgqycUJVVgH+imT583hZ0n1zaeTCwt5U5JAmN4eSxtmDAo1XOzYIP1qMge C6gFEsCyUZvq6qGFHlo5q9k1LYXXuzyhSwzM1S7dGd1jqaVM2C3r/ml9rsIVTD94PPaGmgZdFnIk7 vNT9VGdmwbmd3h5MZW7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qrQWH-004N3o-0H; Fri, 13 Oct 2023 22:20:33 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qrQWA-004N1S-19 for linux-rockchip@lists.infradead.org; Fri, 13 Oct 2023 22:20:31 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qrQVv-0003u2-Mh; Sat, 14 Oct 2023 00:20:11 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qrQVu-001UR1-MZ; Sat, 14 Oct 2023 00:20:10 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qrQVu-00FrGo-DA; Sat, 14 Oct 2023 00:20:10 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Liam Girdwood , Mark Brown Cc: Nicolas Frattaroli , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , linux-rockchip@lists.infradead.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 1/7] ASoC: rockchip: i2s_tdm: Convert to platform remove callback returning void Date: Sat, 14 Oct 2023 00:19:47 +0200 Message-ID: <20231013221945.1489203-10-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231013221945.1489203-9-u.kleine-koenig@pengutronix.de> References: <20231013221945.1489203-9-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1807; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=TllgjmOjMn10IcS4j2LTAf95NQP1JOMB2P4WeNA3glA=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlKcKCP/NXhj0+ihQ+srsUX95YXpJG5+0IZy8Iu eZgljftmt2JATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZSnCggAKCRCPgPtYfRL+ TmSFB/4sT4DJ034kWuvTwoq22jsYVgiW1Q7xzIWZcBuAX2Spwetg9y0flIXxPLCfAj+yn+6uBZw 1o/nympFzyUhMsxc48WTFX2j7o2sQW4NNLhB3xfA/T/H71MnXZb92R/VKs9WSJc6QcDzXD+bNus Ff9Wf3PMWoIUPIKq5vpxEDqavSeewxK7m4F40Cr/cYk2wn2ONgGNeFQDfMUOK8wgzJceCF1fTIW mL6dDSi3cszIQHnHcmt4O/x5laqTFEPvk4RbqOcsNDA+h0ZouQMBthj1yl1gbLF7zeZ5NwsPqWs O5Pxu+sVWG/iQ/d7JgfWF3pWYmhAtPmZ5ZUJtpFT1dJR6ahL X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231013_152026_428240_C77A84AE X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- sound/soc/rockchip/rockchip_i2s_tdm.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c index 7e996550d1df..5c51dbef6e86 100644 --- a/sound/soc/rockchip/rockchip_i2s_tdm.c +++ b/sound/soc/rockchip/rockchip_i2s_tdm.c @@ -1714,14 +1714,12 @@ static int rockchip_i2s_tdm_probe(struct platform_device *pdev) return ret; } -static int rockchip_i2s_tdm_remove(struct platform_device *pdev) +static void rockchip_i2s_tdm_remove(struct platform_device *pdev) { if (!pm_runtime_status_suspended(&pdev->dev)) i2s_tdm_runtime_suspend(&pdev->dev); pm_runtime_disable(&pdev->dev); - - return 0; } static int __maybe_unused rockchip_i2s_tdm_suspend(struct device *dev) @@ -1756,7 +1754,7 @@ static const struct dev_pm_ops rockchip_i2s_tdm_pm_ops = { static struct platform_driver rockchip_i2s_tdm_driver = { .probe = rockchip_i2s_tdm_probe, - .remove = rockchip_i2s_tdm_remove, + .remove_new = rockchip_i2s_tdm_remove, .driver = { .name = DRV_NAME, .of_match_table = of_match_ptr(rockchip_i2s_tdm_match),