[3/4] arm64: dts: rockchip: add rk3588 gpio aliases to soc dtsi

Commit Message

Heiko Stübner Dec. 1, 2023, 4:58 p.m. UTC

From: Heiko Stuebner <[e-mail]>

The gpio controllers on rk3588 are named gpio0 - gpio4. Board schematics
also use these exact numbers and we want those names to also reflect
in the OS devices because everything else would just cause confusion.
Userspace gpio access is a thing afterall.

So instead of having each board repeating their list of gpio aliases move
them to the soc dtsi, as previous Rockchip soc like the rk356x do already.

Signed-off-by: Heiko Stuebner <[e-mail]>
---
 arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Diederik de Haas Dec. 1, 2023, 5:23 p.m. UTC | #1

On Friday, 1 December 2023 17:58:09 CET Heiko Stuebner wrote:
> So instead of having each board repeating their list of gpio aliases move
> them to the soc dtsi

Nit:
To prevent each board repeating their list of gpio aliases, define them in the 
soc dtsi

Patch 1 did in fact *move* items, but patch 2-4 only added them to the soc 
dtsi, which I assume is to prevent them being added to each board.

Heiko Stübner Dec. 1, 2023, 5:25 p.m. UTC | #2

Am Freitag, 1. Dezember 2023, 18:23:27 CET schrieb Diederik de Haas:
> On Friday, 1 December 2023 17:58:09 CET Heiko Stuebner wrote:
> > So instead of having each board repeating their list of gpio aliases move
> > them to the soc dtsi
> 
> Nit:
> To prevent each board repeating their list of gpio aliases, define them in the 
> soc dtsi
> 
> Patch 1 did in fact *move* items, but patch 2-4 only added them to the soc 
> dtsi, which I assume is to prevent them being added to each board.

ah yes, the magic of doing similar things in bulk, thanks for catching that :-)

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
index 47512c39e55a..a59407466746 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588s.dtsi
@@ -19,6 +19,11 @@  / {
 	#size-cells = <2>;
 
 	aliases {
+		gpio0 = &gpio0;
+		gpio1 = &gpio1;
+		gpio2 = &gpio2;
+		gpio3 = &gpio3;
+		gpio4 = &gpio4;
 		i2c0 = &i2c0;
 		i2c1 = &i2c1;
 		i2c2 = &i2c2;