From patchwork Mon Mar 4 08:46:11 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13580196 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5D88EC48BF6 for ; Mon, 4 Mar 2024 08:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=H3dE+8Sj2HQF3OfI8+0tvNVfybUZKMfrr6xYjw6pGI4=; b=BAlQDVY1yKFUiS Wbni1gsIZ3Pp8GjH2gJBiprM9Ki/VOy7MP6BcsP9HDQ0QTPCHn+3Qv93NYfmsj1uwBr375CBWAvc+ p/aQw0aDyocTZK/QAVKoMGTRENa95XqPOOSGBWLnp1n3D0f8T/UZn9ySovHMiyuSDQACGv8dvkaTG 1xzL9TpLvtGSUgVbmVFuuCqj0JwLYcRBAuWtoskdNuw4Z1I3vFeADfQgpEjDfIbmQQzy8d/BwWyVe j9fllfxBptTuBmz3BEjfnru8UkXWgaLH7IwfqS0VyjfW2USTZO3gAX9FL/R6Gj0uV3daUKkI0ndvH qrZN5r1RPnlQZ2Ic/oBg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh3yO-00000008CSS-2GIm; Mon, 04 Mar 2024 08:47:00 +0000 Received: from master.debian.org ([2001:41b8:202:deb:216:36ff:fe40:4001]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rh3yH-00000008CLm-1fzs; Mon, 04 Mar 2024 08:46:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debian.org; s=smtpauto.master; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: In-Reply-To:References; bh=/im0PfNw74+d2oHRPxe0VBg20WnXI5E5dX4laaUfGjc=; b=qs b3ekEoHliC0HokDfZFHQAZ6Qci+vj62POCI3UnrkLigZeNIFHxisQSlsLcVqtQl3ZiF4eDFqo4qpF 5eRv2LBKZ84nrQ+HA3b6T1vlfXBxsinN+78MFzOnxnvP5T5UfmRpgWg91BFEILYAl7cqJGJ60Tn/x pAr5MJ+GGxvvtpb9hYQKI4ixHyv+gl/yBUz+Tu9PmfFKITzoyi1g5KcW8wBrczcq5RaNHF1W7ig7O PkJFFXD0UyvzCsZ45BicG1WaYXoDe4Jwj6L/dDTF23FiF7HCpjwfq59KBnTJaCaVzBOFI0GYblc63 M1gJX+F6hrBIeOMNfs7r4byL7iW0AcgQ==; Received: from ukleinek by master.debian.org with local (Exim 4.94.2) (envelope-from ) id 1rh3xm-00Ercc-Pg; Mon, 04 Mar 2024 08:46:22 +0000 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andrew Lunn , Heiko Stuebner Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH] arm64: dts: rockchip: qnap-ts433: Simplify network PHY connection Date: Mon, 4 Mar 2024 09:46:11 +0100 Message-ID: <20240304084612.711678-2-ukleinek@debian.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1462; i=ukleinek@debian.org; h=from:subject; bh=4yrGMDvfZ9+wFWFoQHVCdF6NRcyP2vDf9cQK0UPreuE=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBl5YpVyKWkqJ+XYrrPILxhXJLzu3+lqUe07dKSE DJVTb+H9LKJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZeWKVQAKCRCPgPtYfRL+ TkfwB/9OEwVLPuRfXHMa79cH2RyS1gKFPEzOCbIZCxP/4+z14rScVrdyXrhAYdyFnBqM+KkrMih syJUAmdoeSLct5tuvFmCWsh7NHILU6aF28FtAnUSJkBMlK69ZvZYah0oK8HrktTYXCNQMa9O0Q+ wXvICBrKUyNp6JOvd/5a1YPyCFfNxPTp6lNTkmLmyRIQxIHGHJGuQCK4P+I8mG5IZQYMK+EC435 jPweMB8vz+OKrp1h7Owl1//JaNtp97Ecbdov5LlU4Cnv/m5BCjJ8usOnTMdNCOuuV6VmtkMXw4m JbKsBPux+6TsSME3hS+7xDrCOO1jW1U7tgEZvuihAx55OfxE X-Developer-Key: i=ukleinek@debian.org; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240304_004653_906362_87730B32 X-CRM114-Status: GOOD ( 11.67 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org While it requires to have the right phy driver loaded (i.e. motorcomm) to make the phy asserting the right delays, this is generally the preferred way to define the MAC <-> PHY connection. Signed-off-by: Uwe Kleine-König Reviewed-by: Andrew Lunn --- Hello, Andrew already pointed out when I posted the patch introducing the gmac0 node that rgmii-id would be the preferred way to setup things. Back then this didn't happen because this change broke reception of network packets. However this only happend because I didn't have the right phy driver loaded. Best regards Uwe arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89 diff --git a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts index 6a998166003c..36ad48d46bc1 100644 --- a/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts +++ b/arch/arm64/boot/dts/rockchip/rk3568-qnap-ts433.dts @@ -20,15 +20,13 @@ &gmac0 { assigned-clock-rates = <0>, <125000000>; clock_in_out = "output"; phy-handle = <&rgmii_phy0>; - phy-mode = "rgmii"; + phy-mode = "rgmii-id"; pinctrl-names = "default"; pinctrl-0 = <&gmac0_miim &gmac0_tx_bus2 &gmac0_rx_bus2 &gmac0_rgmii_clk &gmac0_rgmii_bus>; - rx_delay = <0x2f>; - tx_delay = <0x3c>; status = "okay"; };