| Message ID | 20240408222926.32708-1-cristian.ciocaltea@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL | expand |
Am Dienstag, 9. April 2024, 00:29:25 CEST schrieb Cristian Ciocaltea: > Ensure CONFIG_RATIONAL is selected in order to fix the following link > error with some kernel configurations: > > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.o: in function `rk_hdptx_ropll_tmds_cmn_config': > phy-rockchip-samsung-hdptx.c:(.text+0x950): undefined reference to `rational_best_approximation' > > Fixes: 553be2830c5f ("phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202404090540.2l1TEkDF-lkp@intel.com/ > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> Reviewed-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/phy/rockchip/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig > index a34f67bb7e61..b60a4b60451e 100644 > --- a/drivers/phy/rockchip/Kconfig > +++ b/drivers/phy/rockchip/Kconfig > @@ -87,6 +87,7 @@ config PHY_ROCKCHIP_SAMSUNG_HDPTX > tristate "Rockchip Samsung HDMI/eDP Combo PHY driver" > depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF > select GENERIC_PHY > + select RATIONAL > help > Enable this to support the Rockchip HDMI/eDP Combo PHY > with Samsung IP block. >
On Tue, 09 Apr 2024 01:29:25 +0300, Cristian Ciocaltea wrote: > Ensure CONFIG_RATIONAL is selected in order to fix the following link > error with some kernel configurations: > > drivers/phy/rockchip/phy-rockchip-samsung-hdptx.o: in function `rk_hdptx_ropll_tmds_cmn_config': > phy-rockchip-samsung-hdptx.c:(.text+0x950): undefined reference to `rational_best_approximation' > > > [...] Applied, thanks! [1/1] phy: phy-rockchip-samsung-hdptx: Select CONFIG_RATIONAL commit: e1c9216bec2793d051f83d77d93d3d6a899d06d1 Best regards,
diff --git a/drivers/phy/rockchip/Kconfig b/drivers/phy/rockchip/Kconfig index a34f67bb7e61..b60a4b60451e 100644 --- a/drivers/phy/rockchip/Kconfig +++ b/drivers/phy/rockchip/Kconfig @@ -87,6 +87,7 @@ config PHY_ROCKCHIP_SAMSUNG_HDPTX tristate "Rockchip Samsung HDMI/eDP Combo PHY driver" depends on (ARCH_ROCKCHIP || COMPILE_TEST) && OF select GENERIC_PHY + select RATIONAL help Enable this to support the Rockchip HDMI/eDP Combo PHY with Samsung IP block.
Ensure CONFIG_RATIONAL is selected in order to fix the following link error with some kernel configurations: drivers/phy/rockchip/phy-rockchip-samsung-hdptx.o: in function `rk_hdptx_ropll_tmds_cmn_config': phy-rockchip-samsung-hdptx.c:(.text+0x950): undefined reference to `rational_best_approximation' Fixes: 553be2830c5f ("phy: rockchip: Add Samsung HDMI/eDP Combo PHY driver") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202404090540.2l1TEkDF-lkp@intel.com/ Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com> --- drivers/phy/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+)