| Message ID | 20240612-6-10-rocket-v1-1-060e48eea250@tomeuvizoso.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | New DRM accel driver for Rockchip's RKNN NPU | expand |
Hello Tomeu, On Wed, Jun 12, 2024 at 03:52:54PM GMT, Tomeu Vizoso wrote: > So far, seems to be fully compatible with the one in the RK3568. > > The bindings already had this compatible, but the driver didn't > advertise it. > > Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net> > --- The driver does not need to advise it, since it already handles "rockchip,rk3568-iommu" and the correct compatible for the RK3588 IOMMU is: compatible = "rockchip,rk3588-iommu", "rockchip,rk3568-iommu"; i.e. with the RK3568 compatible as fallback. So the kernel will just bind to the fallback compatible. Iff differences are found in the future, the kernel can start to make use of the more specific compatible. -- Sebastian > drivers/iommu/rockchip-iommu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c > index 4b369419b32c..f5629515bd78 100644 > --- a/drivers/iommu/rockchip-iommu.c > +++ b/drivers/iommu/rockchip-iommu.c > @@ -1363,6 +1363,9 @@ static const struct of_device_id rk_iommu_dt_ids[] = { > { .compatible = "rockchip,rk3568-iommu", > .data = &iommu_data_ops_v2, > }, > + { .compatible = "rockchip,rk3588-iommu", > + .data = &iommu_data_ops_v2, > + }, > { /* sentinel */ } > }; > > > -- > 2.45.2 > >
diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/iommu/rockchip-iommu.c index 4b369419b32c..f5629515bd78 100644 --- a/drivers/iommu/rockchip-iommu.c +++ b/drivers/iommu/rockchip-iommu.c @@ -1363,6 +1363,9 @@ static const struct of_device_id rk_iommu_dt_ids[] = { { .compatible = "rockchip,rk3568-iommu", .data = &iommu_data_ops_v2, }, + { .compatible = "rockchip,rk3588-iommu", + .data = &iommu_data_ops_v2, + }, { /* sentinel */ } };
So far, seems to be fully compatible with the one in the RK3568. The bindings already had this compatible, but the driver didn't advertise it. Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net> --- drivers/iommu/rockchip-iommu.c | 3 +++ 1 file changed, 3 insertions(+)