| Message ID | 20240612173213.42827-2-sebastian.reichel@collabora.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | RK3588 VEPU121/VPU121 support | expand |
On Wed, 12 Jun 2024 19:15:41 +0200, Sebastian Reichel wrote: > From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > > This encoder-only device is present four times on this SoC, and should > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > encoding). No fallback compatible has been added, since the operating > systems might already support RK3568 VEPU and want to avoid registering > four of them separately considering they can be used as a cluster. > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > --- > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml: properties:compatible:oneOf: [{'const': 'rockchip,rk3568-vepu'}, {'const': 'rockchip,rk3588-vepu121'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}} hint: Use 'enum' rather than 'oneOf' + 'const' entries from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240612173213.42827-2-sebastian.reichel@collabora.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
Hi, On Wed, Jun 12, 2024 at 12:26:32PM GMT, Rob Herring (Arm) wrote: > On Wed, 12 Jun 2024 19:15:41 +0200, Sebastian Reichel wrote: > > From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > > > > This encoder-only device is present four times on this SoC, and should > > support everything the rk3568 vepu supports (so JPEG, H.264 and VP8 > > encoding). No fallback compatible has been added, since the operating > > systems might already support RK3568 VEPU and want to avoid registering > > four of them separately considering they can be used as a cluster. > > > > Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> > > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> > > --- > > .../devicetree/bindings/media/rockchip,rk3568-vepu.yaml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml: properties:compatible:oneOf: [{'const': 'rockchip,rk3568-vepu'}, {'const': 'rockchip,rk3588-vepu121'}] should not be valid under {'items': {'propertyNames': {'const': 'const'}, 'required': ['const']}} > hint: Use 'enum' rather than 'oneOf' + 'const' entries > from schema $id: http://devicetree.org/meta-schemas/keywords.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240612173213.42827-2-sebastian.reichel@collabora.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. oops. That's on me for not doing another test and doing something stupid. I obviously wanted this and didn't recheck the bindings after dropping the fallback compatible. enum: - rockchip,rk3568-vepu - rockchip,rk3588-vepu121 I will change it in v6 if people are fine with this solution. -- Sebastian
On 13/06/2024 00:20, Sebastian Reichel wrote: > oops. That's on me for not doing another test and doing something > stupid. I obviously wanted this and didn't recheck the bindings > after dropping the fallback compatible. > > enum: > - rockchip,rk3568-vepu > - rockchip,rk3588-vepu121 > > I will change it in v6 if people are fine with this solution. Ack Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml index 9d90d8d0565a..8b9496e6a2bb 100644 --- a/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vepu.yaml @@ -15,8 +15,9 @@ description: properties: compatible: - enum: - - rockchip,rk3568-vepu + oneOf: + - const: rockchip,rk3568-vepu + - const: rockchip,rk3588-vepu121 reg: maxItems: 1