| Message ID | 20240802042552.663-1-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: make USB gadget functions usable on Radxa ROCK 3C | expand |
hi, please don't merge this for a while. I'm thinking opposite change may be better to align with ROCK 4/5 series. (OTG port is "host") any comment? -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. On 8/2/24 13:25, FUKAUMI Naoki wrote: > Radxa ROCK 3A and 3B use a USB 3.0 Type-A OTG port as "otg" mode for > USB gadget functions. > > Radxa ROCK 3C also has a USB 2.0 Type-A OTG port, it should be "otg" > mode for USB gadget functions. > > Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C") > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- > arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts > index f2cc086e5001..a9535eaa5235 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts > @@ -664,7 +664,6 @@ &usb_host0_ohci { > }; > > &usb_host0_xhci { > - dr_mode = "host"; > status = "okay"; > }; >
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts index f2cc086e5001..a9535eaa5235 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts @@ -664,7 +664,6 @@ &usb_host0_ohci { }; &usb_host0_xhci { - dr_mode = "host"; status = "okay"; };
Radxa ROCK 3A and 3B use a USB 3.0 Type-A OTG port as "otg" mode for USB gadget functions. Radxa ROCK 3C also has a USB 2.0 Type-A OTG port, it should be "otg" mode for USB gadget functions. Fixes: ee219017ddb5 ("arm64: dts: rockchip: Add Radxa ROCK 3C") Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- arch/arm64/boot/dts/rockchip/rk3566-rock-3c.dts | 1 - 1 file changed, 1 deletion(-)