diff mbox series

[01/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi S

Message ID 20240808093808.1740-2-naoki@radxa.com (mailing list archive)
State New
Headers show
Series arm64: dts: rockchip: standardize the definition of LEDs for Radxa boards | expand

Commit Message

FUKAUMI Naoki Aug. 8, 2024, 9:37 a.m. UTC
- remove label
- cosmetic change

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Krzysztof Kozlowski Aug. 8, 2024, 10:51 a.m. UTC | #1
On 08/08/2024 11:37, FUKAUMI Naoki wrote:
> - remove label

Why? You affect user-space.

> - cosmetic change

What? Why? Commit subject also does not help here at all.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
index 62d18ca769a1..504054f9723e 100644
--- a/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3308-rock-pi-s.dts
@@ -27,14 +27,13 @@  chosen {
 	leds {
 		compatible = "gpio-leds";
 		pinctrl-names = "default";
-		pinctrl-0 = <&green_led>, <&heartbeat_led>;
+		pinctrl-0 = <&green_led &heartbeat_led>;
 
 		green-led {
 			color = <LED_COLOR_ID_GREEN>;
 			default-state = "on";
 			function = LED_FUNCTION_POWER;
 			gpios = <&gpio0 RK_PA6 GPIO_ACTIVE_HIGH>;
-			label = "rockpis:green:power";
 			linux,default-trigger = "default-on";
 		};
 
@@ -43,7 +42,6 @@  blue-led {
 			default-state = "on";
 			function = LED_FUNCTION_HEARTBEAT;
 			gpios = <&gpio0 RK_PA5 GPIO_ACTIVE_HIGH>;
-			label = "rockpis:blue:user";
 			linux,default-trigger = "heartbeat";
 		};
 	};