diff mbox series

[02/10] arm64: dts: rockchip: standardize the definition of LEDs for Radxa ROCK Pi E

Message ID 20240808093808.1740-3-naoki@radxa.com (mailing list archive)
State New
Headers show
Series arm64: dts: rockchip: standardize the definition of LEDs for Radxa boards | expand

Commit Message

FUKAUMI Naoki Aug. 8, 2024, 9:38 a.m. UTC
- sort properties
- add default-state and function

Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
---
 arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Aug. 8, 2024, 10:52 a.m. UTC | #1
On 08/08/2024 11:38, FUKAUMI Naoki wrote:
> - sort properties

You mean un-sort?!?!

> - add default-state and function

Commit subject is totally wrong. Sorry, write specific subjects
describing what you are doing. There is no standardization happening
here, whatever that means.

> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> index bb01143dc91a..4e77701f2e01 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
> @@ -49,11 +49,13 @@ gmac_clkin: external-gmac-clock {
>  
>  	leds {
>  		compatible = "gpio-leds";
> -		pinctrl-0 = <&led_pin>;
>  		pinctrl-names = "default";
> +		pinctrl-0 = <&led_pin>;

Nope, that's wrong order.

>  

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
index bb01143dc91a..4e77701f2e01 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3328-rock-pi-e.dtsi
@@ -49,11 +49,13 @@  gmac_clkin: external-gmac-clock {
 
 	leds {
 		compatible = "gpio-leds";
-		pinctrl-0 = <&led_pin>;
 		pinctrl-names = "default";
+		pinctrl-0 = <&led_pin>;
 
 		led-0 {
 			color = <LED_COLOR_ID_BLUE>;
+			default-state = "on";
+			function = LED_FUNCTION_HEARTBEAT;
 			gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>;
 			linux,default-trigger = "heartbeat";
 		};