| Message ID | 20240816023243.487-1-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] arm64: defconfig: add CONFIG_LEDS_PWM_MULTICOLOR | expand |
On 16/08/2024 04:32, FUKAUMI Naoki wrote:
> enable "pwm-leds-multicolor" driver.
Why?
Best regards,
Krzysztof
Hi, thank you very much for your review. but, I decided not to use "pwm-leds-multicolor" for Radxa E25. please ignore this patch series. really sorry. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. On 8/16/24 14:18, Krzysztof Kozlowski wrote: > On 16/08/2024 04:32, FUKAUMI Naoki wrote: >> enable "pwm-leds-multicolor" driver. > > Why? > > Best regards, > Krzysztof > >
Hi, Am Freitag, 16. August 2024, 13:06:37 CEST schrieb FUKAUMI Naoki: > thank you very much for your review. > > but, I decided not to use "pwm-leds-multicolor" for Radxa E25. > please ignore this patch series. What Krzysztof meant was probably more in line of that a commit message should not explain what the commit does, because that can be seen in the code. Instead the commit message should explain why that change is needed. > really sorry. > > Best regards, > > -- > FUKAUMI Naoki > Radxa Computer (Shenzhen) Co., Ltd. > > On 8/16/24 14:18, Krzysztof Kozlowski wrote: > > On 16/08/2024 04:32, FUKAUMI Naoki wrote: > >> enable "pwm-leds-multicolor" driver. > > > > Why? > > > > Best regards, > > Krzysztof > > > > > >
Hi, On 8/16/24 20:29, Heiko Stübner wrote: > Hi, > > Am Freitag, 16. August 2024, 13:06:37 CEST schrieb FUKAUMI Naoki: >> thank you very much for your review. >> >> but, I decided not to use "pwm-leds-multicolor" for Radxa E25. >> please ignore this patch series. > > What Krzysztof meant was probably more in line of that a commit message > should not explain what the commit does, because that can be seen in the > code. > > Instead the commit message should explain why that change is needed. I see, but there is no reason to use "pwm-leds-multicolor" anymore, please ignore this patch series. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. >> really sorry. >> >> Best regards, >> >> -- >> FUKAUMI Naoki >> Radxa Computer (Shenzhen) Co., Ltd. >> >> On 8/16/24 14:18, Krzysztof Kozlowski wrote: >>> On 16/08/2024 04:32, FUKAUMI Naoki wrote: >>>> enable "pwm-leds-multicolor" driver. >>> >>> Why? >>> >>> Best regards, >>> Krzysztof >>> >>> >> >> > > > > >
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index b14cc106e4f7..725eaadc22a9 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1171,6 +1171,7 @@ CONFIG_LEDS_PCA9532=m CONFIG_LEDS_GPIO=y CONFIG_LEDS_PWM=y CONFIG_LEDS_SYSCON=y +CONFIG_LEDS_PWM_MULTICOLOR=m CONFIG_LEDS_QCOM_LPG=m CONFIG_LEDS_TRIGGER_TIMER=y CONFIG_LEDS_TRIGGER_DISK=y
enable "pwm-leds-multicolor" driver. Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)