| Message ID | 20241015192905.28969-1-cenk.uluisik@googlemail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v6,1/2] dt-bindings: arm: rockchip: Add Orange Pi 5b enum to Orange Pi 5 entry | expand |
On Tue, Oct 15, 2024 at 09:28:35PM +0200, Cenk Uluisik wrote: > This extends the Xunlong Orange Pi 5 device tree binding with an enum for > the Orange Pi 5b, which is implemented before the device tree. > > How does this board differ from the original Orange Pi 5? > - the Orange Pi 5 has a M.2 NVMe M-key PCI 2.0x1 > slot (hooked to combphy0_ps) whereas the Orange Pi 5b uses combphy0_ps > for the WiFi. > - The Orange Pi 5 with the M.2 socket has a regulator defined hooked to > "GPIO0_C5" (i.e. PCIE_PWREN_H) whereas the Orange Pi 5B has GPIO0_C5 > hooked to BT_WAKE_HOST. > - builtin eMMC storage > - no SPI NOR flash (u-boot, preboot etc. initiates > from within the eMMC > storage) > - ap6275p Wifi module (like the Orange Pi 5 Plus) > - builtin BlueTooth module > > Signed-off-by: Cenk Uluisik <cenk.uluisik@googlemail.com> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Well, still kind of too fast because I just acked v5. Before you send v7, read the process for adding tags. You should also read the part on adding change log to your patches. > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 687823e58c22..62bb6587da8f 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -1051,7 +1051,9 @@ properties: > > - description: Xunlong Orange Pi 5 > items: > - - const: xunlong,orangepi-5 > + - enum: > + - xunlong,orangepi-5 > + - xunlong,orangepi-5b > - const: rockchip,rk3588s > > - description: Zkmagic A95X Z2 > -- > 2.46.1 >
Am Dienstag, 15. Oktober 2024, 21:28:35 CEST schrieb Cenk Uluisik: > This extends the Xunlong Orange Pi 5 device tree binding with an enum for > the Orange Pi 5b, which is implemented before the device tree. > > How does this board differ from the original Orange Pi 5? > - the Orange Pi 5 has a M.2 NVMe M-key PCI 2.0x1 > slot (hooked to combphy0_ps) whereas the Orange Pi 5b uses combphy0_ps > for the WiFi. > - The Orange Pi 5 with the M.2 socket has a regulator defined hooked to > "GPIO0_C5" (i.e. PCIE_PWREN_H) whereas the Orange Pi 5B has GPIO0_C5 > hooked to BT_WAKE_HOST. > - builtin eMMC storage > - no SPI NOR flash (u-boot, preboot etc. initiates > from within the eMMC > storage) > - ap6275p Wifi module (like the Orange Pi 5 Plus) > - builtin BlueTooth module > > Signed-off-by: Cenk Uluisik <cenk.uluisik@googlemail.com> > --- In its v5, this patch received [0] a Reviewed-by: Rob Herring (Arm) <robh@kernel.org> which overlapped with this version getting sent out. The patch contents look identical between that version and this one. Heiko [0] https://lore.kernel.org/all/172902320363.1787838.552661206100007627.robh@kernel.org/ > Documentation/devicetree/bindings/arm/rockchip.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 687823e58c22..62bb6587da8f 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -1051,7 +1051,9 @@ properties: > > - description: Xunlong Orange Pi 5 > items: > - - const: xunlong,orangepi-5 > + - enum: > + - xunlong,orangepi-5 > + - xunlong,orangepi-5b > - const: rockchip,rk3588s > > - description: Zkmagic A95X Z2 >
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 687823e58c22..62bb6587da8f 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -1051,7 +1051,9 @@ properties: - description: Xunlong Orange Pi 5 items: - - const: xunlong,orangepi-5 + - enum: + - xunlong,orangepi-5 + - xunlong,orangepi-5b - const: rockchip,rk3588s - description: Zkmagic A95X Z2
This extends the Xunlong Orange Pi 5 device tree binding with an enum for the Orange Pi 5b, which is implemented before the device tree. How does this board differ from the original Orange Pi 5? - the Orange Pi 5 has a M.2 NVMe M-key PCI 2.0x1 slot (hooked to combphy0_ps) whereas the Orange Pi 5b uses combphy0_ps for the WiFi. - The Orange Pi 5 with the M.2 socket has a regulator defined hooked to "GPIO0_C5" (i.e. PCIE_PWREN_H) whereas the Orange Pi 5B has GPIO0_C5 hooked to BT_WAKE_HOST. - builtin eMMC storage - no SPI NOR flash (u-boot, preboot etc. initiates from within the eMMC storage) - ap6275p Wifi module (like the Orange Pi 5 Plus) - builtin BlueTooth module Signed-off-by: Cenk Uluisik <cenk.uluisik@googlemail.com> --- Documentation/devicetree/bindings/arm/rockchip.yaml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)