| Message ID | 20241216113052.15696-11-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Refine dts for Radxa ROCK 5C | expand |
On 16/12/2024 12:30, FUKAUMI Naoki wrote: > Fix pmic dcdc-reg10 label to match with schematic[1]. No functional > change. > > [1] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf > > Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C") All your commits have the same flaw. You claim there is no functional change, yet there is a real bug to fix. All such trivial cleanups are not fixes and should be squashed together. Best regards, Krzysztof
On 12/16/24 22:40, Krzysztof Kozlowski wrote: > On 16/12/2024 12:30, FUKAUMI Naoki wrote: >> Fix pmic dcdc-reg10 label to match with schematic[1]. No functional >> change. >> >> [1] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf >> >> Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C") > > All your commits have the same flaw. You claim there is no functional > change, yet there is a real bug to fix. > > All such trivial cleanups are not fixes and should be squashed together. I see, I'll do "squashed together" for trivial/cosmetic/no functional changes without "Fixes" tag. Thanks for pointing. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts index 0f8048f6511b..fbe491e63852 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts @@ -670,8 +670,8 @@ regulator-state-mem { }; }; - vcc1v8_pmu_ddr_s3: dcdc-reg10 { - regulator-name = "vcc1v8_pmu_ddr_s3"; + vcc_1v8_s3: dcdc-reg10 { + regulator-name = "vcc_1v8_s3"; regulator-always-on; regulator-boot-on; regulator-min-microvolt = <1800000>;
Fix pmic dcdc-reg10 label to match with schematic[1]. No functional change. [1] https://dl.radxa.com/rock5/5c/docs/hw/v1100/radxa_rock_5c_schematic_v1100.pdf Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C") Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- Changes in v5: - Reword commit message Changes in v4: - none Changes in v3: - none Changes in v2: - split from "arm64: dts: rockchip: fix pmic properties for Radxa ROCK 5C" --- arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)