| Message ID | 20241223110637.3697974-6-kever.yang@rock-chips.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Rockchip: add Rockchip rk3576 EVB1 board | expand |
On Mon, Dec 23, 2024 at 07:06:35PM +0800, Kever Yang wrote:
> The board entries should be sort in correct order.
And what is the sorting rule for this file? Board name? SoC compatible?
Explain this in commit msg... and please test your patches before
posting. Public infrastructure is not replacement of your tests (see
failiure reported by Rob).
Best regards,
Krzysztof
Hi Krzysztof On 2024/12/23 22:58, Krzysztof Kozlowski wrote: > On Mon, Dec 23, 2024 at 07:06:35PM +0800, Kever Yang wrote: >> The board entries should be sort in correct order. > And what is the sorting rule for this file? Board name? SoC compatible? This is sort by the description msg, which should be easy to find out if look at the content in the file instead of the patch. Will update the commit msg. > Explain this in commit msg... and please test your patches before > posting. Public infrastructure is not replacement of your tests (see > failiure reported by Rob). I do run the test in my side, but the tool does not show this warning, not sure if because of my tool not up to date. Thanks, - Kever > > Best regards, > Krzysztof > >
On 07/01/2025 08:28, Kever Yang wrote: > Hi Krzysztof > > On 2024/12/23 22:58, Krzysztof Kozlowski wrote: >> On Mon, Dec 23, 2024 at 07:06:35PM +0800, Kever Yang wrote: >>> The board entries should be sort in correct order. >> And what is the sorting rule for this file? Board name? SoC compatible? > > This is sort by the description msg, which should be easy to find out if > look at > > the content in the file instead of the patch. Content of the patch does not show me *EXISTING* sorting. I want to know that you understand existing sorting, before introducing "sort the boards" change. Best regards, Krzysztof
Hi Krzysztof On 2024/12/23 22:58, Krzysztof Kozlowski wrote: > On Mon, Dec 23, 2024 at 07:06:35PM +0800, Kever Yang wrote: >> The board entries should be sort in correct order. > And what is the sorting rule for this file? Board name? SoC compatible? This is sort by the description msg, which should be easy to find out if look at the content in the file instead of the patch. Will update the commit msg. > Explain this in commit msg... and please test your patches before > posting. Public infrastructure is not replacement of your tests (see > failiure reported by Rob). I do run the test in my side, but the tool does not show this warning, not sure if because of my tool not up to date. Thanks, - Kever > > Best regards, > Krzysztof > >
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml index 753199a12923..01439d7bbde9 100644 --- a/Documentation/devicetree/bindings/arm/rockchip.yaml +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml @@ -1006,6 +1006,16 @@ properties: - const: rockchip,rk3399-sapphire-excavator - const: rockchip,rk3399 + - description: Rockchip RK3566 BOX Evaluation Demo board + items: + - const: rockchip,rk3566-box-demo + - const: rockchip,rk3566 + + - description: Rockchip RK3568 Evaluation board + items: + - const: rockchip,rk3568-evb1-v10 + - const: rockchip,rk3568 + - description: Rockchip RK3588 Evaluation board items: - const: rockchip,rk3588-evb1-v10 @@ -1026,6 +1036,23 @@ properties: - const: rockchip,rk3588-toybrick-x0 - const: rockchip,rk3588 + - description: Sinovoip RK3308 Banana Pi P2 Pro + items: + - const: sinovoip,rk3308-bpi-p2pro + - const: rockchip,rk3308 + + - description: Sinovoip RK3568 Banana Pi R2 Pro + items: + - const: sinovoip,rk3568-bpi-r2pro + - const: rockchip,rk3568 + + - description: Sonoff iHost Smart Home Hub + items: + - const: itead,sonoff-ihost + - enum: + - rockchip,rv1126 + - rockchip,rv1109 + - description: Theobroma Systems PX30-uQ7 with Haikou baseboard items: - const: tsd,px30-ringneck-haikou @@ -1099,33 +1126,6 @@ properties: - const: zkmagic,a95x-z2 - const: rockchip,rk3318 - - description: Rockchip RK3566 BOX Evaluation Demo board - items: - - const: rockchip,rk3566-box-demo - - const: rockchip,rk3566 - - - description: Rockchip RK3568 Evaluation board - items: - - const: rockchip,rk3568-evb1-v10 - - const: rockchip,rk3568 - - - description: Sinovoip RK3308 Banana Pi P2 Pro - items: - - const: sinovoip,rk3308-bpi-p2pro - - const: rockchip,rk3308 - - - description: Sinovoip RK3568 Banana Pi R2 Pro - items: - - const: sinovoip,rk3568-bpi-r2pro - - const: rockchip,rk3568 - - - description: Sonoff iHost Smart Home Hub - items: - - const: itead,sonoff-ihost - - enum: - - rockchip,rv1126 - - rockchip,rv1109 - additionalProperties: true ...
The board entries should be sort in correct order. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- Changes in v3: - sort for all the board entries instead of two rockchip boards Changes in v2: - collect acked-by tag .../devicetree/bindings/arm/rockchip.yaml | 54 +++++++++---------- 1 file changed, 27 insertions(+), 27 deletions(-)