| Message ID | 20241224094124.3816698-1-kever.yang@rock-chips.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] dt-bindings: net: Add support for rk3562 dwmac | expand |
Hi Kever, Am Dienstag, 24. Dezember 2024, 10:41:22 CET schrieb Kever Yang: > Add a rockchip,rk3562-gmac compatible for supporting the 2 gmac > devices on the rk3562. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index f8a576611d6c..02b7d9e78c40 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -24,6 +24,7 @@ select: > - rockchip,rk3366-gmac > - rockchip,rk3368-gmac > - rockchip,rk3399-gmac > + - rockchip,rk3562-gmac > - rockchip,rk3568-gmac > - rockchip,rk3576-gmac > - rockchip,rk3588-gmac > @@ -49,9 +50,11 @@ properties: > - rockchip,rk3366-gmac > - rockchip,rk3368-gmac > - rockchip,rk3399-gmac > + - rockchip,rk3562-gmac > - rockchip,rv1108-gmac > - items: > - enum: > + - rockchip,rk3562-gmac > - rockchip,rk3568-gmac > - rockchip,rk3576-gmac > - rockchip,rk3588-gmac You only need to add the rk3562 only to one of those blocks. The bottom one contains the snps,dwmac-4.20a element and looking at the soc devicetree, it seems that is the correct one: compatible = "rockchip,rk3562-gmac", "snps,dwmac-4.20a"; So you only need the second addition where the newer socs are in the enum. > @@ -59,7 +62,7 @@ properties: > - const: snps,dwmac-4.20a > > clocks: > - minItems: 5 > + minItems: 4 > maxItems: 8 This should get mentioned in the commit message Heiko
On Tue, Dec 24, 2024 at 05:41:22PM +0800, Kever Yang wrote: > Add a rockchip,rk3562-gmac compatible for supporting the 2 gmac > devices on the rk3562. Usual comments... we see what you did here. No need to repeat it in commit msg. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > index f8a576611d6c..02b7d9e78c40 100644 > --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml > @@ -24,6 +24,7 @@ select: > - rockchip,rk3366-gmac > - rockchip,rk3368-gmac > - rockchip,rk3399-gmac > + - rockchip,rk3562-gmac > - rockchip,rk3568-gmac > - rockchip,rk3576-gmac > - rockchip,rk3588-gmac > @@ -49,9 +50,11 @@ properties: > - rockchip,rk3366-gmac > - rockchip,rk3368-gmac > - rockchip,rk3399-gmac > + - rockchip,rk3562-gmac > - rockchip,rv1108-gmac > - items: > - enum: > + - rockchip,rk3562-gmac > - rockchip,rk3568-gmac > - rockchip,rk3576-gmac > - rockchip,rk3588-gmac > @@ -59,7 +62,7 @@ properties: > - const: snps,dwmac-4.20a > > clocks: > - minItems: 5 > + minItems: 4 So all devices now can have 4 clocks? No, constrain all variants. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml index f8a576611d6c..02b7d9e78c40 100644 --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml @@ -24,6 +24,7 @@ select: - rockchip,rk3366-gmac - rockchip,rk3368-gmac - rockchip,rk3399-gmac + - rockchip,rk3562-gmac - rockchip,rk3568-gmac - rockchip,rk3576-gmac - rockchip,rk3588-gmac @@ -49,9 +50,11 @@ properties: - rockchip,rk3366-gmac - rockchip,rk3368-gmac - rockchip,rk3399-gmac + - rockchip,rk3562-gmac - rockchip,rv1108-gmac - items: - enum: + - rockchip,rk3562-gmac - rockchip,rk3568-gmac - rockchip,rk3576-gmac - rockchip,rk3588-gmac @@ -59,7 +62,7 @@ properties: - const: snps,dwmac-4.20a clocks: - minItems: 5 + minItems: 4 maxItems: 8 clock-names:
Add a rockchip,rk3562-gmac compatible for supporting the 2 gmac devices on the rk3562. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- Documentation/devicetree/bindings/net/rockchip-dwmac.yaml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)