| Message ID | 20241224094920.3821861-7-kever.yang@rock-chips.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | rockchip: Add rk3562 support | expand |
Am Dienstag, 24. Dezember 2024, 10:49:09 CET schrieb Kever Yang: > rk3562 has 1 ARM Mali-G52 GPU,. > > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v2: None > > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 735c7f06c24e..b0d4806614aa 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -25,6 +25,7 @@ properties: > - renesas,r9a07g044-mali > - renesas,r9a07g054-mali > - rockchip,px30-mali > + - rockchip,rk3562-mali > - rockchip,rk3568-mali > - rockchip,rk3576-mali > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > @@ -60,7 +61,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 3 > + maxItems: 4 The commit message only says something about the rk3562. As it looks like you need another clock, the commit message should definitly explain that. Heiko
On Tue, Dec 24, 2024 at 05:49:09PM +0800, Kever Yang wrote: > rk3562 has 1 ARM Mali-G52 GPU,. > This we see from the diff. Say something not obvious. Where is the driver change? Why devices are or are not compatible? > Signed-off-by: Kever Yang <kever.yang@rock-chips.com> > --- > > Changes in v2: None > > Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > index 735c7f06c24e..b0d4806614aa 100644 > --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml > @@ -25,6 +25,7 @@ properties: > - renesas,r9a07g044-mali > - renesas,r9a07g054-mali > - rockchip,px30-mali > + - rockchip,rk3562-mali > - rockchip,rk3568-mali > - rockchip,rk3576-mali > - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable > @@ -60,7 +61,7 @@ properties: > > clocks: > minItems: 1 > - maxItems: 3 > + maxItems: 4 No, existing devices did not grow. Plus this is now desynced with the names. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml index 735c7f06c24e..b0d4806614aa 100644 --- a/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml +++ b/Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml @@ -25,6 +25,7 @@ properties: - renesas,r9a07g044-mali - renesas,r9a07g054-mali - rockchip,px30-mali + - rockchip,rk3562-mali - rockchip,rk3568-mali - rockchip,rk3576-mali - const: arm,mali-bifrost # Mali Bifrost GPU model/revision is fully discoverable @@ -60,7 +61,7 @@ properties: clocks: minItems: 1 - maxItems: 3 + maxItems: 4 clock-names: true
rk3562 has 1 ARM Mali-G52 GPU,. Signed-off-by: Kever Yang <kever.yang@rock-chips.com> --- Changes in v2: None Documentation/devicetree/bindings/gpu/arm,mali-bifrost.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)