| Message ID | 20250109032725.1102465-21-damon.ding@rock-chips.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add eDP support for RK3588 | expand |
Hi Damon, At 2025-01-09 11:27:25, "Damon Ding" <damon.ding@rock-chips.com> wrote: >Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: >- Set pinctrl of pwm12 for backlight >- Enable edp0/hdptxphy0/vp2 >- Add aux-bus/panel nodes > >Signed-off-by: Damon Ding <damon.ding@rock-chips.com> > >--- > >Changes in v2: >- Remove brightness-levels and default-brightness-level properties in > backlight node. >- Add the detail DT changes to commit message. > >Changes in v3: >- Use aux-bus instead of platform bus for edp-panel. > >Changes in v4: >- Add comments related to the use of panel compatible "lg,lp079qx1-sp0v" > in the commit message. > >Changes in v5: >- Use "edp-panel" instead of "lg,lp079qx1-sp0v" >- Remove unnecessary comments in commit message >- Assign the parent of DCLK_VOP2_SRC to PLL_V0PLL >--- > .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > >diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >index bc4077575beb..a8c151b41e21 100644 >--- a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >+++ b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >@@ -9,6 +9,7 @@ > #include <dt-bindings/gpio/gpio.h> > #include <dt-bindings/input/input.h> > #include <dt-bindings/pinctrl/rockchip.h> >+#include <dt-bindings/soc/rockchip,vop2.h> > #include <dt-bindings/usb/pd.h> > #include "rk3588s.dtsi" > >@@ -238,6 +239,41 @@ &combphy2_psu { > status = "okay"; > }; > >+&edp0 { >+ force-hpd; >+ status = "okay"; >+ >+ aux-bus { >+ panel { >+ compatible = "edp-panel"; >+ backlight = <&backlight>; >+ power-supply = <&vcc3v3_lcd_edp>; >+ >+ port { >+ panel_in_edp: endpoint { >+ remote-endpoint = <&edp_out_panel>; >+ }; >+ }; >+ }; >+ }; >+}; >+ >+&edp0_in { >+ edp0_in_vp2: endpoint { >+ remote-endpoint = <&vp2_out_edp0>; >+ }; >+}; >+ >+&edp0_out { >+ edp_out_panel: endpoint { >+ remote-endpoint = <&panel_in_edp>; >+ }; >+}; >+ >+&hdptxphy0 { >+ status = "okay"; >+}; >+ > &i2c3 { > status = "okay"; > >@@ -399,6 +435,7 @@ usbc0_int: usbc0-int { > }; > > &pwm12 { >+ pinctrl-0 = <&pwm12m1_pins>; > status = "okay"; > }; > >@@ -1168,3 +1205,20 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 { > }; > }; > }; >+ >+&vop_mmu { >+ status = "okay"; >+}; >+ >+&vop { >+ assigned-clocks = <&cru DCLK_VOP2_SRC>; >+ assigned-clock-parents = <&cru PLL_V0PLL>; It's necessary to explain why we need to assign V0PLL for DCLK_VOP2_SRC in commit message. >+ status = "okay"; >+}; >+ >+&vp2 { >+ vp2_out_edp0: endpoint@ROCKCHIP_VOP2_EP_EDP0 { >+ reg = <ROCKCHIP_VOP2_EP_EDP0>; >+ remote-endpoint = <&edp0_in_vp2>; >+ }; >+}; >-- >2.34.1 >
Hi Andy, On 2025/1/11 18:28, Andy Yan wrote: > > Hi Damon, > > At 2025-01-09 11:27:25, "Damon Ding" <damon.ding@rock-chips.com> wrote: >> Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: >> - Set pinctrl of pwm12 for backlight >> - Enable edp0/hdptxphy0/vp2 >> - Add aux-bus/panel nodes >> >> Signed-off-by: Damon Ding <damon.ding@rock-chips.com> >> >> --- >> >> Changes in v2: >> - Remove brightness-levels and default-brightness-level properties in >> backlight node. >> - Add the detail DT changes to commit message. >> >> Changes in v3: >> - Use aux-bus instead of platform bus for edp-panel. >> >> Changes in v4: >> - Add comments related to the use of panel compatible "lg,lp079qx1-sp0v" >> in the commit message. >> >> Changes in v5: >> - Use "edp-panel" instead of "lg,lp079qx1-sp0v" >> - Remove unnecessary comments in commit message >> - Assign the parent of DCLK_VOP2_SRC to PLL_V0PLL >> --- >> .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 54 +++++++++++++++++++ >> 1 file changed, 54 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> index bc4077575beb..a8c151b41e21 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> +++ b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts >> @@ -9,6 +9,7 @@ >> #include <dt-bindings/gpio/gpio.h> >> #include <dt-bindings/input/input.h> >> #include <dt-bindings/pinctrl/rockchip.h> >> +#include <dt-bindings/soc/rockchip,vop2.h> >> #include <dt-bindings/usb/pd.h> >> #include "rk3588s.dtsi" >> >> @@ -238,6 +239,41 @@ &combphy2_psu { >> status = "okay"; >> }; >> >> +&edp0 { >> + force-hpd; >> + status = "okay"; >> + >> + aux-bus { >> + panel { >> + compatible = "edp-panel"; >> + backlight = <&backlight>; >> + power-supply = <&vcc3v3_lcd_edp>; >> + >> + port { >> + panel_in_edp: endpoint { >> + remote-endpoint = <&edp_out_panel>; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> +&edp0_in { >> + edp0_in_vp2: endpoint { >> + remote-endpoint = <&vp2_out_edp0>; >> + }; >> +}; >> + >> +&edp0_out { >> + edp_out_panel: endpoint { >> + remote-endpoint = <&panel_in_edp>; >> + }; >> +}; >> + >> +&hdptxphy0 { >> + status = "okay"; >> +}; >> + >> &i2c3 { >> status = "okay"; >> >> @@ -399,6 +435,7 @@ usbc0_int: usbc0-int { >> }; >> >> &pwm12 { >> + pinctrl-0 = <&pwm12m1_pins>; >> status = "okay"; >> }; >> >> @@ -1168,3 +1205,20 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 { >> }; >> }; >> }; >> + >> +&vop_mmu { >> + status = "okay"; >> +}; >> + >> +&vop { >> + assigned-clocks = <&cru DCLK_VOP2_SRC>; >> + assigned-clock-parents = <&cru PLL_V0PLL>; > > It's necessary to explain why we need to assign V0PLL for DCLK_VOP2_SRC in commit message. > > I will add relevant explainations in next version. >> + status = "okay"; >> +}; >> + >> +&vp2 { >> + vp2_out_edp0: endpoint@ROCKCHIP_VOP2_EP_EDP0 { >> + reg = <ROCKCHIP_VOP2_EP_EDP0>; >> + remote-endpoint = <&edp0_in_vp2>; >> + }; >> +}; >> -- >> 2.34.1 >> Best regards, Damon
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts index bc4077575beb..a8c151b41e21 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-evb1-v10.dts @@ -9,6 +9,7 @@ #include <dt-bindings/gpio/gpio.h> #include <dt-bindings/input/input.h> #include <dt-bindings/pinctrl/rockchip.h> +#include <dt-bindings/soc/rockchip,vop2.h> #include <dt-bindings/usb/pd.h> #include "rk3588s.dtsi" @@ -238,6 +239,41 @@ &combphy2_psu { status = "okay"; }; +&edp0 { + force-hpd; + status = "okay"; + + aux-bus { + panel { + compatible = "edp-panel"; + backlight = <&backlight>; + power-supply = <&vcc3v3_lcd_edp>; + + port { + panel_in_edp: endpoint { + remote-endpoint = <&edp_out_panel>; + }; + }; + }; + }; +}; + +&edp0_in { + edp0_in_vp2: endpoint { + remote-endpoint = <&vp2_out_edp0>; + }; +}; + +&edp0_out { + edp_out_panel: endpoint { + remote-endpoint = <&panel_in_edp>; + }; +}; + +&hdptxphy0 { + status = "okay"; +}; + &i2c3 { status = "okay"; @@ -399,6 +435,7 @@ usbc0_int: usbc0-int { }; &pwm12 { + pinctrl-0 = <&pwm12m1_pins>; status = "okay"; }; @@ -1168,3 +1205,20 @@ usbdp_phy0_dp_altmode_mux: endpoint@1 { }; }; }; + +&vop_mmu { + status = "okay"; +}; + +&vop { + assigned-clocks = <&cru DCLK_VOP2_SRC>; + assigned-clock-parents = <&cru PLL_V0PLL>; + status = "okay"; +}; + +&vp2 { + vp2_out_edp0: endpoint@ROCKCHIP_VOP2_EP_EDP0 { + reg = <ROCKCHIP_VOP2_EP_EDP0>; + remote-endpoint = <&edp0_in_vp2>; + }; +};
Add the necessary DT changes to enable eDP0 on RK3588S EVB1 board: - Set pinctrl of pwm12 for backlight - Enable edp0/hdptxphy0/vp2 - Add aux-bus/panel nodes Signed-off-by: Damon Ding <damon.ding@rock-chips.com> --- Changes in v2: - Remove brightness-levels and default-brightness-level properties in backlight node. - Add the detail DT changes to commit message. Changes in v3: - Use aux-bus instead of platform bus for edp-panel. Changes in v4: - Add comments related to the use of panel compatible "lg,lp079qx1-sp0v" in the commit message. Changes in v5: - Use "edp-panel" instead of "lg,lp079qx1-sp0v" - Remove unnecessary comments in commit message - Assign the parent of DCLK_VOP2_SRC to PLL_V0PLL --- .../boot/dts/rockchip/rk3588s-evb1-v10.dts | 54 +++++++++++++++++++ 1 file changed, 54 insertions(+)